Format Rust code using rustfmt

.github/workflows/release.yml

@@ -1,98 +1,140 @@
 name: Rust static build and publish
+
 on:
   push:
     tags:
-    - '*'
+      - 'v*.*.*'
+
 env:
   CARGO_TERM_COLOR: always
-  BUILD_TARGET: x86_64-unknown-linux-musl
   BINARY_NAME: rexec
+
 jobs:
   build:
     name: Build static binary
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+        include:
+          - os: ubuntu-latest
+            build_target: x86_64-unknown-linux-musl
+            platform_name: linux-amd64
+          - os: windows-latest
+            build_target: x86_64-pc-windows-msvc
+            platform_name: windows-amd64
+          - os: macos-latest
+            build_target: aarch64-apple-darwin
+            platform_name: macos-arm64
     permissions:
       contents: write
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
+      
+      - name: Cache Cargo registry
+        uses: actions/cache@v4
+        with:
+          path: ~/.cargo/registry
+          key: ${{ runner.os }}-cargo-registry-${{ hashFiles('**/Cargo.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-cargo-registry-
+      
+      - name: Cache Cargo index
+        uses: actions/cache@v4
+        with:
+          path: ~/.cargo/git
+          key: ${{ runner.os }}-cargo-index-${{ hashFiles('**/Cargo.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-cargo-index-
+      
+      - name: Cache Cargo build
+        uses: actions/cache@v4
+        with:
+          path: target
+          key: ${{ runner.os }}-cargo-build-${{ hashFiles('**/Cargo.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-cargo-build-
+
       - uses: dtolnay/rust-toolchain@stable
+      
       - uses: mbrobbel/rustfmt-check@master
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
-      - name: Build-musl
+          
+      - name: Install rust targets
+        run: rustup target add ${{ matrix.build_target }}
+        
+      - name: Build Linux MUSL
+        if: matrix.os == 'ubuntu-latest'
         uses: gmiam/rust-musl-action@master
         with:
-          args: cargo build --target $BUILD_TARGET --release
+          args: cargo build --target ${{ matrix.build_target }} --release
+          
+      - name: Build MacOS
+        if: matrix.os == 'macos-latest'
+        run: cargo build --target ${{ matrix.build_target }} --release
+          
+      - name: Build Windows
+        if: matrix.os == 'windows-latest'
+        run: cargo build --target ${{ matrix.build_target }} --release
+          
+      - name: Upload artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: ${{ env.BINARY_NAME }}_${{ matrix.platform_name }}
+          path: target/${{ matrix.build_target }}/release/${{ env.BINARY_NAME }}*
+
+  release:
+    name: Create Release Page
+    needs: build
+    runs-on: ubuntu-latest
+    outputs:
+      upload_url: ${{ steps.create_release.outputs.upload_url }}
+    permissions:
+      contents: write
+    steps:
+      - uses: actions/checkout@v4
       - name: Get version
         run: echo "VERSION=$(grep -P '^version = \"\d+\.\d+\.\d+\"' Cargo.toml | awk -F '\"' '{print $2}')" >> $GITHUB_ENV
       - name: Show version
-        run:  echo ${{ env.VERSION }}
+        run: echo ${{ env.VERSION }}
-      - uses: actions/upload-artifact@v3.1.2
+      - uses: ncipollo/release-action@v1
-        name: Upload artifact
+        id: create_release
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          name: ${{ env.BINARY_NAME }}_${{ env.VERSION }}_${{ env.BUILD_TARGET }}
+          allowUpdates: true
-          path: target/${{ env.BUILD_TARGET }}/release/${{ env.BINARY_NAME }}
+          body: "Релиз rexec версии ${{ env.VERSION }}. Статические сборки для Linux (x86_64), Windows (x86_64) и MacOS (arm64)."
-  build_arch:
-    name: Arch Linux package
-    runs-on: ubuntu-latest
-    needs: ["build"]
-    container:
-      image: archlinux:base-devel
-      options: --user 1001
-    permissions:
-      contents: write
-    steps:
-      - uses: actions/checkout@v3
-      - name: Get version
-        run: echo "VERSION=$(grep -P '^version = \"\d+\.\d+\.\d+\"' Cargo.toml | awk -F '\"' '{print $2}')" >> $GITHUB_ENV
-      - uses: actions/download-artifact@master
-        name: Download
-        id: download_binary
-        with:
-          name: ${{ env.BINARY_NAME }}_${{ env.VERSION }}_${{ env.BUILD_TARGET }}
-          path: ${{ env.BINARY_NAME }}_${{ env.VERSION }}_${{ env.BUILD_TARGET }}
-      - name: Prepare build env
-        run: |
-          mkdir -p target/${{ env.BUILD_TARGET }}/release/
-          mv ${{ env.BINARY_NAME }}_${{ env.VERSION }}_${{ env.BUILD_TARGET }}/rexec target/${{ env.BUILD_TARGET }}/release/
-          sed -i -e "s/some_ver/${{ env.VERSION }}/" PKGBUILD
-      - name: Build ZST package
-        run: |
-          makepkg -f
-      - uses: actions/upload-artifact@v3.1.2
-        name: Upload artifact
-        with:
-          name: ${{ env.BINARY_NAME }}_${{ env.VERSION }}_${{ env.BUILD_TARGET }}.zst
-          path: ${{ github.workspace }}/*zst
 
-
+  upload:
-  release:
+    name: Upload Release Assets
-    name: Release binary
+    needs: release
-    needs:
+    runs-on: ${{ matrix.os }}
-      - build
+    strategy:
-      - build_arch
+      matrix:
-    runs-on: ubuntu-latest
+        os: [ubuntu-latest, windows-latest, macos-latest]
-    permissions:
+        include:
-      contents: write
+          - os: ubuntu-latest
+            platform_name: linux-amd64
+          - os: windows-latest
+            platform_name: windows-amd64
+          - os: macos-latest
+            platform_name: macos-arm64
     steps:
-    - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
-    - name: Get version
+      
-      run: echo "VERSION=$(grep -P '^version = \"\d+\.\d+\.\d+\"' Cargo.toml | awk -F '\"' '{print $2}')" >> $GITHUB_ENV
+      - uses: actions/download-artifact@v4
-    - uses: actions/download-artifact@master
+        name: Download ${{ matrix.platform_name }} artifact
-      name: Download binary
+        with:
-      id: download_binary
+          name: ${{ env.BINARY_NAME }}_${{ matrix.platform_name }}
-      with:
+          path: ${{ env.BINARY_NAME }}_${{ matrix.platform_name }}
-        name: ${{ env.BINARY_NAME }}_${{ env.VERSION }}_${{ env.BUILD_TARGET }}
+          
-        path: ${{ env.BINARY_NAME }}_${{ env.VERSION }}_${{ env.BUILD_TARGET }}
+      - name: Upload Release Asset
-    - uses: actions/download-artifact@master
+        uses: actions/upload-release-asset@v1
-      id: download_pkg
+        env:
-      name: Download ZST package
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      with:
+        with:
-        name: ${{ env.BINARY_NAME }}_${{ env.VERSION }}_${{ env.BUILD_TARGET }}.zst
+          upload_url: ${{ needs.release.outputs.upload_url }}
-        path: ${{ env.BINARY_NAME }}_${{ env.VERSION }}_${{ env.BUILD_TARGET }}.zst
+          asset_path: ${{ env.BINARY_NAME }}_${{ matrix.platform_name }}/${{ env.BINARY_NAME }}${{ matrix.platform_name == 'windows-amd64' && '.exe' || '' }}
-    - uses: ncipollo/release-action@v1
+          asset_name: ${{ env.BINARY_NAME }}_${{ matrix.platform_name }}${{ matrix.platform_name == 'windows-amd64' && '.exe' || '' }}
-      name: Update release page
+          asset_content_type: application/octet-stream
-      with:
-        artifacts: "${{ steps.download_binary.outputs.download-path }}/*,${{ steps.download_pkg.outputs.download-path }}/*"
-        allowUpdates: true
-        body: Static musl build for x86_64-linux and Arch Linux package

CHANGELOG.md

@@ -6,6 +6,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 
+
+## [1.1.0] - 2023-09-13
+
+### Improved
+
+- Logging. Fix bugs 
+
+
 ## [1.0.7] - 2023-08-31
 
 ### Changed

Cargo.lock

@@ -1,6 +1,6 @@
 # This file is automatically @generated by Cargo.
 # It is not intended for manual editing.
-version = 3
+version = 4
 
 [[package]]
 name = "aho-corasick"
@@ -244,6 +244,31 @@ dependencies = [
  "libc",
 ]
 
+[[package]]
+name = "crossbeam-deque"
+version = "0.8.6"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "9dd111b7b7f7d55b72c0a6ae361660ee5853c9af73f70c3c2ef6858b950e2e51"
+dependencies = [
+ "crossbeam-epoch",
+ "crossbeam-utils",
+]
+
+[[package]]
+name = "crossbeam-epoch"
+version = "0.9.18"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "5b82ac4a3c2ca9c3460964f020e1402edd5753411d7737aa39c3714ad1b5420e"
+dependencies = [
+ "crossbeam-utils",
+]
+
+[[package]]
+name = "crossbeam-utils"
+version = "0.8.21"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "d0a5c400df2834b80a4c3327b3aad3a4c4cd4de0629063962b03235697506a28"
+
 [[package]]
 name = "crypto-common"
 version = "0.1.6"
@@ -1029,6 +1054,26 @@ dependencies = [
  "getrandom",
 ]
 
+[[package]]
+name = "rayon"
+version = "1.10.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "b418a60154510ca1a002a752ca9714984e21e4241e804d32555251faf8b78ffa"
+dependencies = [
+ "either",
+ "rayon-core",
+]
+
+[[package]]
+name = "rayon-core"
+version = "1.12.1"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "1465873a3dfdaa8ae7cb14b4383657caab0b3e8a0aa9ae8e04b044854c8dfce2"
+dependencies = [
+ "crossbeam-deque",
+ "crossbeam-utils",
+]
+
 [[package]]
 name = "redox_syscall"
 version = "0.2.16"
@@ -1066,7 +1111,7 @@ checksum = "436b050e76ed2903236f032a59761c1eb99e1b0aead2c257922771dab1fc8c78"
 
 [[package]]
 name = "rexec"
-version = "1.0.6"
+version = "1.1.0"
 dependencies = [
  "brace-expand",
  "clap 4.3.4",
@@ -1079,6 +1124,7 @@ dependencies = [
  "massh",
  "openssl",
  "question",
+ "rayon",
  "regex",
  "whoami",
 ]

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "rexec"
-version = "1.0.7"
+version = "1.2.0"
 readme = "https://github.com/house-of-vanity/rexec#readme"
 edition = "2021"
 description = "Parallel SSH executor"
@@ -14,6 +14,7 @@ authors = ["AB <gh@hexor.ru>"]
 
 [dependencies]
 dns-lookup = "2.0.2"
+rayon = "1.10"
 log = "0.4.0"
 env_logger = "0.10.0"
 massh = "0.6.3"
@@ -22,7 +23,6 @@ lazy-st = "0.2.2"
 regex = "1"
 clap = { version = "4.3.4", features = ["derive"] }
 colored = "2.0.0"
-#dialoguer = "0.10.4"
 itertools = "0.10.5"
 brace-expand = "0.1.0"
 question = "0.2.2"

README.md

@@ -1,14 +1,20 @@
 # rexec
-Parallel SSH executor in Rust. It can read servers from `~/.ssh/known_hosts`
+**Parallel SSH executor** in Rust with static binary. It can read servers from `~/.ssh/known_hosts`
-
-or even expand servers from bash expanshion line `cassandra.{prod,dev}.example.com`
 
+or even expand servers from bash expanshion line `cassandra-[1:5].{prod,dev}.example.com`
 
 [![Rust-static-build](https://github.com/house-of-vanity/rexec/actions/workflows/release.yml/badge.svg)](https://github.com/house-of-vanity/rexec/actions/workflows/release.yml)
+---
 
-
+## Usage
 ```shell                                                    
-[ab@test]$ ./rexec -k admin-gce-sc.* --help
+            _|_|_|_|   _|      _|   _|_|_|_|     _|_|_|  
+ _|  _|_|   _|           _|  _|     _|         _|        
+ _|_|       _|_|_|         _|       _|_|_|     _|        
+ _|         _|           _|  _|     _|         _|        
+ _|         _|_|_|_|   _|      _|   _|_|_|_|     _|_|_|  
+                                                        
+
 Parallel SSH executor in Rust
 
 Usage: rexec [OPTIONS] --expression <EXPRESSION> --command <COMMAND>
@@ -24,39 +30,33 @@ Options:
   -h, --help                     Print help
   -V, --version                  Print version
 ```
+---
 
+![image](https://github.com/house-of-vanity/rexec/assets/4666566/4c52915d-2bc1-46b9-9833-b0d7c0527f2d)
+
+
+## Examples
 ```shell
-[ab@test debug]$ ./rexec -u ab -k -c uptime -e admin.* -f
+$ rexec -f \
+    -e 'cassandra-gce-or-[1:2]' \
+    -u ab \
+    -c 'uname -r; date'
+[INFO ] Using string expansion to build server list.
 [INFO ] Matched hosts:
-[INFO ] admin-gce-sc-1.lca-prod.** [35.211.27.195]
+[INFO ] cassandra-gce-or-1.prod.example.com [2.22.123.79]
-[INFO ] admin-gce-sc-1.mmk-prod.** [35.211.79.202]
+[INFO ] cassandra-gce-or-2.prod.example.com [2.22.123.158]
-[ERROR] admin-gce-sc-1.led-prod.** couldn't be resolved.
+Continue on following 2 servers? y
-[INFO ] admin-gce-sc-1.msq-dev.** [35.211.0.24]
+[INFO ] Run command on 2 servers.
-[ERROR] admin-gce-sc-1.hui-dev.** couldn't be resolved.
 
-[INFO ] Run command on 3 servers.
+cassandra-gce-or-1.prod.example.com
+Exit code [0] / stdout 45 bytes / stderr 0 bytes
+STDOUT
+║ 5.15.0-1040-gcp
+║ Thu Sep  7 13:44:40 UTC 2023
 
-
+cassandra-gce-or-2.prod.example.com
-[INFO ] admin.gnb-prod.**
+Exit code [0] / stdout 45 bytes / stderr 0 bytes
-Code 0 
+STDOUT
-STDOUT:                                                    
+║ 5.15.0-1040-gcp
- 23:31:21 up 294 days, 14:14,  0 users,  load average: 0.53, 0.64, 0.52
+║ Thu Sep  7 13:44:40 UTC 2023
-
-STDERR:
-                                                                                                                       
-[INFO ] admin.abe-prod.**
-Code 0 
-STDOUT:                                                    
- 23:31:22 up 154 days,  9:24,  0 users,  load average: 0.31, 0.25, 0.18
-                                                           
-STDERR:
-
-[INFO ] admin-gce-be-1.toy-prod.**
-Code 0                                                     
-STDOUT:
- 23:31:22 up 98 days,  6:20,  0 users,  load average: 0.88, 0.74, 0.80
-                             
-STDERR:
-no server running on /tmp/tmux-1019/default                                                                            
-open terminal failed: not a terminal
 ```

src/main.rs

@@ -6,16 +6,17 @@ use std::fs::read_to_string;
 use std::hash::Hash;
 use std::net::IpAddr;
 use std::process;
+use std::sync::{Arc, Mutex};
 
 use clap::Parser;
 use colored::*;
-//use dialoguer::Confirm;
 use dns_lookup::lookup_host;
 use env_logger::Env;
 use itertools::Itertools;
 use log::{error, info};
 use massh::{MasshClient, MasshConfig, MasshHostConfig, SshAuth};
 use question::{Answer, Question};
+use rayon::prelude::*;
 use regex::Regex;
 
 // Define args
@@ -35,9 +36,10 @@ struct Args {
     #[arg(
         short,
         long,
+        num_args = 1..,
         help = "Expression to build server list. List and range expansion are supported. Example: 'web-[1:12]-io-{prod,dev}'"
     )]
-    expression: String,
+    expression: Vec<String>,
 
     #[arg(short, long, help = "Command to execute on servers")]
     command: String,
@@ -157,30 +159,36 @@ fn main() {
     let hosts = if args.known_hosts {
         info!("Using ~/.ssh/known_hosts to build server list.");
         let known_hosts = read_known_hosts();
-        // Build regex
+        let mut all_hosts = Vec::new();
-        let re = match Regex::new(&args.expression) {
+        for expression in args.expression.iter() {
-            Ok(result) => result,
+            let re = match Regex::new(expression) {
-            Err(e) => {
+                Ok(result) => result,
-                error!("Error parsing regex. {}", e);
+                Err(e) => {
-                process::exit(1);
+                    error!("Error parsing regex. {}", e);
-            }
+                    process::exit(1);
-        };
+                }
-        // match hostnames from known_hosts to regex
+            };
-        known_hosts
+            let matched: Vec<Host> = known_hosts
-            .into_iter()
+                .clone()
-            .filter(|r| re.is_match(&r.name.clone()))
+                .into_iter()
-            .collect()
+                .filter(|r| re.is_match(&r.name.clone()))
+                .collect();
+            all_hosts.extend(matched);
+        }
+        all_hosts
     } else {
         info!("Using string expansion to build server list.");
-        expand_string(&args.expression)
+        let mut all_hosts = Vec::new();
+        for expression in args.expression.iter() {
+            all_hosts.extend(expand_string(expression));
+        }
+        all_hosts
     };
 
     // Dedup hosts from known_hosts file
     let matched_hosts: Vec<_> = hosts.into_iter().unique().collect();
 
     // Build MasshHostConfig hostnames list
-    let mut massh_hosts: Vec<MasshHostConfig> = vec![];
-    let mut hosts_and_ips: HashMap<IpAddr, String> = HashMap::new();
     if args.parallel != 100 {
         warn!("Parallelism: {} thread{}", &args.parallel, {
             if args.parallel != 1 {
@@ -192,23 +200,42 @@ fn main() {
     }
 
     info!("Matched hosts:");
-    for host in matched_hosts.iter() {
+    let resolved_ips = Arc::new(Mutex::new(Vec::<(String, IpAddr)>::new()));
-        let ip = match lookup_host(&host.name) {
+
-            Ok(ip) => ip[0],
+    matched_hosts
-            Err(_) => {
+        .par_iter()
-                error!("{} couldn't be resolved.", &host.name.red());
+        .for_each(|host| match lookup_host(&host.name) {
-                continue;
+            Ok(ips) if !ips.is_empty() => {
+                let ip = ips[0];
+
+                info!("{} [{}]", &host.name, ip);
+
+                let mut results = resolved_ips.lock().unwrap();
+                results.push((host.name.clone(), ip));
             }
-        };
+            Ok(_) => {
-        info!("{} [{}]", &host.name, ip);
+                error!("DNS resolved, but IP not found: {}", &host.name.red());
-        hosts_and_ips.insert(ip, host.name.clone());
+            }
-        massh_hosts.push(MasshHostConfig {
+            Err(_) => {
-            addr: ip,
+                error!("DNS resolve failed: {}", &host.name.red());
-            auth: None,
+            }
-            port: None,
+        });
-            user: None,
+
-        })
+    let mut hosts_and_ips: HashMap<IpAddr, String> = HashMap::new();
+    let mut massh_hosts: Vec<MasshHostConfig> = Vec::new();
+
+    if let Ok(results) = resolved_ips.lock() {
+        for (hostname, ip) in results.iter() {
+            hosts_and_ips.insert(*ip, hostname.clone());
+            massh_hosts.push(MasshHostConfig {
+                addr: *ip,
+                auth: None,
+                port: None,
+                user: None,
+            });
+        }
     }
+
     // Build MasshConfig using massh_hosts vector
     let config = MasshConfig {
         default_auth: SshAuth::Agent,
@@ -234,9 +261,7 @@ fn main() {
                 _ => unreachable!(),
             })
     {
-        info!("\n");
         info!("Run command on {} servers.", &config.hosts.len());
-        info!("\n");
 
         // Run a command on all the configured hosts.
         // Receive the result of the command for each host and print its output.
@@ -248,8 +273,8 @@ fn main() {
                 .collect::<Vec<_>>()[0]
                 .to_string();
             let ip = ip.parse::<IpAddr>().unwrap();
-            info!(
+            println!(
-                "{}",
+                "\n{}",
                 hosts_and_ips
                     .get(&ip)
                     .unwrap_or(&"Couldn't parse IP".to_string())
@@ -265,14 +290,50 @@ fn main() {
                     continue;
                 }
             };
-            if output.exit_status == 0 {
+            let code_string = if output.exit_status == 0 {
-                println!("Code {}", output.exit_status);
+                format!("{}", output.exit_status.to_string().green())
             } else {
-                error!("Code {}", output.exit_status);
+                format!("{}", output.exit_status.to_string().red())
             };
+            println!(
+                "{}",
+                format!(
+                    "Exit code [{}] | std out/err [{}/{}] bytes",
+                    code_string,
+                    output.stdout.len(),
+                    output.stderr.len()
+                )
+                .bold()
+            );
+
             if !args.code {
-                println!("STDOUT:\n{}", String::from_utf8(output.stdout).unwrap());
+                match String::from_utf8(output.stdout) {
-                println!("STDERR:\n{}", String::from_utf8(output.stderr).unwrap());
+                    Ok(stdout) => match stdout.as_str() {
+                        "" => {}
+                        _ => {
+                            let prefix = if output.exit_status != 0 {
+                                format!("{}", "│".cyan())
+                            } else {
+                                format!("{}", "│".green())
+                            };
+                            for line in stdout.lines() {
+                                println!("{} {}", prefix, line);
+                            }
+                        }
+                    },
+                    Err(_) => {}
+                }
+                match String::from_utf8(output.stderr) {
+                    Ok(stderr) => match stderr.as_str() {
+                        "" => {}
+                        _ => {
+                            for line in stderr.lines() {
+                                println!("{} {}", "║".red(), line);
+                            }
+                        }
+                    },
+                    Err(_) => {}
+                }
             }
         }
     } else {