Added streaming. Improved UI

This commit is contained in:
Ultradesu
2026-07-25 01:23:29 +03:00
parent a516887830
commit 38e3eb5a12
19 changed files with 2123 additions and 459 deletions
+4 -3
View File
@@ -50,10 +50,10 @@ pub enum AppEvent {
id: i64,
result: Result<PlaylistDetail, String>,
},
/// Liked track ids for the ♥ markers.
LikesLoaded(Result<Vec<i64>, String>),
/// Liked local content ids for the ♥ markers.
LikesLoaded(Result<Vec<String>, String>),
LikeToggled {
track_id: i64,
content_id: String,
liked: bool,
},
/// Liked federated item ids and content ids for the ♥ markers.
@@ -118,6 +118,7 @@ pub enum AppEvent {
/// queue swaps the placeholder for the resolved track.
FedTrackResolved {
placeholder_id: i64,
resolve_key: String,
result: Result<Box<crate::federation::FedPlayable>, String>,
},
/// Rich metadata for a federated track-info preview arrived without
+400 -67
View File
@@ -44,8 +44,10 @@ pub struct Runtime {
/// Coalesces urgent personal-device syncs after remote playback commands.
pub device_sync_running: Arc<std::sync::atomic::AtomicBool>,
pub device_sync_requested: Arc<std::sync::atomic::AtomicBool>,
/// Placeholder ids of federated tracks being downloaded right now.
pub fed_resolving: std::sync::Mutex<std::collections::HashSet<i64>>,
/// Stable playback keys of federated tracks being resolved right now.
pub fed_resolving: std::sync::Mutex<std::collections::HashSet<String>>,
/// Stable playback keys that already started through a streaming reader.
pub fed_streaming: Arc<std::sync::Mutex<std::collections::HashSet<String>>>,
/// Caps concurrent artwork loads so they never starve the disk.
pub art_semaphore: Arc<tokio::sync::Semaphore>,
/// The terminal screen was externally disturbed and needs a full repaint.
@@ -58,6 +60,13 @@ pub struct Runtime {
pub last_media_push: Option<std::time::Instant>,
}
#[derive(Debug, Clone, Copy)]
struct StreamingPlaybackRequest {
volume: u8,
paused: bool,
position_secs: f64,
}
fn now_epoch_seconds() -> i64 {
std::time::SystemTime::now()
.duration_since(std::time::UNIX_EPOCH)
@@ -176,6 +185,7 @@ pub async fn run(
device_sync_running: Arc::new(std::sync::atomic::AtomicBool::new(false)),
device_sync_requested: Arc::new(std::sync::atomic::AtomicBool::new(false)),
fed_resolving: std::sync::Mutex::new(std::collections::HashSet::new()),
fed_streaming: Arc::new(std::sync::Mutex::new(std::collections::HashSet::new())),
art_semaphore: Arc::new(tokio::sync::Semaphore::new(4)),
force_redraw: false,
search_seq: Arc::new(std::sync::atomic::AtomicU64::new(0)),
@@ -221,6 +231,7 @@ pub async fn run(
},
Some(app_event) = event_rx.recv() => handle_app_event(&mut state, &mut runtime, app_event),
_ = tick.tick() => {
state.advance_spinner();
expire_quit_confirmation(&mut state);
sync_player_shared(&mut state, &runtime);
maybe_prefetch_next(&mut state, &runtime);
@@ -313,24 +324,7 @@ fn playback_track_to_ui(
}
fn track_playback_key(track: &crate::library::models::TrackItem) -> String {
if let Some(content_id) = track
.content_id
.as_deref()
.and_then(music_dht::normalize_content_id)
.or_else(|| {
track
.fed
.as_ref()
.and_then(|fed| fed.content_id.as_deref())
.and_then(music_dht::normalize_content_id)
})
{
return format!("content:{content_id}");
}
if let Some(fed) = &track.fed {
return format!("fed:{}:{}", fed.owner, fed.item_id);
}
format!("local:{}", track.id)
state::track_key(track)
}
fn apply_playback_state_to_ui(
@@ -545,6 +539,53 @@ pub(crate) fn transfer_active_to_this_device(state: &mut AppState, runtime: &mut
request_urgent_device_sync(runtime);
}
pub(crate) fn transfer_active_to_remote_device(
state: &mut AppState,
runtime: &mut Runtime,
target_device_id: String,
target_device_name: String,
) {
if target_device_id.trim().is_empty()
|| target_device_id == state.device_playback.self_device_id
{
transfer_active_to_this_device(state, runtime);
return;
}
extrapolate_control_position(state);
let previous_active_id = state.device_playback.active_device_id.clone();
if state.player.current.is_none() && !state.player.queue.is_empty() {
state.player.current = state.player.queue.get(state.player.queue_pos).cloned();
}
let wire = playback_state_from_ui(state);
let command = crate::devices::PlaybackCommand::ActiveChanged {
active_device_id: target_device_id.clone(),
active_device_name: target_device_name.clone(),
state: wire.clone(),
};
record_playback_command_async(
runtime,
target_device_id.clone(),
command.clone(),
"device handoff",
);
if let Some(previous) = previous_active_id
&& previous != target_device_id
&& previous != state.device_playback.self_device_id
{
record_playback_command_async(runtime, previous, command.clone(), "device handoff");
}
let snapshot = crate::devices::PlaybackSnapshot {
device_id: target_device_id.clone(),
device_name: target_device_name.clone(),
active: true,
updated_at_ms: unix_time_ms(),
state: wire,
};
become_control_device(state, runtime, snapshot);
request_urgent_device_sync(runtime);
state.status_message = Some(format!("active playback moved to {target_device_name}"));
}
fn record_active_handoff(
state: &mut AppState,
runtime: &Runtime,
@@ -733,7 +774,7 @@ fn maintenance(state: &mut AppState, runtime: &mut Runtime) {
let library = Arc::clone(&runtime.library);
let tx = runtime.event_tx.clone();
tokio::task::spawn_blocking(move || {
let result = library.likes().map_err(err_string);
let result = library.liked_content_ids().map_err(err_string);
let _ = tx.send(AppEvent::LikesLoaded(result));
let result = library.fed_like_ids().map_err(err_string);
let _ = tx.send(AppEvent::FedLikesLoaded(result));
@@ -952,12 +993,28 @@ fn perform_effect(state: &mut AppState, runtime: &mut Runtime, effect: Effect) {
let tx = runtime.event_tx.clone();
tokio::task::spawn_blocking(move || {
for track_id in track_ids {
match library.toggle_like(track_id) {
let content_id = match library.track_content_id_by_id(track_id) {
Ok(Some(content_id)) => content_id,
Ok(None) => {
tracing::warn!(track_id, "cannot toggle like without content id");
let _ = tx.send(AppEvent::StatusMessage(
"like failed: track has no content id".to_string(),
));
continue;
}
Err(err) => {
tracing::warn!(%err, track_id, "loading track content id failed");
let _ =
tx.send(AppEvent::StatusMessage(format!("like failed: {err:#}")));
break;
}
};
match library.toggle_like_by_content_id(&content_id) {
Ok(liked) => {
if let Err(err) = devices.record_track_like(track_id, liked) {
if let Err(err) = devices.record_content_like(&content_id, liked) {
tracing::warn!(%err, track_id, "recording synced like failed");
}
let _ = tx.send(AppEvent::LikeToggled { track_id, liked });
let _ = tx.send(AppEvent::LikeToggled { content_id, liked });
}
Err(err) => {
tracing::warn!(%err, track_id, "like toggle failed");
@@ -987,6 +1044,12 @@ fn perform_effect(state: &mut AppState, runtime: &mut Runtime, effect: Effect) {
}
}
}
let _ = tx.send(AppEvent::LikesLoaded(
library.liked_content_ids().map_err(err_string),
));
let _ = tx.send(AppEvent::FedLikesLoaded(
library.fed_like_ids().map_err(err_string),
));
});
}
Effect::RemoveFromPlaylist {
@@ -1348,13 +1411,13 @@ fn start_current_audio(
if let Some(local) = local_track_for_playback(runtime, &track) {
state.player.queue[state.player.queue_pos] = local.clone();
track = local;
} else if let Some(fed) = track.fed.clone() {
} else if let Some(fed) = direct_fed_source(&track) {
let mut pending = crate::federation::pending_track(&fed);
pending.id = track.id;
pending.play_count = track.play_count;
state.player.queue[state.player.queue_pos] = pending.clone();
track = pending;
} else if track.content_id.is_some() {
} else if track_content_id(&track).is_some() {
state.player.current = Some(track.clone());
state.player.playing = true;
state.player.paused = paused;
@@ -1368,15 +1431,30 @@ fn start_current_audio(
"federation: locating \"{}\" for this device…",
track.title
));
spawn_content_id_resolve(runtime, &track);
spawn_content_id_resolve(
runtime,
&track,
Some(StreamingPlaybackRequest {
volume: state.player.volume,
paused,
position_secs,
}),
);
return;
} else if let Some(fed) = track.fed.clone() {
let mut pending = crate::federation::pending_track(&fed);
pending.id = track.id;
pending.play_count = track.play_count;
state.player.queue[state.player.queue_pos] = pending.clone();
track = pending;
}
}
// The track that was playing until now was cut short by this switch.
let previous_started_at = state.player.track_started_at;
let next_key = track_playback_key(&track);
let same_track_started_at = if let Some(previous) = state.player.current.take() {
let same_track = previous.id == track.id;
if state.player.playing && previous.id != track.id {
let same_track = track_playback_key(&previous) == next_key;
if state.player.playing && !same_track {
report_history(
runtime,
previous.id,
@@ -1404,7 +1482,15 @@ fn start_current_audio(
// audio, download it and resume through FedTrackResolved.
runtime.player.stop();
state.status_message = Some(format!("federation: fetching \"{}\"", track.title));
spawn_fed_resolve(runtime, &track);
spawn_fed_resolve(
runtime,
&track,
Some(StreamingPlaybackRequest {
volume: state.player.volume,
paused,
position_secs,
}),
);
return;
}
if track_file_missing(&track) {
@@ -1454,19 +1540,32 @@ fn local_track_for_playback(
runtime: &Runtime,
track: &crate::library::models::TrackItem,
) -> Option<crate::library::models::TrackItem> {
let content_id = track.content_id.as_deref()?;
let content_id = track_content_id(track)?;
let local = runtime
.library
.track_by_content_id(content_id)
.track_by_content_id(&content_id)
.ok()
.flatten()?;
Path::new(&local.file_path).is_file().then_some(local)
}
fn direct_fed_source(
track: &crate::library::models::TrackItem,
) -> Option<crate::federation::FedTrack> {
let fed = track.fed.clone()?;
let owner_ok = fed.owner.parse::<music_dht::EndpointId>().is_ok();
let item_ok = fed.item_id.len() == 64 && fed.item_id.chars().all(|c| c.is_ascii_hexdigit());
(owner_ok && item_ok).then_some(fed)
}
fn track_content_id(track: &crate::library::models::TrackItem) -> Option<String> {
state::track_content_id(track)
}
fn open_track_file(path: &str) -> std::io::Result<(player::TrackReader, Option<u64>)> {
let file = std::fs::File::open(path)?;
let byte_len = file.metadata().ok().map(|meta| meta.len());
Ok((std::io::BufReader::new(file), byte_len))
Ok((Box::new(std::io::BufReader::new(file)), byte_len))
}
/// Open the next queue item ~30s before the current track ends and append
@@ -1488,14 +1587,28 @@ fn maybe_prefetch_next(state: &mut AppState, runtime: &Runtime) {
let Some(next_pos) = update::peek_next_pos(player) else {
return;
};
let Some(next) = player.queue.get(next_pos).cloned() else {
let Some(mut next) = player.queue.get(next_pos).cloned() else {
return;
};
if next.is_fed_pending() {
// Download the upcoming federated track ahead of time; the gapless
// enqueue happens on a later tick once it resolved to a file.
spawn_fed_resolve(runtime, &next);
return;
if track_file_missing(&next) {
if let Some(local) = local_track_for_playback(runtime, &next) {
state.player.queue[next_pos] = local.clone();
next = local;
} else if let Some(fed) = direct_fed_source(&next) {
next = crate::federation::pending_track(&fed);
spawn_fed_resolve(runtime, &next, None);
return;
} else if track_content_id(&next).is_some() {
// Resolve by content id first: the actual owner/item id may be a
// synced placeholder from another client.
spawn_content_id_resolve(runtime, &next, None);
return;
} else if next.is_fed_pending() {
spawn_fed_resolve(runtime, &next, None);
return;
} else {
return;
}
}
state.player.prefetched_pos = Some(next_pos);
tracing::debug!(title = %next.title, "prefetching next track");
@@ -1577,64 +1690,235 @@ pub(crate) fn device_connect(runtime: &Runtime, invite: String) {
});
}
fn download_progress_sender(
tx: mpsc::UnboundedSender<AppEvent>,
title: String,
) -> impl FnMut(crate::federation::DownloadProgress) + Send + 'static {
let mut last_sent: Option<std::time::Instant> = None;
let started = std::time::Instant::now();
move |progress| {
let now = std::time::Instant::now();
let complete = progress.total > 0 && progress.received >= progress.total;
let first = progress.received == 0;
let due = last_sent.is_none_or(|last| now.duration_since(last) >= TICK_INTERVAL);
if first || complete || due {
last_sent = Some(now);
let elapsed_secs = now.duration_since(started).as_secs_f64();
let bytes_per_sec = if elapsed_secs >= 0.25 && progress.received > 0 {
Some(progress.received as f64 / elapsed_secs)
} else {
None
};
let _ = tx.send(AppEvent::StatusMessage(format_download_progress(
&title,
progress,
bytes_per_sec,
)));
}
}
}
fn format_download_progress(
title: &str,
progress: crate::federation::DownloadProgress,
bytes_per_sec: Option<f64>,
) -> String {
let speed = bytes_per_sec
.map(|bytes| format!(" · {}", format_transfer_rate(bytes)))
.unwrap_or_default();
if progress.total > 0 {
let percent = (progress.received as f64 / progress.total as f64 * 100.0).clamp(0.0, 100.0);
format!(
"federation: downloading \"{title}\" {:.0}% · {}/{}{speed}",
percent,
format_bytes(progress.received),
format_bytes(progress.total)
)
} else {
format!(
"federation: downloading \"{title}\" · {}{speed}",
format_bytes(progress.received),
)
}
}
fn format_bytes(bytes: u64) -> String {
const KIB: f64 = 1024.0;
const MIB: f64 = KIB * 1024.0;
if bytes >= 1024 * 1024 {
format!("{:.1} MB", bytes as f64 / MIB)
} else if bytes >= 1024 {
format!("{:.0} KB", bytes as f64 / KIB)
} else {
format!("{bytes} B")
}
}
fn format_transfer_rate(bytes_per_sec: f64) -> String {
const KIB: f64 = 1024.0;
const MIB: f64 = KIB * 1024.0;
if bytes_per_sec >= MIB {
format!("{:.1} MB/s", bytes_per_sec / MIB)
} else if bytes_per_sec >= KIB {
format!("{:.0} KB/s", bytes_per_sec / KIB)
} else {
format!("{:.0} B/s", bytes_per_sec)
}
}
/// Downloads one pending federated track (into the cache, or the library
/// when save-on-listen is enabled) and reports back with the placeholder id
/// so the queue can swap the resolved track in.
fn spawn_fed_resolve(runtime: &Runtime, track: &crate::library::models::TrackItem) {
fn spawn_fed_resolve(
runtime: &Runtime,
track: &crate::library::models::TrackItem,
stream_playback: Option<StreamingPlaybackRequest>,
) {
let Some(fed_track) = track.fed.clone() else {
return;
};
let resolve_key = track_playback_key(track);
{
let mut resolving = runtime
.fed_resolving
.lock()
.unwrap_or_else(std::sync::PoisonError::into_inner);
if !resolving.insert(track.id) {
if !resolving.insert(resolve_key.clone()) {
return;
}
}
let placeholder_id = track.id;
let title = track.title.clone();
let fed = Arc::clone(&runtime.federation);
let tx = runtime.event_tx.clone();
let controller = runtime.player.clone();
let streaming = Arc::clone(&runtime.fed_streaming);
tokio::spawn(async move {
let result = fed
.prepare_playback(&fed_track)
let progress = download_progress_sender(tx.clone(), title.clone());
let result = if let Some(playback) =
stream_playback.filter(|playback| playback.position_secs <= 0.5)
{
let stream_tx = tx.clone();
let stream_title = title.clone();
let stream_controller = controller.clone();
let stream_resolve_key = resolve_key.clone();
let stream_markers = Arc::clone(&streaming);
let mut started = false;
fed.prepare_playback_streaming_with_progress(&fed_track, progress, move |stream| {
if started {
return;
}
started = true;
stream_markers
.lock()
.unwrap_or_else(std::sync::PoisonError::into_inner)
.insert(stream_resolve_key.clone());
stream_controller.play_stream(
Box::new(stream.reader),
Some(stream.mime_type),
player::amplitude(playback.volume),
);
if playback.paused {
stream_controller.pause();
}
let _ = stream_tx.send(AppEvent::StatusMessage(format!(
"federation: streaming \"{stream_title}\" while downloading…"
)));
})
.await
.map(Box::new)
.map_err(|err| format!("{err:#}"));
} else {
fed.prepare_playback_with_progress(&fed_track, progress)
.await
}
.map(Box::new)
.map_err(|err| format!("{err:#}"));
let _ = tx.send(AppEvent::FedTrackResolved {
placeholder_id,
resolve_key,
result,
});
});
}
fn spawn_content_id_resolve(runtime: &Runtime, track: &crate::library::models::TrackItem) {
let Some(content_id) = track.content_id.clone() else {
fn spawn_content_id_resolve(
runtime: &Runtime,
track: &crate::library::models::TrackItem,
stream_playback: Option<StreamingPlaybackRequest>,
) {
let Some(content_id) = track_content_id(track) else {
return;
};
let resolve_key = track_playback_key(track);
{
let mut resolving = runtime
.fed_resolving
.lock()
.unwrap_or_else(std::sync::PoisonError::into_inner);
if !resolving.insert(track.id) {
if !resolving.insert(resolve_key.clone()) {
return;
}
}
let placeholder_id = track.id;
let label = format!("{} {}", track.artist_line(), track.title);
let title = track.title.clone();
let fed = Arc::clone(&runtime.federation);
let tx = runtime.event_tx.clone();
let controller = runtime.player.clone();
let streaming = Arc::clone(&runtime.fed_streaming);
tokio::spawn(async move {
let result = match fed.track_by_content_id(&content_id, Some(&label)).await {
Ok(fed_track) => fed.prepare_playback(&fed_track).await,
Ok(fed_track) => {
let _ = tx.send(AppEvent::StatusMessage(format!(
"federation: found source for \"{title}\", downloading…"
)));
let progress = download_progress_sender(tx.clone(), title.clone());
if let Some(playback) =
stream_playback.filter(|playback| playback.position_secs <= 0.5)
{
let stream_tx = tx.clone();
let stream_title = title.clone();
let stream_controller = controller.clone();
let stream_resolve_key = resolve_key.clone();
let stream_markers = Arc::clone(&streaming);
let mut started = false;
fed.prepare_playback_streaming_with_progress(
&fed_track,
progress,
move |stream| {
if started {
return;
}
started = true;
stream_markers
.lock()
.unwrap_or_else(std::sync::PoisonError::into_inner)
.insert(stream_resolve_key.clone());
stream_controller.play_stream(
Box::new(stream.reader),
Some(stream.mime_type),
player::amplitude(playback.volume),
);
if playback.paused {
stream_controller.pause();
}
let _ = stream_tx.send(AppEvent::StatusMessage(format!(
"federation: streaming \"{stream_title}\" while downloading…"
)));
},
)
.await
} else {
fed.prepare_playback_with_progress(&fed_track, progress)
.await
}
}
Err(err) => Err(err),
}
.map(Box::new)
.map_err(|err| format!("{err:#}"));
let _ = tx.send(AppEvent::FedTrackResolved {
placeholder_id,
resolve_key,
result,
});
});
@@ -1660,12 +1944,14 @@ pub(crate) fn fed_download_spawn(
let mut imported_fed_tracks = Vec::new();
let mut failed = 0usize;
for (index, track) in tracks.iter().enumerate() {
let title = track.title.clone();
let _ = tx.send(AppEvent::StatusMessage(format!(
"federation: downloading {}/{total}: {}",
index + 1,
track.title
)));
match fed.download_to_library(track).await {
let progress = download_progress_sender(tx.clone(), title);
match fed.download_to_library_with_progress(track, progress).await {
Ok(imported) => {
imported_ids.push(imported.id);
imported_fed_tracks.push(track.clone());
@@ -1967,10 +2253,18 @@ fn apply_queue_refresh(
) {
let by_id: std::collections::HashMap<i64, _> =
tracks.into_iter().map(|track| (track.id, track)).collect();
let by_key: std::collections::HashMap<String, _> = by_id
.values()
.cloned()
.map(|track| (track_playback_key(&track), track))
.collect();
let current_id = state.player.current.as_ref().map(|track| track.id);
let current_key = state.player.current.as_ref().map(track_playback_key);
for track in &mut state.player.queue {
if let Some(fresh) = by_id.get(&track.id) {
*track = fresh.clone();
} else if let Some(fresh) = by_key.get(&track_playback_key(track)) {
*track = fresh.clone();
}
}
let had_missing = state
@@ -1995,15 +2289,29 @@ fn apply_queue_refresh(
return;
}
state.queue_tab.cursor = state.queue_tab.cursor.min(state.player.queue.len() - 1);
match current_id {
Some(id) if by_id.contains_key(&id) => {
if let Some(position) = state.player.queue.iter().position(|track| track.id == id) {
match (current_id, current_key) {
(Some(id), _) if id < 0 => {
// The current source can be an ephemeral federated stream while
// the queue is refreshed after save-on-listen. It is not a
// deleted library row, so keep playback untouched.
state.player.queue_pos = state.player.queue_pos.min(state.player.queue.len() - 1);
}
(Some(id), Some(key)) if by_id.contains_key(&id) || by_key.contains_key(&key) => {
if let Some(position) = state
.player
.queue
.iter()
.position(|track| track_playback_key(track) == key)
{
state.player.queue_pos = position;
}
state.player.current = by_id.get(&id).cloned();
state.player.current = by_id
.get(&id)
.cloned()
.or_else(|| by_key.get(&key).cloned());
push_media_metadata(state, runtime);
}
Some(_) => {
(Some(_), _) => {
// The playing track was deleted from the library.
runtime.player_start_pending = false;
runtime.player.stop();
@@ -2013,7 +2321,7 @@ fn apply_queue_refresh(
state.player.paused = false;
push_media_update(state, runtime, true);
}
None => {
(None, _) => {
state.player.queue_pos = state.player.queue_pos.min(state.player.queue.len() - 1);
}
}
@@ -2251,18 +2559,29 @@ fn handle_app_event(state: &mut AppState, runtime: &mut Runtime, event: AppEvent
}
AppEvent::FedTrackResolved {
placeholder_id,
resolve_key,
result,
} => {
runtime
.fed_resolving
.lock()
.unwrap_or_else(std::sync::PoisonError::into_inner)
.remove(&placeholder_id);
.remove(&resolve_key);
let stream_started = runtime
.fed_streaming
.lock()
.unwrap_or_else(std::sync::PoisonError::into_inner)
.remove(&resolve_key);
if state.device_playback.is_control() {
runtime.player_start_pending = false;
tracing::debug!(
placeholder_id,
resolve_key,
"ignored local federated track resolution while controlling remote playback"
);
if let Err(message) = result {
state.status_message = Some(format!("federation: {message}"));
}
return;
}
let placeholder_key = state
@@ -2277,7 +2596,8 @@ fn handle_app_event(state: &mut AppState, runtime: &mut Runtime, event: AppEvent
.as_ref()
.filter(|track| track.id == placeholder_id)
})
.map(track_playback_key);
.map(track_playback_key)
.or(Some(resolve_key.clone()));
let queue_pos_waiting =
state
.player
@@ -2301,6 +2621,7 @@ fn handle_app_event(state: &mut AppState, runtime: &mut Runtime, event: AppEvent
} else {
0.0
};
let already_streaming = waiting && stream_started && state.player.playing;
match result {
Ok(playable) => {
if playable.imported {
@@ -2327,7 +2648,8 @@ fn handle_app_event(state: &mut AppState, runtime: &mut Runtime, event: AppEvent
}
}
if waiting {
// Playback was parked on this track; start it now.
// Playback was either parked on this track or already
// running from the streaming reader.
let paused = state.player.paused;
if state
.player
@@ -2342,11 +2664,19 @@ fn handle_app_event(state: &mut AppState, runtime: &mut Runtime, event: AppEvent
{
state.player.queue_pos = pos;
}
state.player.current =
state.player.queue.get(state.player.queue_pos).cloned();
start_current_audio(state, runtime, resume_position_secs, paused);
push_media_metadata(state, runtime);
push_media_update(state, runtime, true);
if already_streaming {
// Do not swap the currently playing item under
// the audio pipeline. The streaming reader will
// play through the completed cache file naturally;
// the resolved queue entry is for future starts.
push_media_update(state, runtime, true);
} else {
state.player.current =
state.player.queue.get(state.player.queue_pos).cloned();
start_current_audio(state, runtime, resume_position_secs, paused);
push_media_metadata(state, runtime);
push_media_update(state, runtime, true);
}
}
}
Err(message) => {
@@ -2624,6 +2954,7 @@ fn handle_app_event(state: &mut AppState, runtime: &mut Runtime, event: AppEvent
content_id.and_then(|id| music_dht::normalize_content_id(&id))
{
state.fed_likes.remove(&content_id);
state.likes.remove(&content_id);
}
}
// The virtual Likes playlist is stale now; refetch on next open.
@@ -2635,11 +2966,13 @@ fn handle_app_event(state: &mut AppState, runtime: &mut Runtime, event: AppEvent
"like removed".to_string()
});
}
AppEvent::LikeToggled { track_id, liked } => {
AppEvent::LikeToggled { content_id, liked } => {
if liked {
state.likes.insert(track_id);
state.fed_likes.remove(&content_id);
state.likes.insert(content_id);
} else {
state.likes.remove(&track_id);
state.likes.remove(&content_id);
state.fed_likes.remove(&content_id);
}
// The virtual Likes playlist is stale now; refetch on next open.
state.playlist_views.remove(&state::LIKES_PLAYLIST_ID);
+10 -2
View File
@@ -190,10 +190,18 @@ fn handle_connected_devices(
super::transfer_active_to_this_device(state, runtime);
state.status_message = Some("active playback moved to this device".into());
} else if let Some(row) = other_rows.get(cursor.saturating_sub(1).min(last)) {
if let Some(snapshot) = state.device_playback.remote.get(&row.device_id).cloned() {
if row.active
&& let Some(snapshot) =
state.device_playback.remote.get(&row.device_id).cloned()
{
super::become_control_device(state, runtime, snapshot);
} else {
state.status_message = Some("device has no playback snapshot yet".into());
super::transfer_active_to_remote_device(
state,
runtime,
row.device_id.clone(),
row.name.clone(),
);
}
}
}
+55 -7
View File
@@ -900,9 +900,9 @@ pub struct PlayerBar {
pub prefetched_pos: Option<usize>,
pub volume: u8,
pub shuffle: bool,
/// Track ids in pre-shuffle order; restores the queue when shuffle is
/// turned off.
pub original_order: Option<Vec<i64>>,
/// Stable track keys in pre-shuffle order; restores the queue when
/// shuffle is turned off.
pub original_order: Option<Vec<String>>,
pub repeat: RepeatMode,
}
@@ -980,6 +980,7 @@ pub struct AppState {
pub help_visible: bool,
pub pending_keys: Option<String>,
pub status_message: Option<String>,
pub spinner_frame: usize,
pub settings_cursor: usize,
pub player: PlayerBar,
pub device_playback: DevicePlaybackState,
@@ -989,8 +990,8 @@ pub struct AppState {
pub release_views: HashMap<i64, Loadable<ReleaseDetail>>,
pub playlists: PlaylistsTab,
pub playlist_views: HashMap<i64, Loadable<PlaylistDetail>>,
/// Liked track ids, for the ♥ markers everywhere tracks are shown.
pub likes: std::collections::HashSet<i64>,
/// Liked local-library content ids, for the ♥ markers everywhere tracks are shown.
pub likes: std::collections::HashSet<String>,
/// Liked federated tracks (DHT item ids and content ids) — likes that
/// reference peers' tracks without downloading them.
pub fed_likes: std::collections::HashSet<String>,
@@ -1022,6 +1023,15 @@ pub struct AppState {
}
impl AppState {
pub fn advance_spinner(&mut self) {
self.spinner_frame = self.spinner_frame.wrapping_add(1);
}
pub fn spinner(&self) -> &'static str {
const FRAMES: &[&str] = &["", "", "", "", "", "", "", "", "", ""];
FRAMES[self.spinner_frame % FRAMES.len()]
}
pub fn connected_devices_enabled(&self) -> bool {
self.federation.settings.enabled && !self.federation.settings.network_id.trim().is_empty()
}
@@ -1032,7 +1042,9 @@ impl AppState {
.content_id
.as_deref()
.and_then(music_dht::normalize_content_id)
.is_some_and(|content_id| self.fed_likes.contains(&content_id))
.is_some_and(|content_id| {
self.likes.contains(&content_id) || self.fed_likes.contains(&content_id)
})
}
pub fn fed_card_track_liked(&self, track: &crate::federation::FedCardTrack) -> bool {
@@ -1040,10 +1052,46 @@ impl AppState {
.content_id
.as_deref()
.and_then(music_dht::normalize_content_id)
.is_some_and(|content_id| self.fed_likes.contains(&content_id))
.is_some_and(|content_id| {
self.likes.contains(&content_id) || self.fed_likes.contains(&content_id)
})
|| track
.sources
.iter()
.any(|(_, item_id)| self.fed_likes.contains(item_id))
}
pub fn track_liked(&self, track: &TrackItem) -> bool {
if let Some(content_id) = track_content_id(track) {
return self.likes.contains(&content_id) || self.fed_likes.contains(&content_id);
}
track
.fed
.as_ref()
.is_some_and(|fed| self.fed_track_liked(fed))
}
}
pub fn track_content_id(track: &TrackItem) -> Option<String> {
track
.content_id
.as_deref()
.and_then(music_dht::normalize_content_id)
.or_else(|| {
track
.fed
.as_ref()
.and_then(|fed| fed.content_id.as_deref())
.and_then(music_dht::normalize_content_id)
})
}
pub fn track_key(track: &TrackItem) -> String {
if let Some(content_id) = track_content_id(track) {
return format!("content:{content_id}");
}
if let Some(fed) = &track.fed {
return format!("fed:{}:{}", fed.owner, fed.item_id);
}
format!("local:{}", track.id)
}
+138 -41
View File
@@ -6,7 +6,7 @@ use crate::library::models::TrackItem;
use super::state::{
AppState, GlobalView, Loadable, OpenedPlaylist, SearchState, TILE_HEIGHT, TILE_WIDTH, Tab,
TrackSelectionScope, ViewMode, fed_release_display_order, fed_release_rows,
release_display_order, release_rows, settings_rows,
release_display_order, release_rows, settings_rows, track_content_id, track_key,
};
pub const QUIT_CONFIRM_WINDOW: Duration = Duration::from_millis(1500);
@@ -283,26 +283,31 @@ pub fn update(state: &mut AppState, action: Action) -> Option<Effect> {
.map(|track| vec![track.clone()])
.unwrap_or_default();
}
// Local library rows are liked by id; federated tracks (pending
// or cached) are liked as references into the federation.
let mut track_ids: Vec<i64> = Vec::new();
let mut local_tracks: Vec<TrackItem> = Vec::new();
let mut fed_tracks: Vec<crate::federation::FedTrack> = Vec::new();
let mut seen = std::collections::HashSet::new();
for track in tracks {
if !seen.insert(track_key(&track)) {
continue;
}
match &track.fed {
Some(fed) => fed_tracks.push(fed.clone()),
None if track.id >= 0 => track_ids.push(track.id),
None if track.id >= 0 && track_content_id(&track).is_some() => {
local_tracks.push(track)
}
None => {}
}
}
if track_ids.is_empty() && fed_tracks.is_empty() {
if local_tracks.is_empty() && fed_tracks.is_empty() {
state.status_message = Some("no track selected".into());
None
} else {
let should_like = track_ids.iter().any(|id| !state.likes.contains(id))
let should_like = local_tracks.iter().any(|track| !state.track_liked(track))
|| fed_tracks.iter().any(|fed| !state.fed_track_liked(fed));
let toggles: Vec<i64> = track_ids
let toggles: Vec<i64> = local_tracks
.into_iter()
.filter(|id| state.likes.contains(id) != should_like)
.filter(|track| state.track_liked(track) != should_like)
.map(|track| track.id)
.collect();
let fed_toggles: Vec<crate::federation::FedTrack> = fed_tracks
.into_iter()
@@ -355,10 +360,9 @@ pub fn update(state: &mut AppState, action: Action) -> Option<Effect> {
None
}
Action::DownloadSelected => {
let tracks = selected_fed_tracks(state);
let tracks = selected_downloadable_fed_tracks(state);
if tracks.is_empty() {
state.status_message =
Some("select federated tracks first (works in the federation results)".into());
state.status_message = Some("select federated tracks first".into());
None
} else {
state.track_selection.clear();
@@ -614,30 +618,38 @@ fn delete_selected(state: &mut AppState) -> Option<Effect> {
return None;
}
let track_ids: Vec<i64> = tracks.iter().map(|track| track.id).collect();
let content_ids: Vec<String> = tracks
.iter()
.filter_map(|track| {
track
.content_id
.as_deref()
.and_then(music_dht::normalize_content_id)
})
.collect();
let content_ids: Vec<String> = tracks.iter().filter_map(track_content_id).collect();
state.track_selection.clear();
if opened.id == super::state::LIKES_PLAYLIST_ID {
let liked: Vec<i64> = track_ids
.into_iter()
.filter(|id| state.likes.contains(id))
.collect();
state.status_message = Some(format!("removing {} like(s)", liked.len()));
let mut seen = std::collections::HashSet::new();
let mut liked = Vec::new();
let mut fed_tracks = Vec::new();
for track in tracks {
if !state.track_liked(&track) || !seen.insert(track_key(&track)) {
continue;
}
if let Some(fed) = track.fed {
fed_tracks.push(fed);
} else if track.id >= 0 && track_content_id(&track).is_some() {
liked.push(track.id);
}
}
let total = liked.len() + fed_tracks.len();
state.status_message = Some(format!("removing {} like(s)", total));
return Some(Effect::ToggleLikes {
track_ids: liked,
fed_tracks: vec![],
fed_tracks,
});
}
let content_ids: Vec<String> = content_ids
.into_iter()
.collect::<std::collections::BTreeSet<_>>()
.into_iter()
.collect();
let track_ids: Vec<i64> = track_ids.into_iter().filter(|id| *id >= 0).collect();
state.status_message = Some(format!(
"removing {} track(s) from playlist",
track_ids.len()
content_ids.len().max(track_ids.len())
));
return Some(Effect::RemoveFromPlaylist {
playlist_id: opened.id,
@@ -1015,14 +1027,14 @@ fn remove_queue_indices(state: &mut AppState, indices: &[usize]) -> QueueRemoval
}
let old_queue_pos = state.player.queue_pos;
let current_id = state.player.current.as_ref().map(|track| track.id);
let current_removed = current_id.is_some_and(|id| {
let current_key = state.player.current.as_ref().map(track_key);
let current_removed = current_key.as_ref().is_some_and(|key| {
unique.iter().any(|index| {
state
.player
.queue
.get(*index)
.is_some_and(|track| track.id == id)
.is_some_and(|track| track_key(track) == *key)
})
});
let removed_before_current = unique
@@ -1060,19 +1072,24 @@ fn remove_queue_indices(state: &mut AppState, indices: &[usize]) -> QueueRemoval
};
}
if let Some(id) = current_id {
if let Some(position) = state.player.queue.iter().position(|track| track.id == id) {
if let Some(key) = current_key.as_ref() {
if let Some(position) = state
.player
.queue
.iter()
.position(|track| track_key(track) == *key)
{
state.player.queue_pos = position;
}
} else {
state.player.queue_pos = state.player.queue_pos.min(state.player.queue.len() - 1);
}
state.player.current = current_id.and_then(|id| {
state.player.current = current_key.and_then(|key| {
state
.player
.queue
.iter()
.find(|track| track.id == id)
.find(|track| track_key(track) == key)
.cloned()
});
state.queue_tab.cursor = state.queue_tab.cursor.min(state.player.queue.len() - 1);
@@ -1416,7 +1433,7 @@ pub fn shuffle_upcoming(player: &mut super::state::PlayerBar) {
return;
}
if player.original_order.is_none() {
player.original_order = Some(player.queue.iter().map(|t| t.id).collect());
player.original_order = Some(player.queue.iter().map(track_key).collect());
}
shuffle_range(player, upcoming_start(player));
}
@@ -1440,7 +1457,7 @@ pub fn restore_queue_order(player: &mut super::state::PlayerBar) {
let key = order
.iter()
.enumerate()
.position(|(slot, id)| !used[slot] && *id == track.id)
.position(|(slot, key)| !used[slot] && *key == track_key(&track))
.inspect(|&slot| used[slot] = true)
.unwrap_or(usize::MAX);
(key, position, track)
@@ -2212,6 +2229,83 @@ pub(crate) fn selected_fed_tracks(state: &AppState) -> Vec<crate::federation::Fe
}
}
fn selected_downloadable_fed_tracks(state: &AppState) -> Vec<crate::federation::FedTrack> {
let mut tracks = Vec::new();
for track in selected_tracks(state) {
if let Some(fed) = fed_track_for_download(&track)
&& !tracks
.iter()
.any(|existing| same_fed_download(existing, &fed))
{
tracks.push(fed);
}
}
for fed in selected_fed_tracks(state) {
if !tracks
.iter()
.any(|existing| same_fed_download(existing, &fed))
{
tracks.push(fed);
}
}
tracks
}
fn fed_track_for_download(track: &TrackItem) -> Option<crate::federation::FedTrack> {
if let Some(fed) = &track.fed {
return Some(fed.clone());
}
let content_id = track
.content_id
.as_deref()
.and_then(music_dht::normalize_content_id)?;
Some(crate::federation::FedTrack {
item_id: String::new(),
owner: String::new(),
own: false,
title: track.title.clone(),
artist_names: track
.artists
.iter()
.map(|artist| artist.name.clone())
.collect(),
featured_artist_names: track
.featured_artists
.iter()
.map(|artist| artist.name.clone())
.collect(),
year: track.release_year,
duration_seconds: (track.duration_seconds > 0.0)
.then(|| track.duration_seconds.round().max(0.0) as i64),
content_id: Some(content_id),
release_title: (!track.release_title.trim().is_empty())
.then(|| track.release_title.clone()),
track_number: track.track_number,
disc_number: track.disc_number,
})
}
fn same_fed_download(
left: &crate::federation::FedTrack,
right: &crate::federation::FedTrack,
) -> bool {
let left_content = left
.content_id
.as_deref()
.and_then(music_dht::normalize_content_id);
let right_content = right
.content_id
.as_deref()
.and_then(music_dht::normalize_content_id);
if left_content.is_some() && left_content == right_content {
return true;
}
!left.owner.is_empty()
&& !left.item_id.is_empty()
&& left.owner == right.owner
&& left.item_id == right.item_id
}
/// What Enter resolved to in the current view.
enum Outcome {
Push(GlobalView),
@@ -2482,7 +2576,7 @@ pub(super) fn on_new_queue(state: &mut AppState) {
let player = &mut state.player;
player.original_order = None;
if player.shuffle && !player.queue.is_empty() {
player.original_order = Some(player.queue.iter().map(|t| t.id).collect());
player.original_order = Some(player.queue.iter().map(track_key).collect());
shuffle_range(player, (player.queue_pos + 1).min(player.queue.len()));
}
}
@@ -2610,7 +2704,7 @@ mod tests {
release_year: None,
cover_path: None,
file_path: format!("/s/{id}"),
content_id: None,
content_id: Some(format!("b3:{id:064x}")),
audio_format: None,
audio_bitrate: None,
audio_sample_rate: None,
@@ -3162,7 +3256,7 @@ mod tests {
..AppState::default()
};
state.player.queue = (1..=3).map(test_track).collect();
state.likes.insert(1);
state.likes.insert(format!("b3:{:064x}", 1));
update(&mut state, Action::ToggleTrackSelection);
update(&mut state, Action::SelectLast);
@@ -3174,7 +3268,10 @@ mod tests {
})
);
state.likes = [1, 2, 3].into_iter().collect();
state.likes = [1, 2, 3]
.into_iter()
.map(|id| format!("b3:{id:064x}"))
.collect();
assert_eq!(
update(&mut state, Action::ToggleLike),
Some(Effect::ToggleLikes {