Compare commits

..

4 Commits

Author SHA1 Message Date
ab 0cb731fb26 CORE: fixed media links
Build and Publish / Build and Publish Docker Image (push) Successful in 2m55s
2026-05-28 12:02:02 +03:00
Ultradesu c43ee02b00 CORE: Improve media paths and player reliability
Build and Publish / Build and Publish Docker Image (push) Successful in 3m3s
2026-05-27 18:52:17 +03:00
Ultradesu fc6090d6a0 CORE: reworked artwork_backfill.rs task
Build and Publish / Build and Publish Docker Image (push) Successful in 2m30s
2026-05-27 18:07:12 +03:00
Ultradesu 476b300a6c CORE: reworked artwork_backfill.rs task 2026-05-27 18:07:02 +03:00
24 changed files with 2153 additions and 649 deletions
Generated
+1 -1
View File
@@ -1418,7 +1418,7 @@ checksum = "e6d5a32815ae3f33302d95fdcb2ce17862f8c65363dcfd29360480ba1001fc9c"
[[package]] [[package]]
name = "furumusic" name = "furumusic"
version = "0.1.21" version = "0.2.1"
dependencies = [ dependencies = [
"anyhow", "anyhow",
"async-trait", "async-trait",
+1 -1
View File
@@ -1,6 +1,6 @@
[package] [package]
name = "furumusic" name = "furumusic"
version = "0.1.21" version = "0.2.1"
edition = "2024" edition = "2024"
description = "Reusable web-app boilerplate: auth, OIDC/SSO, admin panel, user management, i18n, PostgreSQL" description = "Reusable web-app boilerplate: auth, OIDC/SSO, admin panel, user management, i18n, PostgreSQL"
+48 -19
View File
@@ -3,6 +3,7 @@
//! Sources (in priority order): //! Sources (in priority order):
//! 1. Standalone image files in the album folder (cover.jpg, folder.jpg, etc.) //! 1. Standalone image files in the album folder (cover.jpg, folder.jpg, etc.)
//! 2. Embedded cover art in audio file metadata (ID3 APIC, Vorbis METADATA_BLOCK_PICTURE, etc.) //! 2. Embedded cover art in audio file metadata (ID3 APIC, Vorbis METADATA_BLOCK_PICTURE, etc.)
//! 3. Remote metadata providers used by background backfill jobs.
//! //!
//! The first usable image found is saved as a MediaFile with file_type="cover_art" //! The first usable image found is saved as a MediaFile with file_type="cover_art"
//! and linked to the Release via cover_file_id. //! and linked to the Release via cover_file_id.
@@ -26,6 +27,8 @@ pub enum CoverSource {
FolderFile(PathBuf), FolderFile(PathBuf),
/// Embedded in an audio file's metadata. /// Embedded in an audio file's metadata.
Embedded(PathBuf), Embedded(PathBuf),
/// Downloaded from a remote metadata provider.
Remote(String),
} }
/// Well-known cover art filenames, in priority order. /// Well-known cover art filenames, in priority order.
@@ -320,33 +323,51 @@ pub async fn save_cover_to_storage(
let hash = hash_image(&cover.data); let hash = hash_image(&cover.data);
// Check if we already have this exact image in the DB // Check if we already have this exact image in the DB
let existing: Option<(i64,)> = sqlx::query_as( let existing: Option<(i64, String)> = sqlx::query_as(
"SELECT id FROM furumusic__media_file WHERE sha256_hash = $1 AND file_type = 'cover_art' LIMIT 1", "SELECT id, file_path FROM furumusic__media_file WHERE sha256_hash = $1 AND file_type = 'cover_art' LIMIT 1",
) )
.bind(&hash) .bind(&hash)
.fetch_optional(pool) .fetch_optional(pool)
.await?; .await?;
if let Some((id,)) = existing { if let Some((id, file_path)) = existing {
if let Some((file_path,)) = sqlx::query_as::<_, (String,)>( let path = crate::media_paths::resolve_media_file_path(storage_dir, &file_path);
"SELECT file_path FROM furumusic__media_file WHERE id = $1", let is_inside_storage = crate::media_paths::path_for_root(storage_dir, &path).is_some();
) if !is_inside_storage {
.bind(id) tracing::warn!(
.fetch_optional(pool) media_file_id = id,
.await? path = %path.display(),
{ "Ignoring duplicate cover hash whose stored file is outside agent_storage_dir"
let path = PathBuf::from(&file_path); );
let path = if path.is_absolute() { } else if !path.exists() {
path if let Some(parent) = path.parent() {
} else { tokio::fs::create_dir_all(parent).await?;
Path::new(storage_dir).join(path) }
}; match tokio::fs::write(&path, &cover.data).await {
Ok(()) => {
tracing::info!(
media_file_id = id,
path = %path.display(),
"Restored missing cover file for existing MediaFile"
);
}
Err(err) => {
tracing::warn!(
media_file_id = id,
path = %path.display(),
error = %err,
"Failed to restore missing cover file for existing MediaFile; creating a new cover file"
);
}
}
}
if is_inside_storage && path.exists() {
if let Err(err) = crate::agent::cover_variants::ensure_cover_variants(&path).await { if let Err(err) = crate::agent::cover_variants::ensure_cover_variants(&path).await {
tracing::warn!(media_file_id = id, error = %err, "Failed to generate cover variants"); tracing::warn!(media_file_id = id, error = %err, "Failed to generate cover variants");
} }
}
return Ok(id); return Ok(id);
} }
}
let ext = extension_for_mime(&cover.mime_type); let ext = extension_for_mime(&cover.mime_type);
let filename = format!("cover.{ext}"); let filename = format!("cover.{ext}");
@@ -354,7 +375,9 @@ pub async fn save_cover_to_storage(
let artist_dir = sanitize_dir_name(artist_name); let artist_dir = sanitize_dir_name(artist_name);
let album_dir = sanitize_dir_name(release_title); let album_dir = sanitize_dir_name(release_title);
let dest_dir = Path::new(storage_dir).join(&artist_dir).join(&album_dir); let dest_dir = crate::media_paths::resolve_config_path_buf(storage_dir)
.join(&artist_dir)
.join(&album_dir);
tokio::fs::create_dir_all(&dest_dir).await?; tokio::fs::create_dir_all(&dest_dir).await?;
let dest_path = dest_dir.join(&filename); let dest_path = dest_dir.join(&filename);
@@ -362,7 +385,13 @@ pub async fn save_cover_to_storage(
// Write image data // Write image data
tokio::fs::write(&dest_path, &cover.data).await?; tokio::fs::write(&dest_path, &cover.data).await?;
let relative_path = dest_path.to_string_lossy().to_string(); let relative_path = crate::media_paths::media_file_path_for_storage(storage_dir, &dest_path)
.ok_or_else(|| {
anyhow::anyhow!(
"cover destination is outside agent_storage_dir: {}",
dest_path.display()
)
})?;
let file_size = cover.data.len() as i64; let file_size = cover.data.len() as i64;
let media_file = crate::music::MediaFile::create( let media_file = crate::music::MediaFile::create(
+25 -49
View File
@@ -329,8 +329,8 @@ impl_env_overrides!(
impl AppConfig { impl AppConfig {
fn normalize_host_paths(&mut self) { fn normalize_host_paths(&mut self) {
self.agent_inbox_dir = normalize_host_path(&self.agent_inbox_dir); self.agent_inbox_dir = crate::media_paths::resolve_config_path(&self.agent_inbox_dir);
self.agent_storage_dir = normalize_host_path(&self.agent_storage_dir); self.agent_storage_dir = crate::media_paths::resolve_config_path(&self.agent_storage_dir);
} }
/// Build config: start from defaults, then overlay env vars. /// Build config: start from defaults, then overlay env vars.
@@ -413,47 +413,16 @@ impl AppConfig {
} }
} }
fn normalize_host_path(value: &str) -> String {
let trimmed = value.trim();
if trimmed.is_empty() {
return String::new();
}
normalize_windows_user_path(trimmed).unwrap_or_else(|| trimmed.to_owned())
}
#[cfg(not(windows))]
fn normalize_windows_user_path(value: &str) -> Option<String> {
let normalized = value.replace('\\', "/");
let mut parts = normalized.split('/').filter(|part| !part.is_empty());
let drive = parts.next()?;
if drive.len() != 2 || !drive.ends_with(':') {
return None;
}
if !parts.next()?.eq_ignore_ascii_case("Users") {
return None;
}
let user = parts.next()?;
if user.is_empty() {
return None;
}
let mut out = format!("/Users/{user}");
for part in parts {
out.push('/');
out.push_str(part);
}
Some(out)
}
#[cfg(windows)]
fn normalize_windows_user_path(_value: &str) -> Option<String> {
None
}
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use super::*; use super::*;
use std::sync::{Mutex, MutexGuard};
static ENV_LOCK: Mutex<()> = Mutex::new(());
fn lock_env() -> MutexGuard<'static, ()> {
ENV_LOCK.lock().unwrap_or_else(|err| err.into_inner())
}
#[test] #[test]
fn defaults_are_sane() { fn defaults_are_sane() {
@@ -462,25 +431,29 @@ mod tests {
assert_eq!(cfg.log_level, "info"); assert_eq!(cfg.log_level, "info");
} }
#[cfg(not(windows))]
#[test] #[test]
fn normalizes_windows_user_path_on_unix() { fn resolves_relative_media_paths_from_working_dir() {
let expected = std::env::current_dir()
.unwrap()
.join("media")
.join("uploads")
.to_string_lossy()
.to_string();
assert_eq!( assert_eq!(
normalize_host_path(r"C:\Users\ab\repos\furumusic\media\uploads"), crate::media_paths::resolve_config_path("media/uploads"),
"/Users/ab/repos/furumusic/media/uploads" expected
); );
} }
#[cfg(not(windows))]
#[test] #[test]
fn leaves_unix_path_unchanged() { fn keeps_absolute_windows_media_paths() {
assert_eq!( assert_eq!(
normalize_host_path("/Users/ab/repos/furumusic/media/uploads"), crate::media_paths::resolve_config_path(r"C:\Users\ab\repos\furumusic\media\uploads"),
"/Users/ab/repos/furumusic/media/uploads" "C:/Users/ab/repos/furumusic/media/uploads"
); );
} }
// SAFETY: tests run with --test-threads=1 so no concurrent env access. // SAFETY: environment-mutating tests take ENV_LOCK before changing vars.
unsafe fn set(k: &str, v: &str) { unsafe fn set(k: &str, v: &str) {
unsafe { std::env::set_var(k, v) }; unsafe { std::env::set_var(k, v) };
} }
@@ -490,6 +463,7 @@ mod tests {
#[test] #[test]
fn env_override_string_field() { fn env_override_string_field() {
let _guard = lock_env();
unsafe { unsafe {
set("FURU_OIDC_ISSUER", "https://example.com"); set("FURU_OIDC_ISSUER", "https://example.com");
} }
@@ -502,6 +476,7 @@ mod tests {
#[test] #[test]
fn env_override_bool_field() { fn env_override_bool_field() {
let _guard = lock_env();
unsafe { unsafe {
set("FURU_AUTH_SSO_ENABLED", "true"); set("FURU_AUTH_SSO_ENABLED", "true");
} }
@@ -514,6 +489,7 @@ mod tests {
#[test] #[test]
fn source_tracking_env() { fn source_tracking_env() {
let _guard = lock_env();
unsafe { unsafe {
set("FURU_OIDC_ISSUER", "https://tracked.example.com"); set("FURU_OIDC_ISSUER", "https://tracked.example.com");
} }
+2
View File
@@ -296,6 +296,8 @@ translations! {
player_likes_playlist: "Likes" , "Лайки"; player_likes_playlist: "Likes" , "Лайки";
player_listened: "listened" , "прослушано"; player_listened: "listened" , "прослушано";
player_search_placeholder: "Search artists, releases, tracks..." , "Поиск артистов, релизов, треков..."; player_search_placeholder: "Search artists, releases, tracks..." , "Поиск артистов, релизов, треков...";
player_connection_lost: "Server connection lost" , "Нет соединения с сервером";
player_connection_lost_detail: "Player cannot reach the server. Retrying..." , "Плеер не может связаться с сервером. Повторяю...";
player_no_results: "No results found" , "Ничего не найдено"; player_no_results: "No results found" , "Ничего не найдено";
player_new_playlist: "New Playlist" , "Новый плейлист"; player_new_playlist: "New Playlist" , "Новый плейлист";
player_rename_playlist: "Rename Playlist" , "Переименовать плейлист"; player_rename_playlist: "Rename Playlist" , "Переименовать плейлист";
-60
View File
@@ -1,60 +0,0 @@
use crate::scheduler::{Job, JobContext, JobLog};
/// Periodic job that auto-assigns artist images from their release covers.
///
/// For every artist that has no `image_file_id`, picks the cover of the most
/// recent release (by year) that has one. Runs after the cover backfill job
/// so freshly-extracted covers are available.
pub struct ArtistImageBackfillJob;
#[async_trait::async_trait]
impl Job for ArtistImageBackfillJob {
fn name(&self) -> &'static str {
"artist_image_backfill"
}
fn description(&self) -> &'static str {
"Auto-assign artist images from release covers"
}
fn default_cron(&self) -> &'static str {
// 03:15 daily — after cover_backfill at 03:00
"0 15 3 * * *"
}
async fn run(&self, ctx: &JobContext, log: &mut JobLog) -> anyhow::Result<()> {
let result = sqlx::query(
"UPDATE furumusic__artist a \
SET image_file_id = ( \
SELECT r.cover_file_id \
FROM furumusic__release_artist ra \
JOIN furumusic__release r ON r.id = ra.release_id \
WHERE ra.artist_id = a.id \
AND r.cover_file_id IS NOT NULL \
ORDER BY r.year DESC NULLS LAST \
LIMIT 1 \
), \
updated_at = $1 \
WHERE a.image_file_id IS NULL \
AND EXISTS ( \
SELECT 1 FROM furumusic__release_artist ra2 \
JOIN furumusic__release r2 ON r2.id = ra2.release_id \
WHERE ra2.artist_id = a.id AND r2.cover_file_id IS NOT NULL \
)",
)
.bind(chrono::Utc::now().format("%Y-%m-%dT%H:%M:%SZ").to_string())
.execute(&ctx.pool)
.await?;
let count = result.rows_affected();
if count > 0 {
log.info(&format!(
"Assigned images to {count} artists from release covers"
));
} else {
log.info("All artists already have images (or no covers available)");
}
Ok(())
}
}
-69
View File
@@ -1,69 +0,0 @@
use crate::scheduler::{Job, JobContext, JobLog};
/// Fallback job that assigns artist images from track cover art.
///
/// The primary `artist_image_backfill` job uses release covers. This job
/// runs afterwards and covers the case where the release itself has no
/// cover but individual tracks do (e.g. when cover art is embedded in the
/// audio file and extracted per-track rather than per-release).
///
/// For every artist that *still* has no `image_file_id` after the release-
/// based backfill, picks the `cover_file_id` of the most recent track
/// (by year, then track id) that has one.
pub struct ArtistTrackImageBackfillJob;
#[async_trait::async_trait]
impl Job for ArtistTrackImageBackfillJob {
fn name(&self) -> &'static str {
"artist_track_image_backfill"
}
fn description(&self) -> &'static str {
"Auto-assign artist images from track covers (fallback)"
}
fn default_cron(&self) -> &'static str {
// 03:30 daily — after artist_image_backfill at 03:15
"0 30 3 * * *"
}
async fn run(&self, ctx: &JobContext, log: &mut JobLog) -> anyhow::Result<()> {
let result = sqlx::query(
"UPDATE furumusic__artist a \
SET image_file_id = ( \
SELECT t.cover_file_id \
FROM furumusic__track_artist ta \
JOIN furumusic__track t ON t.id = ta.track_id \
WHERE ta.artist_id = a.id \
AND t.cover_file_id IS NOT NULL \
AND t.is_hidden = false \
ORDER BY t.year DESC NULLS LAST, t.id DESC \
LIMIT 1 \
), \
updated_at = $1 \
WHERE a.image_file_id IS NULL \
AND a.is_hidden = false \
AND EXISTS ( \
SELECT 1 FROM furumusic__track_artist ta2 \
JOIN furumusic__track t2 ON t2.id = ta2.track_id \
WHERE ta2.artist_id = a.id \
AND t2.cover_file_id IS NOT NULL \
AND t2.is_hidden = false \
)",
)
.bind(chrono::Utc::now().format("%Y-%m-%dT%H:%M:%SZ").to_string())
.execute(&ctx.pool)
.await?;
let count = result.rows_affected();
if count > 0 {
log.info(&format!(
"Assigned images to {count} artists from track covers"
));
} else {
log.info("All artists already have images (or no track covers available)");
}
Ok(())
}
}
File diff suppressed because it is too large Load Diff
-167
View File
@@ -1,167 +0,0 @@
use std::path::{Path, PathBuf};
use crate::agent::cover_art;
use crate::scheduler::{Job, JobContext, JobLog};
/// One-shot / periodic job that finds releases without cover art and attempts
/// to extract or discover covers from their audio files in storage.
pub struct CoverBackfillJob;
#[async_trait::async_trait]
impl Job for CoverBackfillJob {
fn name(&self) -> &'static str {
"cover_backfill"
}
fn description(&self) -> &'static str {
"Backfill cover art for releases missing covers"
}
fn default_cron(&self) -> &'static str {
// Once a day at 03:00
"0 0 3 * * *"
}
async fn run(&self, ctx: &JobContext, log: &mut JobLog) -> anyhow::Result<()> {
let storage_dir = &ctx.config.agent_storage_dir;
if storage_dir.is_empty() {
log.warn("agent_storage_dir is not configured, skipping cover backfill");
return Ok(());
}
// Find all releases without a cover
let rows: Vec<(i64, String)> = sqlx::query_as(
"SELECT r.id, r.title \
FROM furumusic__release r \
WHERE r.cover_file_id IS NULL \
ORDER BY r.id",
)
.fetch_all(&ctx.pool)
.await?;
if rows.is_empty() {
log.info("All releases already have cover art, nothing to backfill");
return Ok(());
}
log.info(&format!(
"Found {} releases without cover art, starting backfill...",
rows.len()
));
let mut assigned = 0u32;
let mut failed = 0u32;
let mut skipped_no_audio = 0u32;
let mut skipped_no_cover = 0u32;
let total = rows.len();
for (i, (release_id, release_title)) in rows.iter().enumerate() {
log.info(&format!(
"[{}/{}] Processing release {release_id} \"{release_title}\"...",
i + 1,
total,
));
// Find audio files belonging to this release via tracks → media_file
let audio_paths: Vec<(String,)> = sqlx::query_as(
"SELECT mf.file_path \
FROM furumusic__track t \
JOIN furumusic__media_file mf ON mf.id = t.audio_file_id \
WHERE t.release_id = $1 AND mf.file_type = 'audio'",
)
.bind(release_id)
.fetch_all(&ctx.pool)
.await
.unwrap_or_default();
if audio_paths.is_empty() {
log.warn(&format!(
"Release {release_id} \"{release_title}\": no audio files found, skipping"
));
skipped_no_audio += 1;
continue;
}
// Determine the folder from the first audio file's path
let first_path = Path::new(&audio_paths[0].0);
let folder = first_path.parent().unwrap_or(Path::new("."));
// Collect all audio file paths as PathBuf
let audio_files: Vec<PathBuf> =
audio_paths.iter().map(|(p,)| PathBuf::from(p)).collect();
// Try to find cover art
let cover = match cover_art::find_best_cover(folder, &audio_files).await {
Some(c) => c,
None => {
log.info(&format!(
"Release {release_id} \"{release_title}\": no cover image found in {} audio files, skipping",
audio_files.len(),
));
skipped_no_cover += 1;
continue;
}
};
let source_desc = match &cover.source {
cover_art::CoverSource::FolderFile(p) => format!("folder: {}", p.display()),
cover_art::CoverSource::Embedded(p) => format!("embedded: {}", p.display()),
};
// Look up artist name for storage path
let artist_name: String = sqlx::query_scalar(
"SELECT a.name FROM furumusic__artist a \
JOIN furumusic__release_artist ra ON ra.artist_id = a.id \
WHERE ra.release_id = $1 \
ORDER BY ra.position LIMIT 1",
)
.bind(release_id)
.fetch_optional(&ctx.pool)
.await
.ok()
.flatten()
.unwrap_or_else(|| "Unknown Artist".to_string());
match cover_art::save_cover_to_storage(
&ctx.db,
&ctx.pool,
storage_dir,
&artist_name,
release_title,
&cover,
)
.await
{
Ok(cover_file_id) => {
if let Err(e) =
cover_art::assign_cover_to_release(&ctx.pool, *release_id, cover_file_id)
.await
{
log.warn(&format!(
"Release {release_id} \"{release_title}\": saved cover but failed to assign: {e}"
));
failed += 1;
} else {
log.info(&format!(
"Release {release_id} \"{release_title}\": assigned cover from {source_desc}"
));
assigned += 1;
}
}
Err(e) => {
log.warn(&format!(
"Release {release_id} \"{release_title}\": failed to save cover: {e}"
));
failed += 1;
}
}
}
log.info(&format!(
"Cover backfill complete: {assigned} assigned, {failed} failed, \
{skipped_no_audio} skipped (no audio), {skipped_no_cover} skipped (no cover found)"
));
Ok(())
}
}
-96
View File
@@ -1,96 +0,0 @@
use std::path::{Path, PathBuf};
use crate::agent::cover_variants;
use crate::scheduler::{Job, JobContext, JobLog};
pub struct CoverVariantBackfillJob;
#[async_trait::async_trait]
impl Job for CoverVariantBackfillJob {
fn name(&self) -> &'static str {
"cover_variant_backfill"
}
fn description(&self) -> &'static str {
"Generate missing resized cover image variants"
}
fn default_cron(&self) -> &'static str {
// Once a day after cover extraction and artist image assignment.
"0 45 3 * * *"
}
async fn run(&self, ctx: &JobContext, log: &mut JobLog) -> anyhow::Result<()> {
let storage_dir = &ctx.config.agent_storage_dir;
if storage_dir.is_empty() {
log.warn("agent_storage_dir is not configured, skipping cover variant backfill");
return Ok(());
}
let rows: Vec<(i64, String)> = sqlx::query_as(
"SELECT id, file_path FROM furumusic__media_file WHERE file_type = 'cover_art' ORDER BY id",
)
.fetch_all(&ctx.pool)
.await?;
if rows.is_empty() {
log.info("No cover art media files found");
return Ok(());
}
log.info(&format!(
"Found {} cover art media file(s), checking variants...",
rows.len()
));
let mut created = 0usize;
let mut unchanged = 0usize;
let mut missing_original = 0usize;
let mut failed = 0usize;
for (media_file_id, file_path) in rows {
let path = resolve_media_path(storage_dir, &file_path);
if !path.exists() {
missing_original += 1;
log.warn(&format!(
"Media file {media_file_id}: original cover not found at {}",
path.display()
));
continue;
}
match cover_variants::ensure_cover_variants(&path).await {
Ok(0) => unchanged += 1,
Ok(count) => {
created += count;
log.info(&format!(
"Media file {media_file_id}: created {count} variant(s)"
));
}
Err(err) => {
failed += 1;
log.warn(&format!(
"Media file {media_file_id}: failed to create variants: {err}"
));
}
}
}
log.info(&format!(
"Cover variant backfill complete: {created} variant(s) created, \
{unchanged} original(s) already complete, {missing_original} missing original(s), \
{failed} failed original(s)"
));
Ok(())
}
}
fn resolve_media_path(storage_dir: &str, file_path: &str) -> PathBuf {
let path = PathBuf::from(file_path);
if path.is_absolute() {
path
} else {
Path::new(storage_dir).join(path)
}
}
+3 -1
View File
@@ -75,7 +75,9 @@ impl Job for InboxDiscoverJob {
for (_folder, files) in &groups { for (_folder, files) in &groups {
for file_path in files { for file_path in files {
let input_path_str = file_path.to_string_lossy().to_string(); let input_path_str =
crate::media_paths::path_for_root(&config.agent_inbox_dir, file_path)
.unwrap_or_else(|| file_path.to_string_lossy().to_string());
// Skip if a PendingReview already exists for this path // Skip if a PendingReview already exists for this path
match PendingReview::exists_for_path(&ctx.db, &input_path_str).await { match PendingReview::exists_for_path(&ctx.db, &input_path_str).await {
+42 -19
View File
@@ -225,14 +225,13 @@ fn group_reviews_by_folder(
reviews: &[PendingReview], reviews: &[PendingReview],
inbox_dir: &str, inbox_dir: &str,
) -> Vec<(String, Vec<PendingReview>)> { ) -> Vec<(String, Vec<PendingReview>)> {
let inbox = Path::new(inbox_dir);
let mut map: HashMap<String, Vec<PendingReview>> = HashMap::new(); let mut map: HashMap<String, Vec<PendingReview>> = HashMap::new();
for r in reviews { for r in reviews {
let path = Path::new(r.input_path_str()); let path = crate::media_paths::resolve_path_from_root(inbox_dir, r.input_path_str());
let folder = path.parent().unwrap_or(path); let folder = path.parent().unwrap_or(path.as_path());
let rel = folder.strip_prefix(inbox).unwrap_or(folder); let key = crate::media_paths::path_for_root(inbox_dir, folder)
let key = rel.to_string_lossy().to_string(); .unwrap_or_else(|| folder.to_string_lossy().to_string());
map.entry(key).or_default().push(r.clone()); map.entry(key).or_default().push(r.clone());
} }
@@ -287,8 +286,9 @@ async fn process_folder_batch(
let mut failed_reviews: Vec<PendingReview> = Vec::new(); let mut failed_reviews: Vec<PendingReview> = Vec::new();
for mut review in reviews { for mut review in reviews {
let input_path_str = review.input_path_str().to_owned(); let stored_input_path = review.input_path_str().to_owned();
let file_path = Path::new(&input_path_str); let file_path =
crate::media_paths::resolve_path_from_root(&config.agent_inbox_dir, &stored_input_path);
let filename = file_path let filename = file_path
.file_name() .file_name()
.and_then(|n| n.to_str()) .and_then(|n| n.to_str())
@@ -336,7 +336,7 @@ async fn process_folder_batch(
}; };
// Parse path hints // Parse path hints
let relative = file_path.strip_prefix(inbox_path).unwrap_or(file_path); let relative = file_path.strip_prefix(inbox_path).unwrap_or(&file_path);
let uploader = crate::jobs::uploader_from_relative_path(pool, relative).await; let uploader = crate::jobs::uploader_from_relative_path(pool, relative).await;
let hinted_relative = crate::jobs::strip_user_upload_prefix(relative); let hinted_relative = crate::jobs::strip_user_upload_prefix(relative);
let hints = crate::agent::path_hints::parse(&hinted_relative); let hints = crate::agent::path_hints::parse(&hinted_relative);
@@ -471,8 +471,11 @@ async fn process_folder_batch(
// Build folder context from the first file's folder // Build folder context from the first file's folder
let folder_ctx = { let folder_ctx = {
let first_path = Path::new(prepared[0].review.input_path_str()); let first_path = crate::media_paths::resolve_path_from_root(
let folder = first_path.parent().unwrap_or(first_path); &config.agent_inbox_dir,
prepared[0].review.input_path_str(),
);
let folder = first_path.parent().unwrap_or(first_path.as_path());
let mut folder_files: Vec<String> = std::fs::read_dir(folder) let mut folder_files: Vec<String> = std::fs::read_dir(folder)
.ok() .ok()
.map(|rd| { .map(|rd| {
@@ -631,7 +634,11 @@ async fn process_folder_batch(
p.review.result_json = Some(result_json); p.review.result_json = Some(result_json);
let _ = p.review.save(db).await; let _ = p.review.save(db).await;
let input_path_str = p.review.input_path_str().to_owned(); let input_path = crate::media_paths::resolve_path_from_root(
&config.agent_inbox_dir,
p.review.input_path_str(),
);
let input_path_str = input_path.to_string_lossy().to_string();
if confidence >= config.agent_confidence_threshold { if confidence >= config.agent_confidence_threshold {
match finalize_approved( match finalize_approved(
@@ -787,10 +794,10 @@ pub async fn finalize_approved(
format!("{}.{}", sanitize_filename(track_title), ext) format!("{}.{}", sanitize_filename(track_title), ext)
}; };
let storage_dir = Path::new(storage_dir_str); let storage_dir = crate::media_paths::resolve_config_path_buf(storage_dir_str);
let storage_path = if source_path.exists() { let storage_path = if source_path.exists() {
match mover::move_to_storage( match mover::move_to_storage(
storage_dir, &storage_dir,
artist_name, artist_name,
release_title, release_title,
&dest_filename, &dest_filename,
@@ -798,16 +805,29 @@ pub async fn finalize_approved(
) )
.await? .await?
{ {
mover::MoveOutcome::Moved(p) => p.to_string_lossy().to_string(), mover::MoveOutcome::Moved(p) | mover::MoveOutcome::Merged(p) => {
mover::MoveOutcome::Merged(p) => p.to_string_lossy().to_string(), crate::media_paths::media_file_path_for_storage(storage_dir_str, &p).ok_or_else(
|| {
anyhow::anyhow!(
"storage destination is outside agent_storage_dir: {}",
p.display()
)
},
)?
}
} }
} else { } else {
storage_dir let expected_path = storage_dir
.join(sanitize_filename(artist_name)) .join(sanitize_filename(artist_name))
.join(sanitize_filename(release_title)) .join(sanitize_filename(release_title))
.join(&dest_filename) .join(&dest_filename);
.to_string_lossy() crate::media_paths::media_file_path_for_storage(storage_dir_str, &expected_path)
.to_string() .ok_or_else(|| {
anyhow::anyhow!(
"storage destination is outside agent_storage_dir: {}",
expected_path.display()
)
})?
}; };
let media_file = MediaFile::create( let media_file = MediaFile::create(
@@ -887,6 +907,9 @@ pub async fn finalize_approved(
crate::agent::cover_art::CoverSource::Embedded(p) => { crate::agent::cover_art::CoverSource::Embedded(p) => {
format!("embedded in: {}", p.display()) format!("embedded in: {}", p.display())
} }
crate::agent::cover_art::CoverSource::Remote(url) => {
format!("remote: {url}")
}
}; };
match crate::agent::cover_art::save_cover_to_storage( match crate::agent::cover_art::save_cover_to_storage(
db, db,
+6 -18
View File
@@ -1,5 +1,3 @@
use std::path::{Path, PathBuf};
use crate::scheduler::{Job, JobContext, JobLog}; use crate::scheduler::{Job, JobContext, JobLog};
#[derive(Debug, Clone, Copy)] #[derive(Debug, Clone, Copy)]
@@ -104,11 +102,15 @@ pub async fn run_with_options(
for row in rows { for row in rows {
scanned += 1; scanned += 1;
let Some(path) = resolve_media_path(&row.file_path, &ctx.config.agent_storage_dir) else { let path = crate::media_paths::resolve_media_file_path(
&ctx.config.agent_storage_dir,
&row.file_path,
);
if !path.exists() {
missing += 1; missing += 1;
log.warn(&format!("missing file: {}", row.file_path)); log.warn(&format!("missing file: {}", row.file_path));
continue; continue;
}; }
let extract_path = path.clone(); let extract_path = path.clone();
let raw_meta = match tokio::task::spawn_blocking(move || { let raw_meta = match tokio::task::spawn_blocking(move || {
@@ -218,17 +220,3 @@ fn should_update<T>(current: Option<T>, overwrite: bool) -> bool {
fn should_update_duration(current: Option<f64>, overwrite: bool) -> bool { fn should_update_duration(current: Option<f64>, overwrite: bool) -> bool {
overwrite || current.unwrap_or(0.0) <= 0.0 overwrite || current.unwrap_or(0.0) <= 0.0
} }
fn resolve_media_path(file_path: &str, storage_dir: &str) -> Option<PathBuf> {
let path = Path::new(file_path);
if path.exists() {
return Some(path.to_path_buf());
}
if path.is_relative() && !storage_dir.is_empty() {
let joined = Path::new(storage_dir).join(path);
if joined.exists() {
return Some(joined);
}
}
None
}
+1 -4
View File
@@ -1,7 +1,4 @@
pub mod artist_image_backfill; pub mod artwork_backfill;
pub mod artist_track_image_backfill;
pub mod cover_backfill;
pub mod cover_variant_backfill;
pub mod inbox_discover; pub mod inbox_discover;
pub mod inbox_process; pub mod inbox_process;
pub mod lastfm_popularity; pub mod lastfm_popularity;
+2 -4
View File
@@ -6,6 +6,7 @@ mod config;
mod i18n; mod i18n;
mod jobs; mod jobs;
mod lastfm; mod lastfm;
mod media_paths;
mod music; mod music;
mod oidc; mod oidc;
mod player; mod player;
@@ -50,10 +51,7 @@ fn build_registry() -> Arc<JobRegistry> {
registry.register(jobs::inbox_discover::InboxDiscoverJob); registry.register(jobs::inbox_discover::InboxDiscoverJob);
registry.register(jobs::inbox_process::InboxProcessJob); registry.register(jobs::inbox_process::InboxProcessJob);
registry.register(jobs::inbox_process::FileProcessJob); registry.register(jobs::inbox_process::FileProcessJob);
registry.register(jobs::cover_backfill::CoverBackfillJob); registry.register(jobs::artwork_backfill::ArtworkBackfillJob);
registry.register(jobs::artist_image_backfill::ArtistImageBackfillJob);
registry.register(jobs::artist_track_image_backfill::ArtistTrackImageBackfillJob);
registry.register(jobs::cover_variant_backfill::CoverVariantBackfillJob);
registry.register(jobs::metadata_backfill::MetadataBackfillJob); registry.register(jobs::metadata_backfill::MetadataBackfillJob);
registry.register(jobs::lastfm_popularity::LastfmPopularityJob); registry.register(jobs::lastfm_popularity::LastfmPopularityJob);
registry.register(jobs::lastfm_scrobble::LastfmScrobbleJob); registry.register(jobs::lastfm_scrobble::LastfmScrobbleJob);
+256
View File
@@ -0,0 +1,256 @@
use std::path::{Component, Path, PathBuf};
pub fn resolve_config_path(value: &str) -> String {
let path = resolve_config_path_buf(value);
if path.as_os_str().is_empty() {
String::new()
} else {
path.to_string_lossy().to_string()
}
}
pub fn resolve_config_path_buf(value: &str) -> PathBuf {
let trimmed = value.trim();
if trimmed.is_empty() {
return PathBuf::new();
}
let normalized = normalize_slashes(trimmed);
if is_absolute_path(&normalized) {
PathBuf::from(normalized)
} else {
app_root().join(slash_path(&normalized))
}
}
pub fn resolve_media_file_path(storage_dir: &str, file_path: &str) -> PathBuf {
resolve_path_from_root(storage_dir, file_path)
}
pub fn media_file_path_for_storage(storage_dir: &str, path: &Path) -> Option<String> {
path_for_root(storage_dir, path)
}
pub fn resolve_path_from_root(root_dir: &str, stored_path: &str) -> PathBuf {
let normalized = normalize_slashes(stored_path.trim());
if is_absolute_path(&normalized) {
PathBuf::from(normalized)
} else {
resolve_config_path_buf(root_dir).join(slash_path(&normalized))
}
}
pub fn path_for_root(root_dir: &str, path: &Path) -> Option<String> {
let root = resolve_config_path_buf(root_dir);
let normalized = normalize_slashes(&path.to_string_lossy());
if is_absolute_path(&normalized) {
return strip_root_prefix(&root, &normalized);
}
relative_path_string(path)
}
pub async fn normalize_media_file_paths(
pool: &sqlx::PgPool,
storage_dir: &str,
) -> anyhow::Result<u64> {
normalize_table_paths(pool, "furumusic__media_file", "file_path", storage_dir).await
}
pub async fn normalize_pending_review_paths(
pool: &sqlx::PgPool,
inbox_dir: &str,
) -> anyhow::Result<u64> {
normalize_table_paths(pool, "furumusic__pending_review", "input_path", inbox_dir).await
}
async fn normalize_table_paths(
pool: &sqlx::PgPool,
table: &str,
column: &str,
root_dir: &str,
) -> anyhow::Result<u64> {
let sql = format!("SELECT id, {column} FROM {table} WHERE {column} IS NOT NULL ORDER BY id");
let rows: Vec<(i64, String)> = sqlx::query_as(&sql).fetch_all(pool).await?;
let mut updated = 0;
for (id, stored_path) in rows {
let Some(normalized) = normalize_stored_path(root_dir, &stored_path) else {
continue;
};
if normalized == stored_path {
continue;
}
let sql = format!("UPDATE {table} SET {column} = $1 WHERE id = $2");
sqlx::query(&sql)
.bind(&normalized)
.bind(id)
.execute(pool)
.await?;
updated += 1;
}
Ok(updated)
}
fn normalize_stored_path(root_dir: &str, stored_path: &str) -> Option<String> {
let normalized = normalize_slashes(stored_path);
if normalized.is_empty() {
return None;
}
if is_absolute_path(&normalized) {
strip_root_prefix(&resolve_config_path_buf(root_dir), &normalized)
} else {
normalize_relative_path(&normalized)
}
}
fn app_root() -> PathBuf {
std::env::current_dir().unwrap_or_else(|_| PathBuf::from("."))
}
fn normalize_slashes(value: &str) -> String {
value.trim().replace('\\', "/")
}
fn is_absolute_path(value: &str) -> bool {
value.starts_with('/') || Path::new(value).is_absolute() || looks_like_windows_absolute(value)
}
fn looks_like_windows_absolute(value: &str) -> bool {
let bytes = value.as_bytes();
bytes.len() >= 3 && bytes[1] == b':' && bytes[2] == b'/' && bytes[0].is_ascii_alphabetic()
}
fn slash_path(value: &str) -> PathBuf {
value
.split('/')
.filter(|part| !part.is_empty() && *part != ".")
.fold(PathBuf::new(), |mut path, part| {
path.push(part);
path
})
}
fn normalize_relative_path(value: &str) -> Option<String> {
let parts: Vec<&str> = value
.split('/')
.filter(|part| !part.is_empty() && *part != ".")
.collect();
if parts.is_empty() || parts.iter().any(|part| *part == "..") {
return None;
}
Some(parts.join("/"))
}
fn strip_root_prefix(root: &Path, normalized_path: &str) -> Option<String> {
let root_string = normalize_slashes(&root.to_string_lossy());
let root_trimmed = root_string.trim_end_matches('/');
let path_trimmed = normalized_path.trim();
let root_cmp = comparable_path(root_trimmed);
let path_cmp = comparable_path(path_trimmed);
if path_cmp == root_cmp {
return None;
}
let prefix = format!("{root_cmp}/");
if path_cmp.starts_with(&prefix) {
let tail = &path_trimmed[root_trimmed.len() + 1..];
return normalize_relative_path(tail);
}
None
}
fn comparable_path(value: &str) -> String {
let normalized = normalize_slashes(value).trim_end_matches('/').to_owned();
if cfg!(windows) || looks_like_windows_absolute(&normalized) {
normalized.to_ascii_lowercase()
} else {
normalized
}
}
fn relative_path_string(path: &Path) -> Option<String> {
let mut parts = Vec::new();
for component in path.components() {
match component {
Component::Normal(value) => parts.push(value.to_string_lossy().to_string()),
Component::CurDir => {}
_ => return None,
}
}
if parts.is_empty() {
None
} else {
Some(parts.join("/"))
}
}
#[cfg(test)]
mod tests {
use super::*;
#[test]
fn resolves_relative_config_path_from_app_root() {
let expected = app_root().join("media").join("library");
assert_eq!(resolve_config_path_buf("media/library"), expected);
}
#[test]
fn keeps_absolute_config_path() {
assert_eq!(resolve_config_path_buf("/media"), PathBuf::from("/media"));
}
#[test]
fn resolves_relative_media_file_under_storage_root() {
assert_eq!(
resolve_media_file_path("/media", "Buckethead/Pike/cover.jpg"),
PathBuf::from("/media")
.join("Buckethead")
.join("Pike")
.join("cover.jpg")
);
}
#[test]
fn keeps_absolute_media_file_path() {
assert_eq!(
resolve_media_file_path("/media", "/media/Buckethead/Pike/cover.jpg"),
PathBuf::from("/media/Buckethead/Pike/cover.jpg")
);
}
#[test]
fn stores_path_relative_to_storage_root() {
let storage = app_root().join("media").join("library");
let path = storage.join("Artist").join("Album").join("track.flac");
assert_eq!(
media_file_path_for_storage(&storage.to_string_lossy(), &path).as_deref(),
Some("Artist/Album/track.flac")
);
}
#[test]
fn stores_windows_path_relative_to_windows_storage_root() {
assert_eq!(
path_for_root(
r"C:\Users\ab\repos\furumusic\library",
Path::new(r"C:\Users\ab\repos\furumusic\library\Artist\Album\track.mp3"),
)
.as_deref(),
Some("Artist/Album/track.mp3")
);
}
#[test]
fn normalizes_relative_backslashes() {
assert_eq!(
normalize_stored_path("/media", r"Artist\Album\track.mp3").as_deref(),
Some("Artist/Album/track.mp3")
);
}
}
+47
View File
@@ -1769,6 +1769,52 @@ pub mod db_migrations {
&[Operation::custom(create_lastfm_scrobbling).build()]; &[Operation::custom(create_lastfm_scrobbling).build()];
} }
// -- M0034: Artwork lookup state --------------------------------------
#[cot::db::migrations::migration_op]
async fn create_artwork_lookup_state(
ctx: migrations::MigrationContext<'_>,
) -> cot::db::Result<()> {
ctx.db
.raw(
"CREATE TABLE IF NOT EXISTS furumusic__artwork_lookup_state (
id BIGSERIAL PRIMARY KEY,
entity_kind VARCHAR(32) NOT NULL,
entity_id BIGINT NOT NULL,
source VARCHAR(32) NOT NULL,
status VARCHAR(32) NOT NULL,
attempt_count INTEGER NOT NULL DEFAULT 0,
last_attempt_at VARCHAR(32) NOT NULL,
last_error TEXT,
source_url TEXT,
UNIQUE(entity_kind, entity_id, source)
)",
)
.await?;
ctx.db
.raw(
"CREATE INDEX IF NOT EXISTS idx_artwork_lookup_state_retry
ON furumusic__artwork_lookup_state (entity_kind, source, status, last_attempt_at)",
)
.await?;
Ok(())
}
#[derive(Debug, Copy, Clone)]
pub struct M0034CreateArtworkLookupState;
impl migrations::Migration for M0034CreateArtworkLookupState {
const APP_NAME: &'static str = "furumusic";
const MIGRATION_NAME: &'static str = "m_0034_create_artwork_lookup_state";
const DEPENDENCIES: &'static [migrations::MigrationDependency] =
&[migrations::MigrationDependency::migration(
"furumusic",
"m_0033_create_lastfm_scrobbling",
)];
const OPERATIONS: &'static [Operation] =
&[Operation::custom(create_artwork_lookup_state).build()];
}
pub const MIGRATIONS: &[&SyncDynMigration] = &[ pub const MIGRATIONS: &[&SyncDynMigration] = &[
&M0006CreateMediaFile, &M0006CreateMediaFile,
&M0007CreateArtist, &M0007CreateArtist,
@@ -1793,5 +1839,6 @@ pub mod db_migrations {
&M0031CreateTorrentSession, &M0031CreateTorrentSession,
&M0032CreateLastfmTrackPopularity, &M0032CreateLastfmTrackPopularity,
&M0033CreateLastfmScrobbling, &M0033CreateLastfmScrobbling,
&M0034CreateArtworkLookupState,
]; ];
} }
+162 -106
View File
@@ -217,10 +217,10 @@ async fn lastfm_connect_handler(
}; };
let (config, _) = AppConfig::load_with_db(&db).await; let (config, _) = AppConfig::load_with_db(&db).await;
let Some(credentials) = LastfmCredentials::from_config(&config) else { let Some(credentials) = LastfmCredentials::from_config(&config) else {
return Ok(redirect_response("/?lastfm=not_configured")); return Ok(redirect_response("/"));
}; };
let Some(origin) = request_origin(&request) else { let Some(origin) = request_origin(&request) else {
return Ok(redirect_response("/?lastfm=bad_origin")); return Ok(redirect_response("/"));
}; };
let state = uuid::Uuid::new_v4().simple().to_string(); let state = uuid::Uuid::new_v4().simple().to_string();
@@ -270,7 +270,7 @@ async fn lastfm_callback_handler(
.map(str::trim) .map(str::trim)
.filter(|v| !v.is_empty()) .filter(|v| !v.is_empty())
else { else {
return Ok(redirect_response("/?lastfm=missing_token")); return Ok(redirect_response("/"));
}; };
let Some(state) = query let Some(state) = query
.0 .0
@@ -279,7 +279,7 @@ async fn lastfm_callback_handler(
.map(str::trim) .map(str::trim)
.filter(|v| !v.is_empty()) .filter(|v| !v.is_empty())
else { else {
return Ok(redirect_response("/?lastfm=missing_state")); return Ok(redirect_response("/"));
}; };
let state_user_id = sqlx::query_scalar::<_, i64>( let state_user_id = sqlx::query_scalar::<_, i64>(
@@ -290,7 +290,7 @@ async fn lastfm_callback_handler(
.await .await
.map_err(|e| cot::Error::internal(e.to_string()))?; .map_err(|e| cot::Error::internal(e.to_string()))?;
if state_user_id != Some(user.id) { if state_user_id != Some(user.id) {
return Ok(redirect_response("/?lastfm=bad_state")); return Ok(redirect_response("/"));
} }
sqlx::query("DELETE FROM furumusic__lastfm_auth_state WHERE state = $1") sqlx::query("DELETE FROM furumusic__lastfm_auth_state WHERE state = $1")
.bind(state) .bind(state)
@@ -300,7 +300,7 @@ async fn lastfm_callback_handler(
let (config, _) = AppConfig::load_with_db(&db).await; let (config, _) = AppConfig::load_with_db(&db).await;
let Some(credentials) = LastfmCredentials::from_config(&config) else { let Some(credentials) = LastfmCredentials::from_config(&config) else {
return Ok(redirect_response("/?lastfm=not_configured")); return Ok(redirect_response("/"));
}; };
let client = LastfmClient::new(credentials).map_err(|e| cot::Error::internal(e.to_string()))?; let client = LastfmClient::new(credentials).map_err(|e| cot::Error::internal(e.to_string()))?;
match client.get_session(token).await { match client.get_session(token).await {
@@ -324,11 +324,11 @@ async fn lastfm_callback_handler(
.execute(pool) .execute(pool)
.await .await
.map_err(|e| cot::Error::internal(e.to_string()))?; .map_err(|e| cot::Error::internal(e.to_string()))?;
Ok(redirect_response("/?lastfm=connected")) Ok(redirect_response("/"))
} }
Err(err) => { Err(err) => {
tracing::warn!("Last.fm auth failed for user {}: {err}", user.id); tracing::warn!("Last.fm auth failed for user {}: {err}", user.id);
Ok(redirect_response("/?lastfm=auth_failed")) Ok(redirect_response("/"))
} }
} }
} }
@@ -460,6 +460,98 @@ async fn update_lastfm_account_error(
Ok(()) Ok(())
} }
async fn enqueue_lastfm_scrobble(
pool: &sqlx::PgPool,
config: &AppConfig,
user_id: i64,
track_id: i64,
started_at: Option<i64>,
listened_seconds: i32,
) -> cot::Result<LastfmActionResponse> {
if !crate::lastfm::is_configured(config) {
return Ok(LastfmActionResponse {
ok: false,
queued: false,
sent: false,
message: Some("Last.fm is not configured".to_string()),
});
}
if load_lastfm_account(pool, user_id).await?.is_none() {
return Ok(LastfmActionResponse {
ok: false,
queued: false,
sent: false,
message: Some("Last.fm account is not connected".to_string()),
});
}
let Some(track) = load_lastfm_track_payload(pool, track_id).await? else {
return Ok(LastfmActionResponse {
ok: false,
queued: false,
sent: false,
message: Some("Track has no primary artist for Last.fm".to_string()),
});
};
let duration_seconds = track.duration_seconds.unwrap_or(0).max(0);
if duration_seconds <= 30 {
return Ok(LastfmActionResponse {
ok: false,
queued: false,
sent: false,
message: Some("Track is too short to scrobble".to_string()),
});
}
let threshold = ((duration_seconds as f64 / 2.0).min(240.0)).ceil() as i32;
let listened_seconds = listened_seconds.max(0);
if listened_seconds < threshold {
return Ok(LastfmActionResponse {
ok: false,
queued: false,
sent: false,
message: Some("Scrobble threshold has not been reached".to_string()),
});
}
let now_ts = chrono::Utc::now().timestamp();
let started_at = started_at
.unwrap_or(now_ts - listened_seconds as i64)
.min(now_ts);
let now = chrono::Utc::now().format("%Y-%m-%dT%H:%M:%SZ").to_string();
let dedupe_key = format!("{user_id}:{track_id}:{started_at}");
sqlx::query(
r#"INSERT INTO furumusic__lastfm_scrobble_outbox
(user_id, track_id, started_at, listened_seconds, duration_seconds, status, created_at, updated_at, dedupe_key)
VALUES ($1, $2, $3, $4, $5, 'pending', $6, $6, $7)
ON CONFLICT (dedupe_key) DO NOTHING"#,
)
.bind(user_id)
.bind(track_id)
.bind(started_at)
.bind(listened_seconds)
.bind(duration_seconds)
.bind(&now)
.bind(&dedupe_key)
.execute(pool)
.await
.map_err(|e| cot::Error::internal(e.to_string()))?;
let sent = match crate::lastfm::process_pending_scrobbles(pool, config, Some(user_id), 10).await
{
Ok(summary) => summary.sent > 0,
Err(err) => {
tracing::warn!("Last.fm immediate scrobble send failed: {err:#}");
false
}
};
Ok(LastfmActionResponse {
ok: true,
queued: true,
sent,
message: None,
})
}
async fn lastfm_now_playing_handler( async fn lastfm_now_playing_handler(
session: Session, session: Session,
db: Database, db: Database,
@@ -542,93 +634,17 @@ async fn lastfm_scrobble_handler(
return Ok(json_error(StatusCode::UNAUTHORIZED, "not authenticated")); return Ok(json_error(StatusCode::UNAUTHORIZED, "not authenticated"));
}; };
let (config, _) = AppConfig::load_with_db(&db).await; let (config, _) = AppConfig::load_with_db(&db).await;
if !crate::lastfm::is_configured(&config) { Json(
return Json(LastfmActionResponse { enqueue_lastfm_scrobble(
ok: false, pool,
queued: false, &config,
sent: false, user.id,
message: Some("Last.fm is not configured".to_string()), entry.track_id,
}) entry.started_at,
.into_response(); entry.listened_seconds,
} )
if load_lastfm_account(pool, user.id).await?.is_none() { .await?,
return Json(LastfmActionResponse {
ok: false,
queued: false,
sent: false,
message: Some("Last.fm account is not connected".to_string()),
})
.into_response();
}
let Some(track) = load_lastfm_track_payload(pool, entry.track_id).await? else {
return Json(LastfmActionResponse {
ok: false,
queued: false,
sent: false,
message: Some("Track has no primary artist for Last.fm".to_string()),
})
.into_response();
};
let duration_seconds = track.duration_seconds.unwrap_or(0).max(0);
if duration_seconds <= 30 {
return Json(LastfmActionResponse {
ok: false,
queued: false,
sent: false,
message: Some("Track is too short to scrobble".to_string()),
})
.into_response();
}
let threshold = ((duration_seconds as f64 / 2.0).min(240.0)).ceil() as i32;
let listened_seconds = entry.listened_seconds.max(0);
if listened_seconds < threshold {
return Json(LastfmActionResponse {
ok: false,
queued: false,
sent: false,
message: Some("Scrobble threshold has not been reached".to_string()),
})
.into_response();
}
let now_ts = chrono::Utc::now().timestamp();
let started_at = entry
.started_at
.unwrap_or(now_ts - listened_seconds as i64)
.min(now_ts);
let now = chrono::Utc::now().format("%Y-%m-%dT%H:%M:%SZ").to_string();
let dedupe_key = format!("{}:{}:{}", user.id, entry.track_id, started_at);
sqlx::query(
r#"INSERT INTO furumusic__lastfm_scrobble_outbox
(user_id, track_id, started_at, listened_seconds, duration_seconds, status, created_at, updated_at, dedupe_key)
VALUES ($1, $2, $3, $4, $5, 'pending', $6, $6, $7)
ON CONFLICT (dedupe_key) DO NOTHING"#,
) )
.bind(user.id)
.bind(entry.track_id)
.bind(started_at)
.bind(listened_seconds)
.bind(duration_seconds)
.bind(&now)
.bind(&dedupe_key)
.execute(pool)
.await
.map_err(|e| cot::Error::internal(e.to_string()))?;
let sent =
match crate::lastfm::process_pending_scrobbles(pool, &config, Some(user.id), 10).await {
Ok(summary) => summary.sent > 0,
Err(err) => {
tracing::warn!("Last.fm immediate scrobble send failed: {err:#}");
false
}
};
Json(LastfmActionResponse {
ok: true,
queued: true,
sent,
message: None,
})
.into_response() .into_response()
} }
@@ -1436,7 +1452,8 @@ async fn stream_handler(
return Ok(json_error(StatusCode::NOT_FOUND, "track not found")); return Ok(json_error(StatusCode::NOT_FOUND, "track not found"));
}; };
let full_path = std::path::Path::new(&config.agent_storage_dir).join(&media.file_path); let full_path =
crate::media_paths::resolve_media_file_path(&config.agent_storage_dir, &media.file_path);
if !full_path.exists() { if !full_path.exists() {
return Ok(json_error( return Ok(json_error(
@@ -1505,7 +1522,7 @@ async fn local_upload_handler(
"agent_inbox_dir is not configured", "agent_inbox_dir is not configured",
)); ));
} }
let inbox_root = std::path::PathBuf::from(inbox_dir); let inbox_root = crate::media_paths::resolve_config_path_buf(inbox_dir);
if !inbox_root.is_absolute() { if !inbox_root.is_absolute() {
return Ok(json_error( return Ok(json_error(
StatusCode::BAD_REQUEST, StatusCode::BAD_REQUEST,
@@ -1728,7 +1745,8 @@ async fn cover_response(
return Ok(json_error(StatusCode::NOT_FOUND, "media file not found")); return Ok(json_error(StatusCode::NOT_FOUND, "media file not found"));
}; };
let full_path = std::path::Path::new(&config.agent_storage_dir).join(&media.file_path); let full_path =
crate::media_paths::resolve_media_file_path(&config.agent_storage_dir, &media.file_path);
if !full_path.exists() { if !full_path.exists() {
return Ok(json_error(StatusCode::NOT_FOUND, "file not found on disk")); return Ok(json_error(StatusCode::NOT_FOUND, "file not found on disk"));
@@ -1944,6 +1962,45 @@ async fn history_handler(
.await .await
.map_err(|e| cot::Error::internal(e.to_string()))?; .map_err(|e| cot::Error::internal(e.to_string()))?;
if let Some(listened_seconds) = entry.duration_listened {
let (config, _) = AppConfig::load_with_db(&db).await;
match enqueue_lastfm_scrobble(
pool,
&config,
user.id,
entry.track_id,
entry.started_at,
listened_seconds,
)
.await
{
Ok(result) if result.queued => {
tracing::info!(
user_id = user.id,
track_id = entry.track_id,
sent = result.sent,
"Queued Last.fm scrobble from play history"
);
}
Ok(result) => {
tracing::debug!(
user_id = user.id,
track_id = entry.track_id,
message = ?result.message,
"Play history did not queue Last.fm scrobble"
);
}
Err(err) => {
tracing::warn!(
user_id = user.id,
track_id = entry.track_id,
error = %err,
"Failed to queue Last.fm scrobble from play history"
);
}
}
}
Json(serde_json::json!({"ok": true})).into_response() Json(serde_json::json!({"ok": true})).into_response()
} }
@@ -3850,7 +3907,6 @@ impl App for PlayerApp {
{ {
let pool = Arc::clone(&pool); let pool = Arc::clone(&pool);
let pool_config = Arc::clone(&pool_config); let pool_config = Arc::clone(&pool_config);
let config = Arc::clone(&self.config);
get( get(
move |session: Session, move |session: Session,
db: Database, db: Database,
@@ -3858,7 +3914,6 @@ impl App for PlayerApp {
request: cot::request::Request| { request: cot::request::Request| {
let pool = Arc::clone(&pool); let pool = Arc::clone(&pool);
let pool_config = Arc::clone(&pool_config); let pool_config = Arc::clone(&pool_config);
let config = Arc::clone(&config);
async move { async move {
let pg_pool = pool let pg_pool = pool
.get_or_init(|| async { .get_or_init(|| async {
@@ -3869,7 +3924,9 @@ impl App for PlayerApp {
.expect("player pool") .expect("player pool")
}) })
.await; .await;
stream_handler(session, db, pg_pool, &config, &request, path).await let (live_config, _) = AppConfig::load_with_db(&db).await;
stream_handler(session, db, pg_pool, &live_config, &request, path)
.await
} }
}, },
) )
@@ -3882,12 +3939,10 @@ impl App for PlayerApp {
{ {
let pool = Arc::clone(&pool); let pool = Arc::clone(&pool);
let pool_config = Arc::clone(&pool_config); let pool_config = Arc::clone(&pool_config);
let config = Arc::clone(&self.config);
get( get(
move |session: Session, db: Database, path: Path<PathMediaFileVariant>| { move |session: Session, db: Database, path: Path<PathMediaFileVariant>| {
let pool = Arc::clone(&pool); let pool = Arc::clone(&pool);
let pool_config = Arc::clone(&pool_config); let pool_config = Arc::clone(&pool_config);
let config = Arc::clone(&config);
async move { async move {
let pg_pool = pool let pg_pool = pool
.get_or_init(|| async { .get_or_init(|| async {
@@ -3898,7 +3953,9 @@ impl App for PlayerApp {
.expect("player pool") .expect("player pool")
}) })
.await; .await;
cover_variant_handler(session, db, pg_pool, &config, path).await let (live_config, _) = AppConfig::load_with_db(&db).await;
cover_variant_handler(session, db, pg_pool, &live_config, path)
.await
} }
}, },
) )
@@ -3910,12 +3967,10 @@ impl App for PlayerApp {
{ {
let pool = Arc::clone(&pool); let pool = Arc::clone(&pool);
let pool_config = Arc::clone(&pool_config); let pool_config = Arc::clone(&pool_config);
let config = Arc::clone(&self.config);
get( get(
move |session: Session, db: Database, path: Path<PathMediaFileId>| { move |session: Session, db: Database, path: Path<PathMediaFileId>| {
let pool = Arc::clone(&pool); let pool = Arc::clone(&pool);
let pool_config = Arc::clone(&pool_config); let pool_config = Arc::clone(&pool_config);
let config = Arc::clone(&config);
async move { async move {
let pg_pool = pool let pg_pool = pool
.get_or_init(|| async { .get_or_init(|| async {
@@ -3926,7 +3981,8 @@ impl App for PlayerApp {
.expect("player pool") .expect("player pool")
}) })
.await; .await;
cover_handler(session, db, pg_pool, &config, path).await let (live_config, _) = AppConfig::load_with_db(&db).await;
cover_handler(session, db, pg_pool, &live_config, path).await
} }
}, },
) )
+1
View File
@@ -3,6 +3,7 @@ use serde::Deserialize;
#[derive(Debug, Deserialize)] #[derive(Debug, Deserialize)]
pub(super) struct HistoryEntry { pub(super) struct HistoryEntry {
pub(super) track_id: i64, pub(super) track_id: i64,
pub(super) started_at: Option<i64>,
pub(super) duration_listened: Option<i32>, pub(super) duration_listened: Option<i32>,
pub(super) completed: bool, pub(super) completed: bool,
} }
+26
View File
@@ -1360,6 +1360,7 @@ async fn run_scheduled_job(
if !live_config.agent_enabled if !live_config.agent_enabled
&& job_name != "lastfm_popularity" && job_name != "lastfm_popularity"
&& job_name != "lastfm_scrobble" && job_name != "lastfm_scrobble"
&& job_name != "artwork_backfill"
{ {
tracing::warn!(job = job_name, "Skipping: agent_enabled=false"); tracing::warn!(job = job_name, "Skipping: agent_enabled=false");
return; return;
@@ -1470,6 +1471,31 @@ pub async fn start_scheduler(
Err(e) => tracing::error!("Failed to recover stale reviews: {e}"), Err(e) => tracing::error!("Failed to recover stale reviews: {e}"),
} }
let (live_config, _) = AppConfig::load_with_db(&db).await;
if !live_config.agent_storage_dir.trim().is_empty() {
match crate::media_paths::normalize_media_file_paths(&pool, &live_config.agent_storage_dir)
.await
{
Ok(0) => {}
Ok(n) => tracing::info!("Normalized {n} media file path(s) to relative storage paths"),
Err(e) => tracing::warn!("Failed to normalize media file paths: {e:#}"),
}
}
if !live_config.agent_inbox_dir.trim().is_empty() {
match crate::media_paths::normalize_pending_review_paths(
&pool,
&live_config.agent_inbox_dir,
)
.await
{
Ok(0) => {}
Ok(n) => {
tracing::info!("Normalized {n} pending review path(s) to relative inbox paths")
}
Err(e) => tracing::warn!("Failed to normalize pending review paths: {e:#}"),
}
}
// Upsert ScheduledJob rows // Upsert ScheduledJob rows
for job in registry.all_jobs() { for job in registry.all_jobs() {
ScheduledJob::upsert(&db, job.name(), job.description(), job.default_cron()) ScheduledJob::upsert(&db, job.name(), job.description(), job.default_cron())
+1 -1
View File
@@ -1242,7 +1242,7 @@ fn validate_selection(files: &[TorrentFileDto], selected_files: &[usize]) -> any
fn validate_inbox_dir(inbox_dir: &str) -> anyhow::Result<PathBuf> { fn validate_inbox_dir(inbox_dir: &str) -> anyhow::Result<PathBuf> {
let trimmed = inbox_dir.trim(); let trimmed = inbox_dir.trim();
let path = PathBuf::from(trimmed); let path = crate::media_paths::resolve_config_path_buf(trimmed);
if !path.is_absolute() { if !path.is_absolute() {
bail!( bail!(
"agent_inbox_dir must be an absolute path for this host, got `{}`", "agent_inbox_dir must be an absolute path for this host, got `{}`",
+114 -34
View File
@@ -38,6 +38,8 @@ const T = {
lastfmDisconnectConfirm: "{{ t.player_lastfm_disconnect_confirm }}", lastfmDisconnectConfirm: "{{ t.player_lastfm_disconnect_confirm }}",
lastfmConnectFailed: "{{ t.player_lastfm_connect_failed }}", lastfmConnectFailed: "{{ t.player_lastfm_connect_failed }}",
lastfmDisconnectFailed: "{{ t.player_lastfm_disconnect_failed }}", lastfmDisconnectFailed: "{{ t.player_lastfm_disconnect_failed }}",
connectionLost: "{{ t.player_connection_lost }}",
connectionLostDetail: "{{ t.player_connection_lost_detail }}",
trackWord: "{{ t.player_tracks_count }}", trackWord: "{{ t.player_tracks_count }}",
clientIdle: "{{ t.player_client_idle }}", clientIdle: "{{ t.player_client_idle }}",
active: "{{ t.player_active }}", active: "{{ t.player_active }}",
@@ -115,6 +117,42 @@ function coverVariantUrl(url, variant) {
} }
document.addEventListener('alpine:init', () => { document.addEventListener('alpine:init', () => {
// -----------------------------------------------------------------------
// Connection monitor
// -----------------------------------------------------------------------
Alpine.store('connection', {
failureCount: 0,
disconnected: false,
threshold: 2,
init() {
if (navigator.onLine === false) {
this.failureCount = this.threshold;
this.disconnected = true;
}
window.addEventListener('online', () => this.recordSuccess());
window.addEventListener('offline', () => this.recordFailure());
},
message() {
return T.connectionLostDetail;
},
recordSuccess() {
this.failureCount = 0;
this.disconnected = false;
},
recordFailure() {
this.failureCount += 1;
if (this.failureCount >= this.threshold) {
this.disconnected = true;
}
},
});
installConnectionFetchMonitor();
// ----------------------------------------------------------------------- // -----------------------------------------------------------------------
// Audio element // Audio element
// ----------------------------------------------------------------------- // -----------------------------------------------------------------------
@@ -174,10 +212,19 @@ document.addEventListener('alpine:init', () => {
lastfmBusy: false, lastfmBusy: false,
init() { init() {
this.cleanLastfmQuery();
this.load(); this.load();
this.loadLastfm(); this.loadLastfm();
}, },
cleanLastfmQuery() {
const url = new URL(window.location.href);
if (!url.searchParams.has('lastfm')) return;
url.searchParams.delete('lastfm');
const clean = `${url.pathname}${url.search}${url.hash}`;
window.history.replaceState({}, document.title, clean || '/');
},
async load() { async load() {
try { try {
const res = await fetch('/api/player/me'); const res = await fetch('/api/player/me');
@@ -356,7 +403,6 @@ document.addEventListener('alpine:init', () => {
_saveTimer: null, _saveTimer: null,
_historyRecorded: false, _historyRecorded: false,
_nowPlayingSent: false, _nowPlayingSent: false,
_scrobbleSent: false,
_playbackStartedAt: null, _playbackStartedAt: null,
_listenedSeconds: 0, _listenedSeconds: 0,
_lastAudioTime: 0, _lastAudioTime: 0,
@@ -369,12 +415,10 @@ document.addEventListener('alpine:init', () => {
this.duration = audio.duration || 0; this.duration = audio.duration || 0;
this.progress = this.duration > 0 ? (this.currentTime / this.duration) * 100 : 0; this.progress = this.duration > 0 ? (this.currentTime / this.duration) * 100 : 0;
this._trackListenedDelta(); this._trackListenedDelta();
this._maybeScrobble();
}); });
audio.addEventListener('ended', () => { audio.addEventListener('ended', () => {
this._trackListenedDelta(); this._trackListenedDelta();
this._maybeScrobble(true);
this._recordHistory(true); this._recordHistory(true);
this.next(); this.next();
}); });
@@ -450,9 +494,13 @@ document.addEventListener('alpine:init', () => {
const queue = Alpine.store('queue'); const queue = Alpine.store('queue');
if (queue.tracks.length === 0) return; if (queue.tracks.length === 0) return;
this._recordHistoryIfListenThresholdReached();
let nextIdx; let nextIdx;
if (this.repeatMode === 'one') { if (this.repeatMode === 'one') {
this.seek(0); this.seek(0);
this._historyRecorded = false;
this._resetPlaybackTracking();
this.resume(); this.resume();
return; return;
} else if (this.shuffle) { } else if (this.shuffle) {
@@ -645,20 +693,33 @@ document.addEventListener('alpine:init', () => {
_recordHistory(completed) { _recordHistory(completed) {
if (this._historyRecorded || !this.currentTrack) return; if (this._historyRecorded || !this.currentTrack) return;
this._historyRecorded = true; this._historyRecorded = true;
const listenedSeconds = this._historyListenedSeconds(completed);
fetch('/api/player/history', { fetch('/api/player/history', {
method: 'POST', method: 'POST',
headers: { 'Content-Type': 'application/json' }, headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({ body: JSON.stringify({
track_id: this.currentTrack.id, track_id: this.currentTrack.id,
duration_listened: Math.floor(this.currentTime), started_at: this._playbackStartedAt,
duration_listened: listenedSeconds,
completed: completed, completed: completed,
}), }),
}).catch(() => {}); }).catch(() => {});
}, },
_recordHistoryIfListenThresholdReached() {
if (this._historyRecorded || !this.currentTrack) return false;
this._trackListenedDelta();
const duration = this._trackDuration();
if (duration <= 0) return false;
const listened = Math.floor(Number(this._listenedSeconds || 0));
const threshold = Math.ceil(duration / 2);
if (threshold <= 0 || listened < threshold) return false;
this._recordHistory(true);
return true;
},
_resetPlaybackTracking() { _resetPlaybackTracking() {
this._nowPlayingSent = false; this._nowPlayingSent = false;
this._scrobbleSent = false;
this._playbackStartedAt = null; this._playbackStartedAt = null;
this._listenedSeconds = 0; this._listenedSeconds = 0;
this._lastAudioTime = 0; this._lastAudioTime = 0;
@@ -696,6 +757,19 @@ document.addEventListener('alpine:init', () => {
return Math.min(duration / 2, 240); return Math.min(duration / 2, 240);
}, },
_historyListenedSeconds(completed) {
const duration = this._trackDuration();
const listened = Number(this._listenedSeconds || 0);
const finalGrace = completed ? 1 : 0;
const precise = Math.floor(listened + finalGrace);
if (precise > 0) return precise;
const current = Number(audio.currentTime || this.currentTime || 0);
if (duration > 0 && Number.isFinite(current)) {
return Math.floor(Math.min(current, duration));
}
return Math.floor(current || 0);
},
_sendNowPlaying() { _sendNowPlaying() {
if (this._nowPlayingSent || !this.currentTrack) return; if (this._nowPlayingSent || !this.currentTrack) return;
const lastfm = Alpine.store('user')?.lastfm; const lastfm = Alpine.store('user')?.lastfm;
@@ -707,35 +781,6 @@ document.addEventListener('alpine:init', () => {
body: JSON.stringify({ track_id: this.currentTrack.id }), body: JSON.stringify({ track_id: this.currentTrack.id }),
}).catch(() => {}); }).catch(() => {});
}, },
_maybeScrobble(force = false) {
if (this._scrobbleSent || !this.currentTrack) return;
const lastfm = Alpine.store('user')?.lastfm;
if (!lastfm?.configured || !lastfm?.connected || lastfm?.reauth_required) return;
const duration = this._trackDuration();
if (!duration || duration <= 30) return;
const threshold = this._scrobbleThreshold(duration);
const listened = force ? this._listenedSeconds + 1 : this._listenedSeconds;
if (listened < threshold) return;
this._listenedSeconds = Math.max(this._listenedSeconds, listened);
this._sendScrobble();
},
_sendScrobble() {
if (this._scrobbleSent || !this.currentTrack) return;
this._scrobbleSent = true;
fetch('/api/player/lastfm/scrobble', {
method: 'POST',
headers: { 'Content-Type': 'application/json' },
body: JSON.stringify({
track_id: this.currentTrack.id,
started_at: this._playbackStartedAt || Math.floor(Date.now() / 1000),
listened_seconds: Math.floor(this._listenedSeconds),
}),
}).catch(() => {
this._scrobbleSent = false;
});
},
}); });
// ----------------------------------------------------------------------- // -----------------------------------------------------------------------
@@ -2312,4 +2357,39 @@ document.addEventListener('alpine:init', () => {
}, },
}); });
}); });
function installConnectionFetchMonitor() {
if (window.__furumusicConnectionMonitorInstalled || !window.fetch) return;
window.__furumusicConnectionMonitorInstalled = true;
const nativeFetch = window.fetch.bind(window);
window.fetch = async (...args) => {
const tracked = isTrackedPlayerRequest(args[0]);
try {
const response = await nativeFetch(...args);
if (tracked) {
if (response.status >= 500) {
Alpine.store('connection')?.recordFailure();
} else {
Alpine.store('connection')?.recordSuccess();
}
}
return response;
} catch (error) {
if (tracked) Alpine.store('connection')?.recordFailure();
throw error;
}
};
}
function isTrackedPlayerRequest(input) {
const rawUrl = typeof input === 'string' ? input : input?.url;
if (!rawUrl) return false;
try {
const url = new URL(rawUrl, window.location.href);
return url.origin === window.location.origin && url.pathname.startsWith('/api/player/');
} catch {
return false;
}
}
</script> </script>
+14
View File
@@ -275,6 +275,20 @@
<path d="M4 4.5A2.5 2.5 0 016.5 2H20v20H6.5A2.5 2.5 0 014 19.5z"/> <path d="M4 4.5A2.5 2.5 0 016.5 2H20v20H6.5A2.5 2.5 0 014 19.5z"/>
</svg> </svg>
</button> </button>
<div class="connection-alert"
x-show="$store.connection.disconnected"
x-cloak
:title="$store.connection.message()"
role="status"
aria-live="polite">
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2">
<path d="M2 8.82a15 15 0 0120 0"/>
<path d="M5 12.86a10 10 0 0114 0"/>
<path d="M8.5 16.43a5 5 0 017 0"/>
<line x1="2" y1="2" x2="22" y2="22"/>
</svg>
<span class="connection-alert-text">{{ t.player_connection_lost }}</span>
</div>
<div class="search-bar"> <div class="search-bar">
<span class="search-icon"><svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"><circle cx="11" cy="11" r="8"/><line x1="21" y1="21" x2="16.65" y2="16.65"/></svg></span> <span class="search-icon"><svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"><circle cx="11" cy="11" r="8"/><line x1="21" y1="21" x2="16.65" y2="16.65"/></svg></span>
<input id="search-input" type="text" placeholder="{{ t.player_search_placeholder }}" <input id="search-input" type="text" placeholder="{{ t.player_search_placeholder }}"
+40
View File
@@ -1377,6 +1377,37 @@ button.user-stat:hover {
margin-bottom: 20px; margin-bottom: 20px;
} }
.connection-alert {
flex: 0 0 auto;
min-width: 42px;
height: 42px;
padding: 0 12px;
border: 1px solid rgba(248, 113, 113, 0.34);
border-radius: 8px;
background: rgba(127, 29, 29, 0.2);
color: #f87171;
display: flex;
align-items: center;
justify-content: center;
gap: 8px;
}
.connection-alert svg {
width: 18px;
height: 18px;
flex: 0 0 auto;
}
.connection-alert-text {
min-width: 0;
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
color: #fecaca;
font-size: 12px;
font-weight: 700;
}
/* Search bar */ /* Search bar */
.search-bar { .search-bar {
position: relative; position: relative;
@@ -2676,6 +2707,15 @@ button.user-stat:hover {
flex: 1 1 auto; flex: 1 1 auto;
} }
.connection-alert {
width: 42px;
padding: 0;
}
.connection-alert-text {
display: none;
}
.mobile-library-btn { .mobile-library-btn {
display: flex; display: flex;
} }