Compare commits
1 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| c43ee02b00 |
Generated
+1
-1
@@ -1418,7 +1418,7 @@ checksum = "e6d5a32815ae3f33302d95fdcb2ce17862f8c65363dcfd29360480ba1001fc9c"
|
|||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
name = "furumusic"
|
name = "furumusic"
|
||||||
version = "0.1.21"
|
version = "0.1.22"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
"anyhow",
|
"anyhow",
|
||||||
"async-trait",
|
"async-trait",
|
||||||
|
|||||||
+1
-1
@@ -1,6 +1,6 @@
|
|||||||
[package]
|
[package]
|
||||||
name = "furumusic"
|
name = "furumusic"
|
||||||
version = "0.1.22"
|
version = "0.2.0"
|
||||||
edition = "2024"
|
edition = "2024"
|
||||||
description = "Reusable web-app boilerplate: auth, OIDC/SSO, admin panel, user management, i18n, PostgreSQL"
|
description = "Reusable web-app boilerplate: auth, OIDC/SSO, admin panel, user management, i18n, PostgreSQL"
|
||||||
|
|
||||||
|
|||||||
@@ -338,12 +338,7 @@ pub async fn save_cover_to_storage(
|
|||||||
.fetch_optional(pool)
|
.fetch_optional(pool)
|
||||||
.await?
|
.await?
|
||||||
{
|
{
|
||||||
let path = PathBuf::from(&file_path);
|
let path = crate::media_paths::resolve_media_file_path(storage_dir, &file_path);
|
||||||
let path = if path.is_absolute() {
|
|
||||||
path
|
|
||||||
} else {
|
|
||||||
Path::new(storage_dir).join(path)
|
|
||||||
};
|
|
||||||
if let Err(err) = crate::agent::cover_variants::ensure_cover_variants(&path).await {
|
if let Err(err) = crate::agent::cover_variants::ensure_cover_variants(&path).await {
|
||||||
tracing::warn!(media_file_id = id, error = %err, "Failed to generate cover variants");
|
tracing::warn!(media_file_id = id, error = %err, "Failed to generate cover variants");
|
||||||
}
|
}
|
||||||
@@ -365,7 +360,13 @@ pub async fn save_cover_to_storage(
|
|||||||
// Write image data
|
// Write image data
|
||||||
tokio::fs::write(&dest_path, &cover.data).await?;
|
tokio::fs::write(&dest_path, &cover.data).await?;
|
||||||
|
|
||||||
let relative_path = dest_path.to_string_lossy().to_string();
|
let relative_path = crate::media_paths::media_file_path_for_storage(storage_dir, &dest_path)
|
||||||
|
.ok_or_else(|| {
|
||||||
|
anyhow::anyhow!(
|
||||||
|
"cover destination is outside agent_storage_dir: {}",
|
||||||
|
dest_path.display()
|
||||||
|
)
|
||||||
|
})?;
|
||||||
let file_size = cover.data.len() as i64;
|
let file_size = cover.data.len() as i64;
|
||||||
|
|
||||||
let media_file = crate::music::MediaFile::create(
|
let media_file = crate::music::MediaFile::create(
|
||||||
|
|||||||
+20
-48
@@ -329,8 +329,8 @@ impl_env_overrides!(
|
|||||||
|
|
||||||
impl AppConfig {
|
impl AppConfig {
|
||||||
fn normalize_host_paths(&mut self) {
|
fn normalize_host_paths(&mut self) {
|
||||||
self.agent_inbox_dir = normalize_host_path(&self.agent_inbox_dir);
|
self.agent_inbox_dir = crate::media_paths::resolve_config_path(&self.agent_inbox_dir);
|
||||||
self.agent_storage_dir = normalize_host_path(&self.agent_storage_dir);
|
self.agent_storage_dir = crate::media_paths::resolve_config_path(&self.agent_storage_dir);
|
||||||
}
|
}
|
||||||
|
|
||||||
/// Build config: start from defaults, then overlay env vars.
|
/// Build config: start from defaults, then overlay env vars.
|
||||||
@@ -413,44 +413,6 @@ impl AppConfig {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn normalize_host_path(value: &str) -> String {
|
|
||||||
let trimmed = value.trim();
|
|
||||||
if trimmed.is_empty() {
|
|
||||||
return String::new();
|
|
||||||
}
|
|
||||||
|
|
||||||
normalize_windows_user_path(trimmed).unwrap_or_else(|| trimmed.to_owned())
|
|
||||||
}
|
|
||||||
|
|
||||||
#[cfg(not(windows))]
|
|
||||||
fn normalize_windows_user_path(value: &str) -> Option<String> {
|
|
||||||
let normalized = value.replace('\\', "/");
|
|
||||||
let mut parts = normalized.split('/').filter(|part| !part.is_empty());
|
|
||||||
let drive = parts.next()?;
|
|
||||||
if drive.len() != 2 || !drive.ends_with(':') {
|
|
||||||
return None;
|
|
||||||
}
|
|
||||||
if !parts.next()?.eq_ignore_ascii_case("Users") {
|
|
||||||
return None;
|
|
||||||
}
|
|
||||||
let user = parts.next()?;
|
|
||||||
if user.is_empty() {
|
|
||||||
return None;
|
|
||||||
}
|
|
||||||
|
|
||||||
let mut out = format!("/Users/{user}");
|
|
||||||
for part in parts {
|
|
||||||
out.push('/');
|
|
||||||
out.push_str(part);
|
|
||||||
}
|
|
||||||
Some(out)
|
|
||||||
}
|
|
||||||
|
|
||||||
#[cfg(windows)]
|
|
||||||
fn normalize_windows_user_path(_value: &str) -> Option<String> {
|
|
||||||
None
|
|
||||||
}
|
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::*;
|
use super::*;
|
||||||
@@ -462,21 +424,31 @@ mod tests {
|
|||||||
assert_eq!(cfg.log_level, "info");
|
assert_eq!(cfg.log_level, "info");
|
||||||
}
|
}
|
||||||
|
|
||||||
#[cfg(not(windows))]
|
|
||||||
#[test]
|
#[test]
|
||||||
fn normalizes_windows_user_path_on_unix() {
|
fn resolves_relative_media_paths_from_working_dir() {
|
||||||
|
let expected = std::env::current_dir()
|
||||||
|
.unwrap()
|
||||||
|
.join("media")
|
||||||
|
.join("uploads")
|
||||||
|
.to_string_lossy()
|
||||||
|
.to_string();
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
normalize_host_path(r"C:\Users\ab\repos\furumusic\media\uploads"),
|
crate::media_paths::resolve_config_path("media/uploads"),
|
||||||
"/Users/ab/repos/furumusic/media/uploads"
|
expected
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[cfg(not(windows))]
|
|
||||||
#[test]
|
#[test]
|
||||||
fn leaves_unix_path_unchanged() {
|
fn maps_foreign_windows_media_paths_to_working_dir() {
|
||||||
|
let expected = std::env::current_dir()
|
||||||
|
.unwrap()
|
||||||
|
.join("media")
|
||||||
|
.join("uploads")
|
||||||
|
.to_string_lossy()
|
||||||
|
.to_string();
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
normalize_host_path("/Users/ab/repos/furumusic/media/uploads"),
|
crate::media_paths::resolve_config_path(r"C:\Users\ab\repos\furumusic\media\uploads"),
|
||||||
"/Users/ab/repos/furumusic/media/uploads"
|
expected
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -296,6 +296,8 @@ translations! {
|
|||||||
player_likes_playlist: "Likes" , "Лайки";
|
player_likes_playlist: "Likes" , "Лайки";
|
||||||
player_listened: "listened" , "прослушано";
|
player_listened: "listened" , "прослушано";
|
||||||
player_search_placeholder: "Search artists, releases, tracks..." , "Поиск артистов, релизов, треков...";
|
player_search_placeholder: "Search artists, releases, tracks..." , "Поиск артистов, релизов, треков...";
|
||||||
|
player_connection_lost: "Server connection lost" , "Нет соединения с сервером";
|
||||||
|
player_connection_lost_detail: "Player cannot reach the server. Retrying..." , "Плеер не может связаться с сервером. Повторяю...";
|
||||||
player_no_results: "No results found" , "Ничего не найдено";
|
player_no_results: "No results found" , "Ничего не найдено";
|
||||||
player_new_playlist: "New Playlist" , "Новый плейлист";
|
player_new_playlist: "New Playlist" , "Новый плейлист";
|
||||||
player_rename_playlist: "Rename Playlist" , "Переименовать плейлист";
|
player_rename_playlist: "Rename Playlist" , "Переименовать плейлист";
|
||||||
|
|||||||
@@ -1,4 +1,4 @@
|
|||||||
use std::path::{Path, PathBuf};
|
use std::path::PathBuf;
|
||||||
|
|
||||||
use reqwest::Client;
|
use reqwest::Client;
|
||||||
use serde::Deserialize;
|
use serde::Deserialize;
|
||||||
@@ -40,34 +40,6 @@ struct LastfmArtistResponse {
|
|||||||
message: Option<String>,
|
message: Option<String>,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Deserialize)]
|
|
||||||
struct LastfmTopAlbumsResponse {
|
|
||||||
topalbums: Option<LastfmTopAlbums>,
|
|
||||||
error: Option<i32>,
|
|
||||||
message: Option<String>,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, Deserialize)]
|
|
||||||
struct LastfmTopAlbums {
|
|
||||||
album: Option<OneOrMany<LastfmImageContainer>>,
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, Deserialize)]
|
|
||||||
#[serde(untagged)]
|
|
||||||
enum OneOrMany<T> {
|
|
||||||
One(T),
|
|
||||||
Many(Vec<T>),
|
|
||||||
}
|
|
||||||
|
|
||||||
impl<T> OneOrMany<T> {
|
|
||||||
fn into_vec(self) -> Vec<T> {
|
|
||||||
match self {
|
|
||||||
Self::One(value) => vec![value],
|
|
||||||
Self::Many(values) => values,
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
#[derive(Debug, Deserialize)]
|
#[derive(Debug, Deserialize)]
|
||||||
struct LastfmImageContainer {
|
struct LastfmImageContainer {
|
||||||
image: Option<Vec<LastfmImage>>,
|
image: Option<Vec<LastfmImage>>,
|
||||||
@@ -88,6 +60,7 @@ struct ArtworkStats {
|
|||||||
release_skipped_no_audio: u64,
|
release_skipped_no_audio: u64,
|
||||||
artist_lastfm_assigned: u64,
|
artist_lastfm_assigned: u64,
|
||||||
artist_lastfm_not_found: u64,
|
artist_lastfm_not_found: u64,
|
||||||
|
artist_album_fallback_assigned: u64,
|
||||||
variants_created: usize,
|
variants_created: usize,
|
||||||
variants_unchanged: usize,
|
variants_unchanged: usize,
|
||||||
variants_missing_original: usize,
|
variants_missing_original: usize,
|
||||||
@@ -125,6 +98,16 @@ impl Job for ArtworkBackfillJob {
|
|||||||
.build()?;
|
.build()?;
|
||||||
let mut stats = ArtworkStats::default();
|
let mut stats = ArtworkStats::default();
|
||||||
|
|
||||||
|
let normalized_paths =
|
||||||
|
crate::media_paths::normalize_media_file_paths(&ctx.pool, storage_dir).await?;
|
||||||
|
if normalized_paths > 0 {
|
||||||
|
log.info(&format!(
|
||||||
|
"Media path normalization pass: rewrote {normalized_paths} media file path(s) to relative storage paths"
|
||||||
|
));
|
||||||
|
} else {
|
||||||
|
log.info("Media path normalization pass: all media file paths are already relative");
|
||||||
|
}
|
||||||
|
|
||||||
backfill_release_local(ctx, log, storage_dir, &mut stats).await?;
|
backfill_release_local(ctx, log, storage_dir, &mut stats).await?;
|
||||||
|
|
||||||
let api_key = ctx.config.lastfm_api_key.trim();
|
let api_key = ctx.config.lastfm_api_key.trim();
|
||||||
@@ -138,13 +121,14 @@ impl Job for ArtworkBackfillJob {
|
|||||||
repair_cover_variants(ctx, log, storage_dir, &mut stats).await?;
|
repair_cover_variants(ctx, log, storage_dir, &mut stats).await?;
|
||||||
|
|
||||||
log.info(&format!(
|
log.info(&format!(
|
||||||
"Artwork backfill complete: release_local_assigned={}, release_lastfm_assigned={}, release_lastfm_not_found={}, release_skipped_no_audio={}, artist_lastfm_assigned={}, artist_lastfm_not_found={}, variants_created={}, variants_unchanged={}, variants_missing_original={}, failed={}",
|
"Artwork backfill complete: release_local_assigned={}, release_lastfm_assigned={}, release_lastfm_not_found={}, release_skipped_no_audio={}, artist_lastfm_assigned={}, artist_lastfm_not_found={}, artist_album_fallback_assigned={}, variants_created={}, variants_unchanged={}, variants_missing_original={}, failed={}",
|
||||||
stats.release_local_assigned,
|
stats.release_local_assigned,
|
||||||
stats.release_lastfm_assigned,
|
stats.release_lastfm_assigned,
|
||||||
stats.release_lastfm_not_found,
|
stats.release_lastfm_not_found,
|
||||||
stats.release_skipped_no_audio,
|
stats.release_skipped_no_audio,
|
||||||
stats.artist_lastfm_assigned,
|
stats.artist_lastfm_assigned,
|
||||||
stats.artist_lastfm_not_found,
|
stats.artist_lastfm_not_found,
|
||||||
|
stats.artist_album_fallback_assigned,
|
||||||
stats.variants_created,
|
stats.variants_created,
|
||||||
stats.variants_unchanged,
|
stats.variants_unchanged,
|
||||||
stats.variants_missing_original,
|
stats.variants_missing_original,
|
||||||
@@ -221,7 +205,7 @@ async fn backfill_release_local(
|
|||||||
|
|
||||||
let audio_files: Vec<PathBuf> = audio_paths
|
let audio_files: Vec<PathBuf> = audio_paths
|
||||||
.iter()
|
.iter()
|
||||||
.map(|path| resolve_media_path(storage_dir, path))
|
.map(|path| crate::media_paths::resolve_media_file_path(storage_dir, path))
|
||||||
.collect();
|
.collect();
|
||||||
let Some(folder) = audio_files.first().and_then(|path| path.parent()) else {
|
let Some(folder) = audio_files.first().and_then(|path| path.parent()) else {
|
||||||
stats.failed += 1;
|
stats.failed += 1;
|
||||||
@@ -605,13 +589,35 @@ async fn backfill_artist_lastfm(
|
|||||||
}
|
}
|
||||||
},
|
},
|
||||||
Ok(None) => {
|
Ok(None) => {
|
||||||
stats.artist_lastfm_not_found += 1;
|
|
||||||
record_lookup_state(&ctx.pool, "artist", artist.id, "not_found", None, None)
|
record_lookup_state(&ctx.pool, "artist", artist.id, "not_found", None, None)
|
||||||
.await?;
|
.await?;
|
||||||
log.info(&format!(
|
log.info(&format!(
|
||||||
"Artist {} \"{}\": Last.fm did not return artwork",
|
"Artist {} \"{}\": Last.fm did not return artwork",
|
||||||
artist.id, artist.name
|
artist.id, artist.name
|
||||||
));
|
));
|
||||||
|
stats.artist_lastfm_not_found += 1;
|
||||||
|
match assign_artist_album_fallback(ctx, artist.id).await {
|
||||||
|
Ok(Some(media_file_id)) => {
|
||||||
|
stats.artist_album_fallback_assigned += 1;
|
||||||
|
log.info(&format!(
|
||||||
|
"Artist {} \"{}\": assigned random local album cover (media_file_id={media_file_id})",
|
||||||
|
artist.id, artist.name
|
||||||
|
));
|
||||||
|
}
|
||||||
|
Ok(None) => {
|
||||||
|
log.info(&format!(
|
||||||
|
"Artist {} \"{}\": no local album cover available for fallback",
|
||||||
|
artist.id, artist.name
|
||||||
|
));
|
||||||
|
}
|
||||||
|
Err(err) => {
|
||||||
|
stats.failed += 1;
|
||||||
|
log.warn(&format!(
|
||||||
|
"Artist {} \"{}\": failed to assign album fallback artwork: {err}",
|
||||||
|
artist.id, artist.name
|
||||||
|
));
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
Err(err) if err.to_string().contains("rate limit") => {
|
Err(err) if err.to_string().contains("rate limit") => {
|
||||||
stats.failed += 1;
|
stats.failed += 1;
|
||||||
@@ -675,7 +681,7 @@ async fn repair_cover_variants(
|
|||||||
));
|
));
|
||||||
|
|
||||||
for (media_file_id, file_path) in rows {
|
for (media_file_id, file_path) in rows {
|
||||||
let path = resolve_media_path(storage_dir, &file_path);
|
let path = crate::media_paths::resolve_media_file_path(storage_dir, &file_path);
|
||||||
if !path.exists() {
|
if !path.exists() {
|
||||||
stats.variants_missing_original += 1;
|
stats.variants_missing_original += 1;
|
||||||
log.warn(&format!(
|
log.warn(&format!(
|
||||||
@@ -705,6 +711,59 @@ async fn repair_cover_variants(
|
|||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
|
async fn assign_artist_album_fallback(
|
||||||
|
ctx: &JobContext,
|
||||||
|
artist_id: i64,
|
||||||
|
) -> anyhow::Result<Option<i64>> {
|
||||||
|
let media_file_id: Option<i64> = sqlx::query_scalar(
|
||||||
|
r#"SELECT media_file_id
|
||||||
|
FROM (
|
||||||
|
SELECT DISTINCT r.cover_file_id AS media_file_id
|
||||||
|
FROM furumusic__release r
|
||||||
|
JOIN furumusic__release_artist ra ON ra.release_id = r.id
|
||||||
|
WHERE ra.artist_id = $1
|
||||||
|
AND r.cover_file_id IS NOT NULL
|
||||||
|
AND r.is_hidden = false
|
||||||
|
UNION
|
||||||
|
SELECT DISTINCT r.cover_file_id AS media_file_id
|
||||||
|
FROM furumusic__release r
|
||||||
|
JOIN furumusic__track t ON t.release_id = r.id
|
||||||
|
JOIN furumusic__track_artist ta ON ta.track_id = t.id
|
||||||
|
WHERE ta.artist_id = $1
|
||||||
|
AND r.cover_file_id IS NOT NULL
|
||||||
|
AND r.is_hidden = false
|
||||||
|
) covers
|
||||||
|
ORDER BY random()
|
||||||
|
LIMIT 1"#,
|
||||||
|
)
|
||||||
|
.bind(artist_id)
|
||||||
|
.fetch_optional(&ctx.pool)
|
||||||
|
.await?;
|
||||||
|
|
||||||
|
let Some(media_file_id) = media_file_id else {
|
||||||
|
return Ok(None);
|
||||||
|
};
|
||||||
|
|
||||||
|
let result = sqlx::query(
|
||||||
|
r#"UPDATE furumusic__artist
|
||||||
|
SET image_file_id = $1,
|
||||||
|
updated_at = $3
|
||||||
|
WHERE id = $2
|
||||||
|
AND image_file_id IS NULL"#,
|
||||||
|
)
|
||||||
|
.bind(media_file_id)
|
||||||
|
.bind(artist_id)
|
||||||
|
.bind(now_iso())
|
||||||
|
.execute(&ctx.pool)
|
||||||
|
.await?;
|
||||||
|
|
||||||
|
if result.rows_affected() == 0 {
|
||||||
|
Ok(None)
|
||||||
|
} else {
|
||||||
|
Ok(Some(media_file_id))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
async fn fetch_lastfm_album_image(
|
async fn fetch_lastfm_album_image(
|
||||||
client: &Client,
|
client: &Client,
|
||||||
api_key: &str,
|
api_key: &str,
|
||||||
@@ -772,57 +831,9 @@ async fn fetch_lastfm_artist_image(
|
|||||||
parsed.message.unwrap_or_default()
|
parsed.message.unwrap_or_default()
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
if let Some(url) = parsed
|
Ok(parsed
|
||||||
.artist
|
.artist
|
||||||
.and_then(|artist| choose_best_image(artist.image))
|
.and_then(|artist| choose_best_image(artist.image)))
|
||||||
{
|
|
||||||
return Ok(Some(url));
|
|
||||||
}
|
|
||||||
|
|
||||||
fetch_lastfm_artist_top_album_image(client, api_key, artist).await
|
|
||||||
}
|
|
||||||
|
|
||||||
async fn fetch_lastfm_artist_top_album_image(
|
|
||||||
client: &Client,
|
|
||||||
api_key: &str,
|
|
||||||
artist: &str,
|
|
||||||
) -> anyhow::Result<Option<String>> {
|
|
||||||
let response = client
|
|
||||||
.get("https://ws.audioscrobbler.com/2.0/")
|
|
||||||
.query(&[
|
|
||||||
("method", "artist.getTopAlbums"),
|
|
||||||
("api_key", api_key),
|
|
||||||
("artist", artist),
|
|
||||||
("autocorrect", "1"),
|
|
||||||
("limit", "10"),
|
|
||||||
("format", "json"),
|
|
||||||
])
|
|
||||||
.send()
|
|
||||||
.await?;
|
|
||||||
let body = response.text().await?;
|
|
||||||
let parsed: LastfmTopAlbumsResponse = serde_json::from_str(&body)?;
|
|
||||||
if let Some(code) = parsed.error {
|
|
||||||
if code == 6 || code == 7 {
|
|
||||||
return Ok(None);
|
|
||||||
}
|
|
||||||
if code == 29 {
|
|
||||||
anyhow::bail!("Last.fm rate limit exceeded");
|
|
||||||
}
|
|
||||||
anyhow::bail!(
|
|
||||||
"Last.fm API error {code}: {}",
|
|
||||||
parsed.message.unwrap_or_default()
|
|
||||||
);
|
|
||||||
}
|
|
||||||
|
|
||||||
let albums = parsed
|
|
||||||
.topalbums
|
|
||||||
.and_then(|topalbums| topalbums.album)
|
|
||||||
.map(OneOrMany::into_vec)
|
|
||||||
.unwrap_or_default();
|
|
||||||
Ok(albums
|
|
||||||
.into_iter()
|
|
||||||
.filter_map(|album| choose_best_image(album.image))
|
|
||||||
.next())
|
|
||||||
}
|
}
|
||||||
|
|
||||||
fn choose_best_image(images: Option<Vec<LastfmImage>>) -> Option<String> {
|
fn choose_best_image(images: Option<Vec<LastfmImage>>) -> Option<String> {
|
||||||
@@ -943,15 +954,6 @@ fn cover_source_description(source: &CoverSource) -> String {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn resolve_media_path(storage_dir: &str, file_path: &str) -> PathBuf {
|
|
||||||
let path = PathBuf::from(file_path);
|
|
||||||
if path.is_absolute() {
|
|
||||||
path
|
|
||||||
} else {
|
|
||||||
Path::new(storage_dir).join(path)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
fn cutoff_iso(days: i64) -> String {
|
fn cutoff_iso(days: i64) -> String {
|
||||||
(chrono::Utc::now() - chrono::Duration::days(days))
|
(chrono::Utc::now() - chrono::Duration::days(days))
|
||||||
.format("%Y-%m-%dT%H:%M:%SZ")
|
.format("%Y-%m-%dT%H:%M:%SZ")
|
||||||
|
|||||||
@@ -798,16 +798,29 @@ pub async fn finalize_approved(
|
|||||||
)
|
)
|
||||||
.await?
|
.await?
|
||||||
{
|
{
|
||||||
mover::MoveOutcome::Moved(p) => p.to_string_lossy().to_string(),
|
mover::MoveOutcome::Moved(p) | mover::MoveOutcome::Merged(p) => {
|
||||||
mover::MoveOutcome::Merged(p) => p.to_string_lossy().to_string(),
|
crate::media_paths::media_file_path_for_storage(storage_dir_str, &p).ok_or_else(
|
||||||
|
|| {
|
||||||
|
anyhow::anyhow!(
|
||||||
|
"storage destination is outside agent_storage_dir: {}",
|
||||||
|
p.display()
|
||||||
|
)
|
||||||
|
},
|
||||||
|
)?
|
||||||
|
}
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
storage_dir
|
let expected_path = storage_dir
|
||||||
.join(sanitize_filename(artist_name))
|
.join(sanitize_filename(artist_name))
|
||||||
.join(sanitize_filename(release_title))
|
.join(sanitize_filename(release_title))
|
||||||
.join(&dest_filename)
|
.join(&dest_filename);
|
||||||
.to_string_lossy()
|
crate::media_paths::media_file_path_for_storage(storage_dir_str, &expected_path)
|
||||||
.to_string()
|
.ok_or_else(|| {
|
||||||
|
anyhow::anyhow!(
|
||||||
|
"storage destination is outside agent_storage_dir: {}",
|
||||||
|
expected_path.display()
|
||||||
|
)
|
||||||
|
})?
|
||||||
};
|
};
|
||||||
|
|
||||||
let media_file = MediaFile::create(
|
let media_file = MediaFile::create(
|
||||||
|
|||||||
@@ -1,5 +1,3 @@
|
|||||||
use std::path::{Path, PathBuf};
|
|
||||||
|
|
||||||
use crate::scheduler::{Job, JobContext, JobLog};
|
use crate::scheduler::{Job, JobContext, JobLog};
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy)]
|
#[derive(Debug, Clone, Copy)]
|
||||||
@@ -104,11 +102,15 @@ pub async fn run_with_options(
|
|||||||
|
|
||||||
for row in rows {
|
for row in rows {
|
||||||
scanned += 1;
|
scanned += 1;
|
||||||
let Some(path) = resolve_media_path(&row.file_path, &ctx.config.agent_storage_dir) else {
|
let path = crate::media_paths::resolve_media_file_path(
|
||||||
|
&ctx.config.agent_storage_dir,
|
||||||
|
&row.file_path,
|
||||||
|
);
|
||||||
|
if !path.exists() {
|
||||||
missing += 1;
|
missing += 1;
|
||||||
log.warn(&format!("missing file: {}", row.file_path));
|
log.warn(&format!("missing file: {}", row.file_path));
|
||||||
continue;
|
continue;
|
||||||
};
|
}
|
||||||
|
|
||||||
let extract_path = path.clone();
|
let extract_path = path.clone();
|
||||||
let raw_meta = match tokio::task::spawn_blocking(move || {
|
let raw_meta = match tokio::task::spawn_blocking(move || {
|
||||||
@@ -218,17 +220,3 @@ fn should_update<T>(current: Option<T>, overwrite: bool) -> bool {
|
|||||||
fn should_update_duration(current: Option<f64>, overwrite: bool) -> bool {
|
fn should_update_duration(current: Option<f64>, overwrite: bool) -> bool {
|
||||||
overwrite || current.unwrap_or(0.0) <= 0.0
|
overwrite || current.unwrap_or(0.0) <= 0.0
|
||||||
}
|
}
|
||||||
|
|
||||||
fn resolve_media_path(file_path: &str, storage_dir: &str) -> Option<PathBuf> {
|
|
||||||
let path = Path::new(file_path);
|
|
||||||
if path.exists() {
|
|
||||||
return Some(path.to_path_buf());
|
|
||||||
}
|
|
||||||
if path.is_relative() && !storage_dir.is_empty() {
|
|
||||||
let joined = Path::new(storage_dir).join(path);
|
|
||||||
if joined.exists() {
|
|
||||||
return Some(joined);
|
|
||||||
}
|
|
||||||
}
|
|
||||||
None
|
|
||||||
}
|
|
||||||
|
|||||||
@@ -6,6 +6,7 @@ mod config;
|
|||||||
mod i18n;
|
mod i18n;
|
||||||
mod jobs;
|
mod jobs;
|
||||||
mod lastfm;
|
mod lastfm;
|
||||||
|
mod media_paths;
|
||||||
mod music;
|
mod music;
|
||||||
mod oidc;
|
mod oidc;
|
||||||
mod player;
|
mod player;
|
||||||
|
|||||||
@@ -0,0 +1,310 @@
|
|||||||
|
use std::path::{Component, Path, PathBuf};
|
||||||
|
|
||||||
|
const KNOWN_MEDIA_ROOTS: &[&str] = &["media/library", "media/uploads"];
|
||||||
|
|
||||||
|
pub fn resolve_config_path(value: &str) -> String {
|
||||||
|
let path = resolve_config_path_buf(value);
|
||||||
|
if path.as_os_str().is_empty() {
|
||||||
|
String::new()
|
||||||
|
} else {
|
||||||
|
path.to_string_lossy().to_string()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn resolve_config_path_buf(value: &str) -> PathBuf {
|
||||||
|
let trimmed = value.trim();
|
||||||
|
if trimmed.is_empty() {
|
||||||
|
return PathBuf::new();
|
||||||
|
}
|
||||||
|
|
||||||
|
let normalized = normalize_slashes(trimmed);
|
||||||
|
if is_host_absolute(&normalized) {
|
||||||
|
return PathBuf::from(normalized);
|
||||||
|
}
|
||||||
|
|
||||||
|
if looks_like_windows_absolute(&normalized) {
|
||||||
|
if let Some(relative) = extract_known_media_root(&normalized) {
|
||||||
|
return app_root().join(slash_path(&relative));
|
||||||
|
}
|
||||||
|
return PathBuf::from(normalized);
|
||||||
|
}
|
||||||
|
|
||||||
|
app_root().join(slash_path(&normalized))
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn resolve_media_file_path(storage_dir: &str, file_path: &str) -> PathBuf {
|
||||||
|
let storage_root = resolve_config_path_buf(storage_dir);
|
||||||
|
if let Some(relative) = normalize_stored_media_file_path(storage_dir, file_path) {
|
||||||
|
return storage_root.join(slash_path(&relative));
|
||||||
|
}
|
||||||
|
|
||||||
|
let normalized = normalize_slashes(file_path.trim());
|
||||||
|
let path = PathBuf::from(&normalized);
|
||||||
|
if path.is_absolute() {
|
||||||
|
path
|
||||||
|
} else {
|
||||||
|
storage_root.join(path)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn media_file_path_for_storage(storage_dir: &str, path: &Path) -> Option<String> {
|
||||||
|
let storage_root = resolve_config_path_buf(storage_dir);
|
||||||
|
if let Ok(relative) = path.strip_prefix(&storage_root) {
|
||||||
|
return relative_path_string(relative);
|
||||||
|
}
|
||||||
|
|
||||||
|
let normalized = normalize_slashes(&path.to_string_lossy());
|
||||||
|
relative_after_storage_marker(&storage_root, &normalized).or_else(|| {
|
||||||
|
if !is_host_absolute(&normalized) && !looks_like_windows_absolute(&normalized) {
|
||||||
|
normalize_relative_path(&normalized)
|
||||||
|
} else {
|
||||||
|
None
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn normalize_stored_media_file_path(storage_dir: &str, file_path: &str) -> Option<String> {
|
||||||
|
let trimmed = file_path.trim();
|
||||||
|
if trimmed.is_empty() {
|
||||||
|
return None;
|
||||||
|
}
|
||||||
|
|
||||||
|
let storage_root = resolve_config_path_buf(storage_dir);
|
||||||
|
let normalized = normalize_slashes(trimmed);
|
||||||
|
let path = PathBuf::from(&normalized);
|
||||||
|
if path.is_absolute() {
|
||||||
|
if let Ok(relative) = path.strip_prefix(&storage_root) {
|
||||||
|
return relative_path_string(relative);
|
||||||
|
}
|
||||||
|
return relative_after_storage_marker(&storage_root, &normalized);
|
||||||
|
}
|
||||||
|
|
||||||
|
if looks_like_windows_absolute(&normalized) {
|
||||||
|
return relative_after_storage_marker(&storage_root, &normalized);
|
||||||
|
}
|
||||||
|
|
||||||
|
if let Some(relative) = relative_after_storage_marker_prefix(&storage_root, &normalized) {
|
||||||
|
return Some(relative);
|
||||||
|
}
|
||||||
|
|
||||||
|
normalize_relative_path(&normalized)
|
||||||
|
}
|
||||||
|
|
||||||
|
pub async fn normalize_media_file_paths(
|
||||||
|
pool: &sqlx::PgPool,
|
||||||
|
storage_dir: &str,
|
||||||
|
) -> anyhow::Result<u64> {
|
||||||
|
let rows: Vec<(i64, String)> =
|
||||||
|
sqlx::query_as("SELECT id, file_path FROM furumusic__media_file ORDER BY id")
|
||||||
|
.fetch_all(pool)
|
||||||
|
.await?;
|
||||||
|
|
||||||
|
let mut updated = 0;
|
||||||
|
for (id, file_path) in rows {
|
||||||
|
let Some(relative) = normalize_stored_media_file_path(storage_dir, &file_path) else {
|
||||||
|
continue;
|
||||||
|
};
|
||||||
|
if relative == file_path {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
sqlx::query("UPDATE furumusic__media_file SET file_path = $1 WHERE id = $2")
|
||||||
|
.bind(&relative)
|
||||||
|
.bind(id)
|
||||||
|
.execute(pool)
|
||||||
|
.await?;
|
||||||
|
updated += 1;
|
||||||
|
}
|
||||||
|
|
||||||
|
Ok(updated)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn app_root() -> PathBuf {
|
||||||
|
std::env::current_dir().unwrap_or_else(|_| PathBuf::from("."))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn normalize_slashes(value: &str) -> String {
|
||||||
|
value.trim().replace('\\', "/")
|
||||||
|
}
|
||||||
|
|
||||||
|
fn is_host_absolute(value: &str) -> bool {
|
||||||
|
Path::new(value).is_absolute()
|
||||||
|
}
|
||||||
|
|
||||||
|
fn looks_like_windows_absolute(value: &str) -> bool {
|
||||||
|
let bytes = value.as_bytes();
|
||||||
|
bytes.len() >= 3 && bytes[1] == b':' && bytes[2] == b'/' && bytes[0].is_ascii_alphabetic()
|
||||||
|
}
|
||||||
|
|
||||||
|
fn slash_path(value: &str) -> PathBuf {
|
||||||
|
value
|
||||||
|
.split('/')
|
||||||
|
.filter(|part| !part.is_empty() && *part != ".")
|
||||||
|
.fold(PathBuf::new(), |mut path, part| {
|
||||||
|
path.push(part);
|
||||||
|
path
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn normalize_relative_path(value: &str) -> Option<String> {
|
||||||
|
let parts: Vec<&str> = value
|
||||||
|
.split('/')
|
||||||
|
.filter(|part| !part.is_empty() && *part != ".")
|
||||||
|
.collect();
|
||||||
|
if parts.is_empty() || parts.iter().any(|part| *part == "..") {
|
||||||
|
return None;
|
||||||
|
}
|
||||||
|
Some(parts.join("/"))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn relative_path_string(path: &Path) -> Option<String> {
|
||||||
|
let mut parts = Vec::new();
|
||||||
|
for component in path.components() {
|
||||||
|
match component {
|
||||||
|
Component::Normal(value) => parts.push(value.to_string_lossy().to_string()),
|
||||||
|
Component::CurDir => {}
|
||||||
|
_ => return None,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if parts.is_empty() {
|
||||||
|
None
|
||||||
|
} else {
|
||||||
|
Some(parts.join("/"))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn extract_known_media_root(value: &str) -> Option<String> {
|
||||||
|
KNOWN_MEDIA_ROOTS
|
||||||
|
.iter()
|
||||||
|
.filter_map(|marker| relative_from_marker(value, marker, true))
|
||||||
|
.next()
|
||||||
|
}
|
||||||
|
|
||||||
|
fn relative_after_storage_marker(storage_root: &Path, value: &str) -> Option<String> {
|
||||||
|
let marker = storage_marker(storage_root)?;
|
||||||
|
relative_from_marker(value, &marker, false)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn relative_after_storage_marker_prefix(storage_root: &Path, value: &str) -> Option<String> {
|
||||||
|
let marker = storage_marker(storage_root)?;
|
||||||
|
let normalized = normalize_slashes(value);
|
||||||
|
let normalized_lower = normalized.to_ascii_lowercase();
|
||||||
|
let marker_lower = marker.to_ascii_lowercase();
|
||||||
|
if normalized_lower == marker_lower {
|
||||||
|
return None;
|
||||||
|
}
|
||||||
|
normalized_lower
|
||||||
|
.strip_prefix(&(marker_lower + "/"))
|
||||||
|
.and_then(|_| normalize_relative_path(&normalized[marker.len() + 1..]))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn storage_marker(storage_root: &Path) -> Option<String> {
|
||||||
|
let parts: Vec<String> = storage_root
|
||||||
|
.components()
|
||||||
|
.filter_map(|component| match component {
|
||||||
|
Component::Normal(value) => Some(value.to_string_lossy().to_string()),
|
||||||
|
_ => None,
|
||||||
|
})
|
||||||
|
.collect();
|
||||||
|
|
||||||
|
if parts.len() >= 2 {
|
||||||
|
Some(format!(
|
||||||
|
"{}/{}",
|
||||||
|
parts[parts.len() - 2],
|
||||||
|
parts[parts.len() - 1]
|
||||||
|
))
|
||||||
|
} else {
|
||||||
|
parts.last().cloned()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn relative_from_marker(value: &str, marker: &str, include_marker: bool) -> Option<String> {
|
||||||
|
let normalized = normalize_slashes(value);
|
||||||
|
let haystack = format!("/{}", normalized.trim_matches('/'));
|
||||||
|
let marker = marker.trim_matches('/');
|
||||||
|
let needle = format!("/{marker}");
|
||||||
|
let haystack_lower = haystack.to_ascii_lowercase();
|
||||||
|
let needle_lower = needle.to_ascii_lowercase();
|
||||||
|
let index = haystack_lower.rfind(&needle_lower)?;
|
||||||
|
let after_marker = index + needle.len();
|
||||||
|
if after_marker < haystack.len() && haystack.as_bytes().get(after_marker) != Some(&b'/') {
|
||||||
|
return None;
|
||||||
|
}
|
||||||
|
let tail = haystack[after_marker..].trim_matches('/');
|
||||||
|
if include_marker {
|
||||||
|
if tail.is_empty() {
|
||||||
|
Some(marker.to_string())
|
||||||
|
} else {
|
||||||
|
Some(format!("{marker}/{tail}"))
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
normalize_relative_path(tail)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::*;
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn resolves_relative_config_path_from_app_root() {
|
||||||
|
let expected = app_root().join("media").join("library");
|
||||||
|
assert_eq!(resolve_config_path_buf("media/library"), expected);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn maps_foreign_windows_config_media_root_to_app_root() {
|
||||||
|
let expected = app_root().join("media").join("uploads");
|
||||||
|
assert_eq!(
|
||||||
|
resolve_config_path_buf(r"C:\Users\ab\repos\furumusic\media\uploads"),
|
||||||
|
expected
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn stores_path_relative_to_storage_root() {
|
||||||
|
let storage = app_root().join("media").join("library");
|
||||||
|
let path = storage.join("Artist").join("Album").join("track.flac");
|
||||||
|
assert_eq!(
|
||||||
|
media_file_path_for_storage(&storage.to_string_lossy(), &path).as_deref(),
|
||||||
|
Some("Artist/Album/track.flac")
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn normalizes_legacy_windows_media_file_path() {
|
||||||
|
let storage = app_root().join("media").join("library");
|
||||||
|
assert_eq!(
|
||||||
|
normalize_stored_media_file_path(
|
||||||
|
&storage.to_string_lossy(),
|
||||||
|
r"C:\Users\ab\repos\furumusic\media\library\Buckethead\Pike\cover.jpg",
|
||||||
|
)
|
||||||
|
.as_deref(),
|
||||||
|
Some("Buckethead/Pike/cover.jpg")
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn strips_accidental_relative_storage_root_prefix() {
|
||||||
|
let storage = app_root().join("media").join("library");
|
||||||
|
assert_eq!(
|
||||||
|
normalize_stored_media_file_path(
|
||||||
|
&storage.to_string_lossy(),
|
||||||
|
"media/library/Buckethead/Pike/cover.jpg",
|
||||||
|
)
|
||||||
|
.as_deref(),
|
||||||
|
Some("Buckethead/Pike/cover.jpg")
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn resolves_legacy_windows_media_file_path_to_current_storage() {
|
||||||
|
let storage = app_root().join("media").join("library");
|
||||||
|
assert_eq!(
|
||||||
|
resolve_media_file_path(
|
||||||
|
&storage.to_string_lossy(),
|
||||||
|
r"C:\Users\ab\repos\furumusic\media\library\Buckethead\Pike\cover.jpg",
|
||||||
|
),
|
||||||
|
storage.join("Buckethead").join("Pike").join("cover.jpg")
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
+13
-11
@@ -217,10 +217,10 @@ async fn lastfm_connect_handler(
|
|||||||
};
|
};
|
||||||
let (config, _) = AppConfig::load_with_db(&db).await;
|
let (config, _) = AppConfig::load_with_db(&db).await;
|
||||||
let Some(credentials) = LastfmCredentials::from_config(&config) else {
|
let Some(credentials) = LastfmCredentials::from_config(&config) else {
|
||||||
return Ok(redirect_response("/?lastfm=not_configured"));
|
return Ok(redirect_response("/"));
|
||||||
};
|
};
|
||||||
let Some(origin) = request_origin(&request) else {
|
let Some(origin) = request_origin(&request) else {
|
||||||
return Ok(redirect_response("/?lastfm=bad_origin"));
|
return Ok(redirect_response("/"));
|
||||||
};
|
};
|
||||||
|
|
||||||
let state = uuid::Uuid::new_v4().simple().to_string();
|
let state = uuid::Uuid::new_v4().simple().to_string();
|
||||||
@@ -270,7 +270,7 @@ async fn lastfm_callback_handler(
|
|||||||
.map(str::trim)
|
.map(str::trim)
|
||||||
.filter(|v| !v.is_empty())
|
.filter(|v| !v.is_empty())
|
||||||
else {
|
else {
|
||||||
return Ok(redirect_response("/?lastfm=missing_token"));
|
return Ok(redirect_response("/"));
|
||||||
};
|
};
|
||||||
let Some(state) = query
|
let Some(state) = query
|
||||||
.0
|
.0
|
||||||
@@ -279,7 +279,7 @@ async fn lastfm_callback_handler(
|
|||||||
.map(str::trim)
|
.map(str::trim)
|
||||||
.filter(|v| !v.is_empty())
|
.filter(|v| !v.is_empty())
|
||||||
else {
|
else {
|
||||||
return Ok(redirect_response("/?lastfm=missing_state"));
|
return Ok(redirect_response("/"));
|
||||||
};
|
};
|
||||||
|
|
||||||
let state_user_id = sqlx::query_scalar::<_, i64>(
|
let state_user_id = sqlx::query_scalar::<_, i64>(
|
||||||
@@ -290,7 +290,7 @@ async fn lastfm_callback_handler(
|
|||||||
.await
|
.await
|
||||||
.map_err(|e| cot::Error::internal(e.to_string()))?;
|
.map_err(|e| cot::Error::internal(e.to_string()))?;
|
||||||
if state_user_id != Some(user.id) {
|
if state_user_id != Some(user.id) {
|
||||||
return Ok(redirect_response("/?lastfm=bad_state"));
|
return Ok(redirect_response("/"));
|
||||||
}
|
}
|
||||||
sqlx::query("DELETE FROM furumusic__lastfm_auth_state WHERE state = $1")
|
sqlx::query("DELETE FROM furumusic__lastfm_auth_state WHERE state = $1")
|
||||||
.bind(state)
|
.bind(state)
|
||||||
@@ -300,7 +300,7 @@ async fn lastfm_callback_handler(
|
|||||||
|
|
||||||
let (config, _) = AppConfig::load_with_db(&db).await;
|
let (config, _) = AppConfig::load_with_db(&db).await;
|
||||||
let Some(credentials) = LastfmCredentials::from_config(&config) else {
|
let Some(credentials) = LastfmCredentials::from_config(&config) else {
|
||||||
return Ok(redirect_response("/?lastfm=not_configured"));
|
return Ok(redirect_response("/"));
|
||||||
};
|
};
|
||||||
let client = LastfmClient::new(credentials).map_err(|e| cot::Error::internal(e.to_string()))?;
|
let client = LastfmClient::new(credentials).map_err(|e| cot::Error::internal(e.to_string()))?;
|
||||||
match client.get_session(token).await {
|
match client.get_session(token).await {
|
||||||
@@ -324,11 +324,11 @@ async fn lastfm_callback_handler(
|
|||||||
.execute(pool)
|
.execute(pool)
|
||||||
.await
|
.await
|
||||||
.map_err(|e| cot::Error::internal(e.to_string()))?;
|
.map_err(|e| cot::Error::internal(e.to_string()))?;
|
||||||
Ok(redirect_response("/?lastfm=connected"))
|
Ok(redirect_response("/"))
|
||||||
}
|
}
|
||||||
Err(err) => {
|
Err(err) => {
|
||||||
tracing::warn!("Last.fm auth failed for user {}: {err}", user.id);
|
tracing::warn!("Last.fm auth failed for user {}: {err}", user.id);
|
||||||
Ok(redirect_response("/?lastfm=auth_failed"))
|
Ok(redirect_response("/"))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1452,7 +1452,8 @@ async fn stream_handler(
|
|||||||
return Ok(json_error(StatusCode::NOT_FOUND, "track not found"));
|
return Ok(json_error(StatusCode::NOT_FOUND, "track not found"));
|
||||||
};
|
};
|
||||||
|
|
||||||
let full_path = std::path::Path::new(&config.agent_storage_dir).join(&media.file_path);
|
let full_path =
|
||||||
|
crate::media_paths::resolve_media_file_path(&config.agent_storage_dir, &media.file_path);
|
||||||
|
|
||||||
if !full_path.exists() {
|
if !full_path.exists() {
|
||||||
return Ok(json_error(
|
return Ok(json_error(
|
||||||
@@ -1521,7 +1522,7 @@ async fn local_upload_handler(
|
|||||||
"agent_inbox_dir is not configured",
|
"agent_inbox_dir is not configured",
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
let inbox_root = std::path::PathBuf::from(inbox_dir);
|
let inbox_root = crate::media_paths::resolve_config_path_buf(inbox_dir);
|
||||||
if !inbox_root.is_absolute() {
|
if !inbox_root.is_absolute() {
|
||||||
return Ok(json_error(
|
return Ok(json_error(
|
||||||
StatusCode::BAD_REQUEST,
|
StatusCode::BAD_REQUEST,
|
||||||
@@ -1744,7 +1745,8 @@ async fn cover_response(
|
|||||||
return Ok(json_error(StatusCode::NOT_FOUND, "media file not found"));
|
return Ok(json_error(StatusCode::NOT_FOUND, "media file not found"));
|
||||||
};
|
};
|
||||||
|
|
||||||
let full_path = std::path::Path::new(&config.agent_storage_dir).join(&media.file_path);
|
let full_path =
|
||||||
|
crate::media_paths::resolve_media_file_path(&config.agent_storage_dir, &media.file_path);
|
||||||
|
|
||||||
if !full_path.exists() {
|
if !full_path.exists() {
|
||||||
return Ok(json_error(StatusCode::NOT_FOUND, "file not found on disk"));
|
return Ok(json_error(StatusCode::NOT_FOUND, "file not found on disk"));
|
||||||
|
|||||||
@@ -1471,6 +1471,17 @@ pub async fn start_scheduler(
|
|||||||
Err(e) => tracing::error!("Failed to recover stale reviews: {e}"),
|
Err(e) => tracing::error!("Failed to recover stale reviews: {e}"),
|
||||||
}
|
}
|
||||||
|
|
||||||
|
let (live_config, _) = AppConfig::load_with_db(&db).await;
|
||||||
|
if !live_config.agent_storage_dir.trim().is_empty() {
|
||||||
|
match crate::media_paths::normalize_media_file_paths(&pool, &live_config.agent_storage_dir)
|
||||||
|
.await
|
||||||
|
{
|
||||||
|
Ok(0) => {}
|
||||||
|
Ok(n) => tracing::info!("Normalized {n} media file path(s) to relative storage paths"),
|
||||||
|
Err(e) => tracing::warn!("Failed to normalize media file paths: {e:#}"),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// Upsert ScheduledJob rows
|
// Upsert ScheduledJob rows
|
||||||
for job in registry.all_jobs() {
|
for job in registry.all_jobs() {
|
||||||
ScheduledJob::upsert(&db, job.name(), job.description(), job.default_cron())
|
ScheduledJob::upsert(&db, job.name(), job.description(), job.default_cron())
|
||||||
|
|||||||
+1
-1
@@ -1242,7 +1242,7 @@ fn validate_selection(files: &[TorrentFileDto], selected_files: &[usize]) -> any
|
|||||||
|
|
||||||
fn validate_inbox_dir(inbox_dir: &str) -> anyhow::Result<PathBuf> {
|
fn validate_inbox_dir(inbox_dir: &str) -> anyhow::Result<PathBuf> {
|
||||||
let trimmed = inbox_dir.trim();
|
let trimmed = inbox_dir.trim();
|
||||||
let path = PathBuf::from(trimmed);
|
let path = crate::media_paths::resolve_config_path_buf(trimmed);
|
||||||
if !path.is_absolute() {
|
if !path.is_absolute() {
|
||||||
bail!(
|
bail!(
|
||||||
"agent_inbox_dir must be an absolute path for this host, got `{}`",
|
"agent_inbox_dir must be an absolute path for this host, got `{}`",
|
||||||
|
|||||||
@@ -38,6 +38,8 @@ const T = {
|
|||||||
lastfmDisconnectConfirm: "{{ t.player_lastfm_disconnect_confirm }}",
|
lastfmDisconnectConfirm: "{{ t.player_lastfm_disconnect_confirm }}",
|
||||||
lastfmConnectFailed: "{{ t.player_lastfm_connect_failed }}",
|
lastfmConnectFailed: "{{ t.player_lastfm_connect_failed }}",
|
||||||
lastfmDisconnectFailed: "{{ t.player_lastfm_disconnect_failed }}",
|
lastfmDisconnectFailed: "{{ t.player_lastfm_disconnect_failed }}",
|
||||||
|
connectionLost: "{{ t.player_connection_lost }}",
|
||||||
|
connectionLostDetail: "{{ t.player_connection_lost_detail }}",
|
||||||
trackWord: "{{ t.player_tracks_count }}",
|
trackWord: "{{ t.player_tracks_count }}",
|
||||||
clientIdle: "{{ t.player_client_idle }}",
|
clientIdle: "{{ t.player_client_idle }}",
|
||||||
active: "{{ t.player_active }}",
|
active: "{{ t.player_active }}",
|
||||||
@@ -115,6 +117,42 @@ function coverVariantUrl(url, variant) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
document.addEventListener('alpine:init', () => {
|
document.addEventListener('alpine:init', () => {
|
||||||
|
// -----------------------------------------------------------------------
|
||||||
|
// Connection monitor
|
||||||
|
// -----------------------------------------------------------------------
|
||||||
|
Alpine.store('connection', {
|
||||||
|
failureCount: 0,
|
||||||
|
disconnected: false,
|
||||||
|
threshold: 2,
|
||||||
|
|
||||||
|
init() {
|
||||||
|
if (navigator.onLine === false) {
|
||||||
|
this.failureCount = this.threshold;
|
||||||
|
this.disconnected = true;
|
||||||
|
}
|
||||||
|
window.addEventListener('online', () => this.recordSuccess());
|
||||||
|
window.addEventListener('offline', () => this.recordFailure());
|
||||||
|
},
|
||||||
|
|
||||||
|
message() {
|
||||||
|
return T.connectionLostDetail;
|
||||||
|
},
|
||||||
|
|
||||||
|
recordSuccess() {
|
||||||
|
this.failureCount = 0;
|
||||||
|
this.disconnected = false;
|
||||||
|
},
|
||||||
|
|
||||||
|
recordFailure() {
|
||||||
|
this.failureCount += 1;
|
||||||
|
if (this.failureCount >= this.threshold) {
|
||||||
|
this.disconnected = true;
|
||||||
|
}
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
installConnectionFetchMonitor();
|
||||||
|
|
||||||
// -----------------------------------------------------------------------
|
// -----------------------------------------------------------------------
|
||||||
// Audio element
|
// Audio element
|
||||||
// -----------------------------------------------------------------------
|
// -----------------------------------------------------------------------
|
||||||
@@ -174,10 +212,19 @@ document.addEventListener('alpine:init', () => {
|
|||||||
lastfmBusy: false,
|
lastfmBusy: false,
|
||||||
|
|
||||||
init() {
|
init() {
|
||||||
|
this.cleanLastfmQuery();
|
||||||
this.load();
|
this.load();
|
||||||
this.loadLastfm();
|
this.loadLastfm();
|
||||||
},
|
},
|
||||||
|
|
||||||
|
cleanLastfmQuery() {
|
||||||
|
const url = new URL(window.location.href);
|
||||||
|
if (!url.searchParams.has('lastfm')) return;
|
||||||
|
url.searchParams.delete('lastfm');
|
||||||
|
const clean = `${url.pathname}${url.search}${url.hash}`;
|
||||||
|
window.history.replaceState({}, document.title, clean || '/');
|
||||||
|
},
|
||||||
|
|
||||||
async load() {
|
async load() {
|
||||||
try {
|
try {
|
||||||
const res = await fetch('/api/player/me');
|
const res = await fetch('/api/player/me');
|
||||||
@@ -447,9 +494,13 @@ document.addEventListener('alpine:init', () => {
|
|||||||
const queue = Alpine.store('queue');
|
const queue = Alpine.store('queue');
|
||||||
if (queue.tracks.length === 0) return;
|
if (queue.tracks.length === 0) return;
|
||||||
|
|
||||||
|
this._recordHistoryIfListenThresholdReached();
|
||||||
|
|
||||||
let nextIdx;
|
let nextIdx;
|
||||||
if (this.repeatMode === 'one') {
|
if (this.repeatMode === 'one') {
|
||||||
this.seek(0);
|
this.seek(0);
|
||||||
|
this._historyRecorded = false;
|
||||||
|
this._resetPlaybackTracking();
|
||||||
this.resume();
|
this.resume();
|
||||||
return;
|
return;
|
||||||
} else if (this.shuffle) {
|
} else if (this.shuffle) {
|
||||||
@@ -655,6 +706,18 @@ document.addEventListener('alpine:init', () => {
|
|||||||
}).catch(() => {});
|
}).catch(() => {});
|
||||||
},
|
},
|
||||||
|
|
||||||
|
_recordHistoryIfListenThresholdReached() {
|
||||||
|
if (this._historyRecorded || !this.currentTrack) return false;
|
||||||
|
this._trackListenedDelta();
|
||||||
|
const duration = this._trackDuration();
|
||||||
|
if (duration <= 0) return false;
|
||||||
|
const listened = Math.floor(Number(this._listenedSeconds || 0));
|
||||||
|
const threshold = Math.ceil(duration / 2);
|
||||||
|
if (threshold <= 0 || listened < threshold) return false;
|
||||||
|
this._recordHistory(true);
|
||||||
|
return true;
|
||||||
|
},
|
||||||
|
|
||||||
_resetPlaybackTracking() {
|
_resetPlaybackTracking() {
|
||||||
this._nowPlayingSent = false;
|
this._nowPlayingSent = false;
|
||||||
this._playbackStartedAt = null;
|
this._playbackStartedAt = null;
|
||||||
@@ -2294,4 +2357,39 @@ document.addEventListener('alpine:init', () => {
|
|||||||
},
|
},
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
function installConnectionFetchMonitor() {
|
||||||
|
if (window.__furumusicConnectionMonitorInstalled || !window.fetch) return;
|
||||||
|
window.__furumusicConnectionMonitorInstalled = true;
|
||||||
|
const nativeFetch = window.fetch.bind(window);
|
||||||
|
|
||||||
|
window.fetch = async (...args) => {
|
||||||
|
const tracked = isTrackedPlayerRequest(args[0]);
|
||||||
|
try {
|
||||||
|
const response = await nativeFetch(...args);
|
||||||
|
if (tracked) {
|
||||||
|
if (response.status >= 500) {
|
||||||
|
Alpine.store('connection')?.recordFailure();
|
||||||
|
} else {
|
||||||
|
Alpine.store('connection')?.recordSuccess();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return response;
|
||||||
|
} catch (error) {
|
||||||
|
if (tracked) Alpine.store('connection')?.recordFailure();
|
||||||
|
throw error;
|
||||||
|
}
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function isTrackedPlayerRequest(input) {
|
||||||
|
const rawUrl = typeof input === 'string' ? input : input?.url;
|
||||||
|
if (!rawUrl) return false;
|
||||||
|
try {
|
||||||
|
const url = new URL(rawUrl, window.location.href);
|
||||||
|
return url.origin === window.location.origin && url.pathname.startsWith('/api/player/');
|
||||||
|
} catch {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
}
|
||||||
</script>
|
</script>
|
||||||
|
|||||||
@@ -275,6 +275,20 @@
|
|||||||
<path d="M4 4.5A2.5 2.5 0 016.5 2H20v20H6.5A2.5 2.5 0 014 19.5z"/>
|
<path d="M4 4.5A2.5 2.5 0 016.5 2H20v20H6.5A2.5 2.5 0 014 19.5z"/>
|
||||||
</svg>
|
</svg>
|
||||||
</button>
|
</button>
|
||||||
|
<div class="connection-alert"
|
||||||
|
x-show="$store.connection.disconnected"
|
||||||
|
x-cloak
|
||||||
|
:title="$store.connection.message()"
|
||||||
|
role="status"
|
||||||
|
aria-live="polite">
|
||||||
|
<svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2">
|
||||||
|
<path d="M2 8.82a15 15 0 0120 0"/>
|
||||||
|
<path d="M5 12.86a10 10 0 0114 0"/>
|
||||||
|
<path d="M8.5 16.43a5 5 0 017 0"/>
|
||||||
|
<line x1="2" y1="2" x2="22" y2="22"/>
|
||||||
|
</svg>
|
||||||
|
<span class="connection-alert-text">{{ t.player_connection_lost }}</span>
|
||||||
|
</div>
|
||||||
<div class="search-bar">
|
<div class="search-bar">
|
||||||
<span class="search-icon"><svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"><circle cx="11" cy="11" r="8"/><line x1="21" y1="21" x2="16.65" y2="16.65"/></svg></span>
|
<span class="search-icon"><svg viewBox="0 0 24 24" fill="none" stroke="currentColor" stroke-width="2"><circle cx="11" cy="11" r="8"/><line x1="21" y1="21" x2="16.65" y2="16.65"/></svg></span>
|
||||||
<input id="search-input" type="text" placeholder="{{ t.player_search_placeholder }}"
|
<input id="search-input" type="text" placeholder="{{ t.player_search_placeholder }}"
|
||||||
|
|||||||
@@ -1377,6 +1377,37 @@ button.user-stat:hover {
|
|||||||
margin-bottom: 20px;
|
margin-bottom: 20px;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.connection-alert {
|
||||||
|
flex: 0 0 auto;
|
||||||
|
min-width: 42px;
|
||||||
|
height: 42px;
|
||||||
|
padding: 0 12px;
|
||||||
|
border: 1px solid rgba(248, 113, 113, 0.34);
|
||||||
|
border-radius: 8px;
|
||||||
|
background: rgba(127, 29, 29, 0.2);
|
||||||
|
color: #f87171;
|
||||||
|
display: flex;
|
||||||
|
align-items: center;
|
||||||
|
justify-content: center;
|
||||||
|
gap: 8px;
|
||||||
|
}
|
||||||
|
|
||||||
|
.connection-alert svg {
|
||||||
|
width: 18px;
|
||||||
|
height: 18px;
|
||||||
|
flex: 0 0 auto;
|
||||||
|
}
|
||||||
|
|
||||||
|
.connection-alert-text {
|
||||||
|
min-width: 0;
|
||||||
|
overflow: hidden;
|
||||||
|
text-overflow: ellipsis;
|
||||||
|
white-space: nowrap;
|
||||||
|
color: #fecaca;
|
||||||
|
font-size: 12px;
|
||||||
|
font-weight: 700;
|
||||||
|
}
|
||||||
|
|
||||||
/* Search bar */
|
/* Search bar */
|
||||||
.search-bar {
|
.search-bar {
|
||||||
position: relative;
|
position: relative;
|
||||||
@@ -2676,6 +2707,15 @@ button.user-stat:hover {
|
|||||||
flex: 1 1 auto;
|
flex: 1 1 auto;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
.connection-alert {
|
||||||
|
width: 42px;
|
||||||
|
padding: 0;
|
||||||
|
}
|
||||||
|
|
||||||
|
.connection-alert-text {
|
||||||
|
display: none;
|
||||||
|
}
|
||||||
|
|
||||||
.mobile-library-btn {
|
.mobile-library-btn {
|
||||||
display: flex;
|
display: flex;
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user