From 2196f6635b88ff3526a84850327f5438fa4b8402 Mon Sep 17 00:00:00 2001 From: Ultradesu Date: Fri, 2 Oct 2026 12:06:04 +0100 Subject: [PATCH] Quiet the cosmetic zig linker_messages warning on the musl build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The musl release build now links cleanly through cargo-zigbuild, but rustc's new linker_messages lint echoed zig's "ignoring deprecated linker optimization setting '1'" note — zig's linker declining the -O1 GNU-ld flag Rust passes. It is cosmetic and the binary is correct, so allow that one lint, scoped to the zig build step only. macOS and Windows keep full linker diagnostics, and a real link error still fails the build. No behaviour change to the produced binaries; takes effect on the next tag. Co-Authored-By: Claude Opus 4.8 --- .github/workflows/release.yml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index ebd5d6c..0323480 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -88,6 +88,12 @@ jobs: run: | set -euo pipefail if [[ "${{ matrix.zig }}" == "true" ]]; then + # zig's linker ignores the `-O1` GNU-ld optimization flag Rust passes + # and says so on stderr, which rustc now surfaces as a linker_messages + # warning. It is cosmetic — the binary is correct — so quiet just that + # one lint to keep the musl build log clean. A real link error still + # fails the build. + export RUSTFLAGS="${RUSTFLAGS:-} -A linker_messages" cargo zigbuild --release --locked --target "${{ matrix.target }}" --bin tsunagi else cargo build --release --locked --target "${{ matrix.target }}" --bin tsunagi