Compare commits

...
3 Commits
Author SHA1 Message Date
Ultradesu 3a75c7d848 Fixed history DTO view
Build and Publish / Build and Publish Docker Image (push) Successful in 4m6s
2026-07-28 08:34:29 +01:00
Ultradesu dc1fac1a94 hotfix
Build and Publish / Build and Publish Docker Image (push) Successful in 5m51s
2026-07-28 00:01:36 +01:00
Ultradesu 122214a896 Fixed playback history window
Build and Publish / Build and Publish Docker Image (push) Successful in 5m20s
2026-07-27 23:41:29 +01:00
7 changed files with 148 additions and 23 deletions
Generated
+1 -1
View File
@@ -1835,7 +1835,7 @@ checksum = "e6d5a32815ae3f33302d95fdcb2ce17862f8c65363dcfd29360480ba1001fc9c"
[[package]]
name = "furumusic"
version = "0.9.4"
version = "0.9.5"
dependencies = [
"anyhow",
"async-stream",
+1 -1
View File
@@ -1,6 +1,6 @@
[package]
name = "furumusic"
version = "0.9.4"
version = "0.9.6"
edition = "2024"
description = "Reusable web-app boilerplate: auth, OIDC/SSO, admin panel, user management, i18n, PostgreSQL"
+43
View File
@@ -2434,6 +2434,48 @@ pub mod db_migrations {
&[Operation::custom(create_synced_listen_history).build()];
}
#[cot::db::migrations::migration_op]
async fn repair_legacy_listen_qualification(
ctx: migrations::MigrationContext<'_>,
) -> cot::db::Result<()> {
ctx.db
.raw(
"UPDATE furumusic__listen_event le
SET qualified = (
ph.completed
OR (
COALESCE(ph.duration_listened, 0) >= 5
AND COALESCE(t.duration_seconds, 0) > 0
AND COALESCE(ph.duration_listened, 0) >= LEAST(
COALESCE(t.duration_seconds, 0) / 2.0,
240.0
)
)
)
FROM furumusic__play_history ph
JOIN furumusic__track t ON t.id = ph.track_id
WHERE le.user_id = ph.user_id
AND le.listen_id = 'legacy-web:' || ph.id::text",
)
.await?;
Ok(())
}
#[derive(Debug, Copy, Clone)]
pub struct M0042RepairLegacyListenQualification;
impl migrations::Migration for M0042RepairLegacyListenQualification {
const APP_NAME: &'static str = "furumusic";
const MIGRATION_NAME: &'static str = "m_0042_repair_legacy_listen_qualification";
const DEPENDENCIES: &'static [migrations::MigrationDependency] =
&[migrations::MigrationDependency::migration(
"furumusic",
"m_0041_create_synced_listen_history",
)];
const OPERATIONS: &'static [Operation] =
&[Operation::custom(repair_legacy_listen_qualification).build()];
}
pub const MIGRATIONS: &[&SyncDynMigration] = &[
&M0006CreateMediaFile,
&M0007CreateArtist,
@@ -2466,5 +2508,6 @@ pub mod db_migrations {
&M0039EnsureFederationContentIdCache,
&M0040CreateContentAddressedMusicRefs,
&M0041CreateSyncedListenHistory,
&M0042RepairLegacyListenQualification,
];
}
+75 -15
View File
@@ -1259,15 +1259,19 @@ async fn me_handler(
.await
.map_err(|e| cot::Error::internal(e.to_string()))?;
let plays: (i64,) =
sqlx::query_as("SELECT COUNT(*) FROM furumusic__play_history WHERE user_id = $1")
.bind(user.id)
.fetch_one(pool)
.await
.map_err(|e| cot::Error::internal(e.to_string()))?;
let plays: (i64,) = sqlx::query_as(
"SELECT COUNT(*) FROM furumusic__listen_event
WHERE user_id = $1 AND qualified = true",
)
.bind(user.id)
.fetch_one(pool)
.await
.map_err(|e| cot::Error::internal(e.to_string()))?;
let listened_seconds: Option<i64> = sqlx::query_scalar(
"SELECT COALESCE(SUM(duration_listened), 0) FROM furumusic__play_history WHERE user_id = $1",
"SELECT (COALESCE(SUM(listened_ms), 0) / 1000)::bigint
FROM furumusic__listen_event
WHERE user_id = $1 AND qualified = true",
)
.bind(user.id)
.fetch_one(pool)
@@ -5573,7 +5577,8 @@ async fn history_list_handler(
.map_err(|e| cot::Error::internal(e.to_string()))?;
let rows = sqlx::query(
"SELECT le.listen_id, le.content_id, le.local_track_id,
"SELECT le.listen_id, le.content_id,
COALESCE(le.local_track_id, tr.local_track_id) AS local_track_id,
le.origin_device_id, le.started_at_ms, le.listened_ms,
le.track_duration_ms, le.metadata_json,
COALESCE(NULLIF(d.name, ''), le.origin_device_id) AS device_name,
@@ -5582,7 +5587,9 @@ async fn history_list_handler(
FROM furumusic__listen_event le
LEFT JOIN furumusic__fed_device d
ON d.user_id = le.user_id AND d.device_id = le.origin_device_id
LEFT JOIN furumusic__track t ON t.id = le.local_track_id
LEFT JOIN furumusic__track_ref tr ON tr.content_id = le.content_id
LEFT JOIN furumusic__track t
ON t.id = COALESCE(le.local_track_id, tr.local_track_id)
LEFT JOIN furumusic__release r ON r.id = t.release_id
WHERE le.user_id = $1 AND le.qualified = true
ORDER BY le.started_at_ms DESC, le.listen_id DESC
@@ -5595,19 +5602,62 @@ async fn history_list_handler(
.await
.map_err(|e| cot::Error::internal(e.to_string()))?;
// Listen metadata is an immutable snapshot. Once federated content has
// been materialized, resolve it through the content cache and use the
// normal local TrackItem as the presentation/action authority.
let content_ids = rows
.iter()
.map(|row| row.get::<String, _>("content_id"))
.collect::<Vec<_>>();
let local_rows = if content_ids.is_empty() {
Vec::new()
} else {
sqlx::query(
r#"SELECT DISTINCT ON (c.content_id) c.content_id, t.id AS track_id
FROM furumusic__federation_content_id_cache c
JOIN furumusic__media_file m
ON m.id = c.media_file_id AND m.sha256_hash = c.sha256_hash
JOIN furumusic__track t ON t.audio_file_id = m.id
JOIN furumusic__release r ON r.id = t.release_id
WHERE c.content_id = ANY($1)
AND t.is_hidden = false
AND r.is_hidden = false
ORDER BY c.content_id, t.id"#,
)
.bind(&content_ids)
.fetch_all(pool)
.await
.map_err(|e| cot::Error::internal(e.to_string()))?
};
let local_by_content = local_rows
.into_iter()
.map(|row| {
(
row.get::<String, _>("content_id"),
row.get::<i64, _>("track_id"),
)
})
.collect::<HashMap<_, _>>();
let local_ids = local_by_content.values().copied().collect::<Vec<_>>();
let local_tracks = load_track_items_by_ids(pool, &local_ids)
.await?
.into_iter()
.map(|track| (track.id, track))
.collect::<HashMap<_, _>>();
let items = rows
.into_iter()
.map(|row| {
let listen_id: String = row.get("listen_id");
let content_id: String = row.get("content_id");
let local_track_id: Option<i64> = row.get("local_track_id");
let local_track_id = local_by_content.get(&content_id).copied();
let metadata: serde_json::Value = row.get("metadata_json");
let title = metadata
let snapshot_title = metadata
.get("title")
.and_then(serde_json::Value::as_str)
.unwrap_or("Unknown track")
.to_string();
let release_title = metadata
let snapshot_release_title = metadata
.get("release_title")
.and_then(serde_json::Value::as_str)
.map(ToOwned::to_owned);
@@ -5628,20 +5678,20 @@ async fn history_list_handler(
row.get("release_cover_file_id"),
"medium",
);
let track = serde_json::json!({
let fallback_track = serde_json::json!({
"id": local_track_id.map_or_else(
|| format!("history:{content_id}"),
|id| id.to_string(),
),
"content_id": content_id,
"title": title,
"title": snapshot_title,
"track_number": null,
"disc_number": null,
"duration_seconds": duration_ms.unwrap_or_default() as f64 / 1000.0,
"artists": artist_values("artist_names"),
"featured_artists": artist_values("featured_artist_names"),
"release_id": release_id,
"release_title": release_title.clone().unwrap_or_default(),
"release_title": snapshot_release_title.clone().unwrap_or_default(),
"release_year": row.get::<Option<i32>, _>("release_year"),
"cover_url": cover_url,
"stream_url": local_track_id
@@ -5663,6 +5713,16 @@ async fn history_list_handler(
None
},
});
let local_track = local_track_id.and_then(|id| local_tracks.get(&id));
let track = local_track
.and_then(|track| serde_json::to_value(track).ok())
.unwrap_or(fallback_track);
let title = local_track
.map(|track| track.title.clone())
.unwrap_or(snapshot_title);
let release_title = local_track
.map(|track| track.release_title.clone())
.or(snapshot_release_title);
let started_at_ms: i64 = row.get("started_at_ms");
let played_at = chrono::DateTime::from_timestamp_millis(started_at_ms)
.unwrap_or_else(chrono::Utc::now)
+13 -4
View File
@@ -4019,6 +4019,9 @@ document.addEventListener('alpine:init', () => {
playable,
});
this.refreshMaterializedArtwork(track);
Alpine.store('likes')?.reload();
const history = Alpine.store('history');
if (history?.modal) history.load(history.page);
}
const finalProgress = this.federationPreparing[contentId] || {};
const queueIndex = Number.isInteger(finalProgress.queueIndex)
@@ -4129,10 +4132,16 @@ document.addEventListener('alpine:init', () => {
_set: new Set(),
init() {
fetch('/api/player/likes')
.then(r => r.json())
.then(d => { this._set = new Set(d.track_ids || []); })
.catch(() => {});
this.reload();
},
async reload() {
try {
const response = await fetch('/api/player/likes');
if (!response.ok) return;
const data = await response.json();
this._set = new Set(data.track_ids || []);
} catch {}
},
has(trackId) {
+5 -1
View File
@@ -1626,7 +1626,11 @@
x-text="'-' + formatTime(Math.max(0, $store.player.duration - $store.player.currentTime)) + ' / ' + formatTime($store.player.duration)"></div>
<span class="player-time" x-text="formatTime($store.player.duration)"></span>
</div>
<div class="player-version-chip">v{{ t.app_version() }}</div>
<a class="player-version-chip"
href="https://github.com/house-of-vanity/furumusic"
target="_blank"
rel="noopener noreferrer"
aria-label="Furumusic on GitHub">v{{ t.app_version() }}</a>
</div>
<div class="player-right">
+10 -1
View File
@@ -2437,7 +2437,16 @@ button.user-stat:hover {
line-height: 1;
font-weight: 500;
text-align: center;
pointer-events: none;
text-decoration: none;
pointer-events: auto;
transition: opacity 120ms ease;
}
.player-version-chip:hover,
.player-version-chip:focus-visible {
color: var(--text-subdued);
opacity: 0.9;
text-decoration: none;
}
.mobile-account-chip {